Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unused code #57219

Merged
merged 3 commits into from
Jan 5, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions src/librustc/ich/impls_ty.rs
Original file line number Diff line number Diff line change
Expand Up @@ -473,22 +473,6 @@ impl_stable_hash_for!(enum mir::interpret::InboundsCheck {
MaybeDead
});

impl_stable_hash_for!(enum mir::interpret::Lock {
NoLock,
WriteLock(dl),
ReadLock(v)
});

impl_stable_hash_for!(struct mir::interpret::DynamicLifetime {
frame,
region
});

impl_stable_hash_for!(enum mir::interpret::AccessKind {
Read,
Write
});

impl_stable_hash_for!(enum ty::Variance {
Covariant,
Invariant,
Expand Down
22 changes: 0 additions & 22 deletions src/librustc/mir/interpret/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ use mir;
use hir::def_id::DefId;
use ty::{self, TyCtxt, Instance};
use ty::layout::{self, Size};
use middle::region;
use std::io;
use rustc_serialize::{Encoder, Decodable, Encodable};
use rustc_data_structures::fx::FxHashMap;
Expand All @@ -40,27 +39,6 @@ use ty::codec::TyDecoder;
use std::sync::atomic::{AtomicU32, Ordering};
use std::num::NonZeroU32;

#[derive(Clone, Debug, PartialEq, Eq, Hash, RustcEncodable, RustcDecodable)]
RalfJung marked this conversation as resolved.
Show resolved Hide resolved
pub enum Lock {
NoLock,
WriteLock(DynamicLifetime),
/// This should never be empty -- that would be a read lock held and nobody
/// there to release it...
ReadLock(Vec<DynamicLifetime>),
}

#[derive(Copy, Clone, Debug, PartialEq, Eq, Hash, RustcEncodable, RustcDecodable)]
pub struct DynamicLifetime {
pub frame: usize,
pub region: Option<region::Scope>, // "None" indicates "until the function ends"
}

#[derive(Copy, Clone, Debug, PartialEq, Eq, RustcEncodable, RustcDecodable)]
pub enum AccessKind {
Read,
Write,
}

/// Uniquely identifies a specific constant or static.
#[derive(Copy, Clone, Debug, Eq, PartialEq, Hash, RustcEncodable, RustcDecodable)]
pub struct GlobalId<'tcx> {
Expand Down
4 changes: 0 additions & 4 deletions src/librustc/session/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1309,12 +1309,8 @@ options! {DebuggingOptions, DebuggingSetter, basic_debugging_options,
"Disable the instrumentation pre-inliner, useful for profiling / PGO."),
relro_level: Option<RelroLevel> = (None, parse_relro_level, [TRACKED],
"choose which RELRO level to use"),
nll_subminimal_causes: bool = (false, parse_bool, [UNTRACKED],
"when tracking region error causes, accept subminimal results for faster execution."),
nll_facts: bool = (false, parse_bool, [UNTRACKED],
"dump facts from NLL analysis into side files"),
disable_nll_user_type_assert: bool = (false, parse_bool, [UNTRACKED],
"disable user provided type assertion in NLL"),
nll_dont_emit_read_for_match: bool = (false, parse_bool, [UNTRACKED],
"in match codegen, do not include FakeRead statements (used by mir-borrowck)"),
dont_buffer_diagnostics: bool = (false, parse_bool, [UNTRACKED],
Expand Down
14 changes: 0 additions & 14 deletions src/librustc_mir/dataflow/impls/borrows.rs
Original file line number Diff line number Diff line change
Expand Up @@ -279,20 +279,6 @@ impl<'a, 'gcx, 'tcx> BitDenotation<'tcx> for Borrows<'a, 'gcx, 'tcx> {
});

sets.gen(*index);

// Issue #46746: Two-phase borrows handles
// stmts of form `Tmp = &mut Borrow` ...
match lhs {
Place::Promoted(_) |
Place::Local(..) | Place::Static(..) => {} // okay
Place::Projection(..) => {
// ... can assign into projections,
// e.g., `box (&mut _)`. Current
// conservative solution: force
// immediate activation here.
sets.gen(*index);
}
}
}
}

Expand Down
1 change: 0 additions & 1 deletion src/test/run-pass/generator/yield-subtype.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
#![allow(dead_code)]

// revisions:lexical nll
//[nll]compile-flags: -Z disable-nll-user-type-assert
#![cfg_attr(nll, feature(nll))]

#![feature(generators)]
Expand Down
6 changes: 3 additions & 3 deletions src/test/ui/span/dropck_vec_cycle_checked.nll.stderr
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error[E0597]: `c2` does not live long enough
--> $DIR/dropck_vec_cycle_checked.rs:103:24
--> $DIR/dropck_vec_cycle_checked.rs:98:24
|
LL | c1.v[0].v.set(Some(&c2));
| ^^^ borrowed value does not live long enough
Expand All @@ -13,7 +13,7 @@ LL | }
= note: values in a scope are dropped in the opposite order they are defined

error[E0597]: `c3` does not live long enough
--> $DIR/dropck_vec_cycle_checked.rs:105:24
--> $DIR/dropck_vec_cycle_checked.rs:100:24
|
LL | c1.v[1].v.set(Some(&c3));
| ^^^ borrowed value does not live long enough
Expand All @@ -27,7 +27,7 @@ LL | }
= note: values in a scope are dropped in the opposite order they are defined

error[E0597]: `c1` does not live long enough
--> $DIR/dropck_vec_cycle_checked.rs:111:24
--> $DIR/dropck_vec_cycle_checked.rs:106:24
|
LL | c3.v[0].v.set(Some(&c1));
| ^^^ borrowed value does not live long enough
Expand Down
5 changes: 0 additions & 5 deletions src/test/ui/span/dropck_vec_cycle_checked.rs
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
// compile-flags: -Z nll-subminimal-causes
// (Work around rust-lang/rust#49998 by opting into nll-subminimal-causes.)

// Reject mixing cyclic structure and Drop when using Vec.
//
// (Compare against compile-fail/dropck_arr_cycle_checked.rs)



use std::cell::Cell;
use id::Id;

Expand Down
12 changes: 6 additions & 6 deletions src/test/ui/span/dropck_vec_cycle_checked.stderr
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error[E0597]: `c2` does not live long enough
--> $DIR/dropck_vec_cycle_checked.rs:103:25
--> $DIR/dropck_vec_cycle_checked.rs:98:25
|
LL | c1.v[0].v.set(Some(&c2));
| ^^ borrowed value does not live long enough
Expand All @@ -10,7 +10,7 @@ LL | }
= note: values in a scope are dropped in the opposite order they are created

error[E0597]: `c3` does not live long enough
--> $DIR/dropck_vec_cycle_checked.rs:105:25
--> $DIR/dropck_vec_cycle_checked.rs:100:25
|
LL | c1.v[1].v.set(Some(&c3));
| ^^ borrowed value does not live long enough
Expand All @@ -21,7 +21,7 @@ LL | }
= note: values in a scope are dropped in the opposite order they are created

error[E0597]: `c2` does not live long enough
--> $DIR/dropck_vec_cycle_checked.rs:107:25
--> $DIR/dropck_vec_cycle_checked.rs:102:25
|
LL | c2.v[0].v.set(Some(&c2));
| ^^ borrowed value does not live long enough
Expand All @@ -32,7 +32,7 @@ LL | }
= note: values in a scope are dropped in the opposite order they are created

error[E0597]: `c3` does not live long enough
--> $DIR/dropck_vec_cycle_checked.rs:109:25
--> $DIR/dropck_vec_cycle_checked.rs:104:25
|
LL | c2.v[1].v.set(Some(&c3));
| ^^ borrowed value does not live long enough
Expand All @@ -43,7 +43,7 @@ LL | }
= note: values in a scope are dropped in the opposite order they are created

error[E0597]: `c1` does not live long enough
--> $DIR/dropck_vec_cycle_checked.rs:111:25
--> $DIR/dropck_vec_cycle_checked.rs:106:25
|
LL | c3.v[0].v.set(Some(&c1));
| ^^ borrowed value does not live long enough
Expand All @@ -54,7 +54,7 @@ LL | }
= note: values in a scope are dropped in the opposite order they are created

error[E0597]: `c2` does not live long enough
--> $DIR/dropck_vec_cycle_checked.rs:113:25
--> $DIR/dropck_vec_cycle_checked.rs:108:25
|
LL | c3.v[1].v.set(Some(&c2));
| ^^ borrowed value does not live long enough
Expand Down