Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bound sgx target_env with fortanix as target_vendor #57243

Merged
merged 3 commits into from
Jan 2, 2019
Merged

Bound sgx target_env with fortanix as target_vendor #57243

merged 3 commits into from
Jan 2, 2019

Conversation

dingelish
Copy link
Contributor

This PR adds target_vendor check, as discussed in issue 57231

Signed-off-by: Yu Ding dingelish@gmail.com

Signed-off-by: Yu Ding <dingelish@gmail.com>
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 1, 2019
Copy link
Contributor

@jethrogb jethrogb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

#![cfg_attr(all(target_vendor = "fortanix", target_env = "sgx"),
feature(global_asm, range_contains, slice_index_methods,
decl_macro, coerce_unsized, sgx_platform,
min_const_unsafe_fn))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: the feature `min_const_unsafe_fn` has been stable since 1.33.0 and no longer requires an attribute to enable
   --> src/libstd/lib.rs:308:21
    |
308 |                     min_const_unsafe_fn))]
    |                     ^^^^^^^^^^^^^^^^^^^
    |
    = note: #[warn(stable_features)] on by default

But I can take care of this in a future PR.

@sfackler
Copy link
Member

sfackler commented Jan 2, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Jan 2, 2019

📌 Commit 20e0395 has been approved by sfackler

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2019
@bors
Copy link
Contributor

bors commented Jan 2, 2019

⌛ Testing commit 20e0395 with merge ec19464...

bors added a commit that referenced this pull request Jan 2, 2019
Bound sgx target_env with fortanix as target_vendor

This PR adds `target_vendor` check, as discussed in issue [57231](#57231)

Signed-off-by: Yu Ding <dingelish@gmail.com>
@bors
Copy link
Contributor

bors commented Jan 2, 2019

☀️ Test successful - status-appveyor, status-travis
Approved by: sfackler
Pushing ec19464 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants