Make privacy checking, intrinsic checking and liveness checking incremental #57253

Zoxc · 2019-01-02T00:46:38Z

Blocked on #51487

r? @michaelwoerister

Zoxc · 2019-01-02T08:06:09Z

@bors try

bors · 2019-01-02T08:06:22Z

⌛ Trying commit 31241cedc0d9fc3d3cb8f29cfea9150ec57c3cb1 with merge d9689e3fc0e3cbf86c95524c2672ce17f9fb4cac...

bors · 2019-01-02T10:42:43Z

☀️ Test successful - status-travis
State: approved= try=True

Zoxc · 2019-01-02T12:50:01Z

@rust-timer build d9689e3fc0e3cbf86c95524c2672ce17f9fb4cac

rust-timer · 2019-01-02T12:50:02Z

Success: Queued d9689e3fc0e3cbf86c95524c2672ce17f9fb4cac with parent 9653034, comparison URL.

rust-timer · 2019-01-02T15:50:49Z

Finished benchmarking try commit d9689e3fc0e3cbf86c95524c2672ce17f9fb4cac

bors · 2019-01-13T22:31:07Z

☔ The latest upstream changes (presumably #51487) made this pull request unmergeable. Please resolve the merge conflicts.

Zoxc · 2019-01-14T01:12:50Z

@bors try

bors · 2019-01-14T01:13:01Z

⌛ Trying commit 959c870 with merge 9fcae8a0e896f370b12630f6fa9fef24ead2f08a...

Zoxc · 2019-01-14T05:54:15Z

@rust-timer build 9fcae8a0e896f370b12630f6fa9fef24ead2f08a

rust-timer · 2019-01-14T05:54:16Z

Success: Queued 9fcae8a0e896f370b12630f6fa9fef24ead2f08a with parent 9aee7ed, comparison URL.

rust-timer · 2019-01-14T07:59:29Z

Finished benchmarking try commit 9fcae8a0e896f370b12630f6fa9fef24ead2f08a

michaelwoerister

Thanks, @Zoxc! Looks great! I left a couple of minor nits, r=me with those addressed.

Oh my, adding a query needs a lot of boilerplate ...

michaelwoerister · 2019-01-14T11:00:57Z

src/librustc_privacy/lib.rs

+
+    let krate = tcx.hir().krate();
+
+    for &module in tcx.hir().krate().modules.keys() {


Could you re-use the krate binding here that is created the line before. Otherwise it might be confusing, i.e. one might think that's some special reason why tcx.hir().krate() is called twice here.

michaelwoerister · 2019-01-14T11:05:19Z

src/librustc_privacy/lib.rs

@@ -782,6 +782,10 @@ impl<'a, 'tcx> Visitor<'tcx> for NamePrivacyVisitor<'a, 'tcx> {
        NestedVisitorMap::All(&self.tcx.hir())
    }

+    fn visit_mod(&mut self, _m: &'tcx hir::Mod, _s: Span, _n: ast::NodeId) {
+        // Don't visit modules inside


Can explain in the comment why we are not recursing down into nested modules? Something like "Don't visit nested modules, since we run a separate visitor walk for each module in privacy_access_levels()".

michaelwoerister · 2019-01-14T11:05:44Z

src/librustc_privacy/lib.rs

@@ -917,6 +921,10 @@ impl<'a, 'tcx> Visitor<'tcx> for TypePrivacyVisitor<'a, 'tcx> {
        NestedVisitorMap::All(&self.tcx.hir())
    }

+    fn visit_mod(&mut self, _m: &'tcx hir::Mod, _s: Span, _n: ast::NodeId) {
+        // Don't visit modules inside


Here too, just copying the comment is fine.

…mental

Zoxc · 2019-01-15T02:34:56Z

@bors r=michaelwoerister

bors · 2019-01-15T02:34:57Z

📌 Commit 959c870 has been approved by michaelwoerister

@michaelwoerister

Make privacy checking, intrinsic checking and liveness checking incremental Blocked on rust-lang#51487 r? @michaelwoerister

@ghost

Rollup of 7 pull requests Successful merges: - #57253 (Make privacy checking, intrinsic checking and liveness checking incremental) - #57352 (forbid manually impl'ing one of an object type's marker traits) - #57537 (Small perf improvement for fmt) - #57579 (Add core::iter::once_with()) - #57587 (Add 'rustc-env:RUST_BACKTRACE=0' to const-pat-ice test) - #57608 (Simplify 'product' factorial example) - #57614 ([rustdoc] Fix crates filtering box not being filled) Failed merges: r? @ghost

Centril · 2019-01-15T11:46:44Z

@bors r=michaelwoerister

bors · 2019-01-15T11:46:45Z

📌 Commit e301f90 has been approved by michaelwoerister

@michaelwoerister

Make privacy checking, intrinsic checking and liveness checking incremental Blocked on rust-lang#51487 r? @michaelwoerister

@michaelwoerister

Make privacy checking, intrinsic checking and liveness checking incremental Blocked on rust-lang#51487 r? @michaelwoerister

@michaelwoerister

Make privacy checking, intrinsic checking and liveness checking incremental Blocked on rust-lang#51487 r? @michaelwoerister

bors · 2019-01-19T07:42:51Z

⌛ Testing commit e301f90 with merge 1bc6bae...

@michaelwoerister

Make privacy checking, intrinsic checking and liveness checking incremental Blocked on #51487 r? @michaelwoerister

bors · 2019-01-19T10:27:53Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: michaelwoerister
Pushing 1bc6bae to master...

@michaelwoerister

[WIP] Make some lints incremental Blocked on #57253 r? @michaelwoerister

@michaelwoerister

Make some lints incremental Blocked on #57253 r? @michaelwoerister

@michaelwoerister

Make some lints incremental Blocked on #57253 r? @michaelwoerister

@michaelwoerister

Make some lints incremental Blocked on #57253 r? @michaelwoerister

@michaelwoerister

Make some lints incremental Blocked on rust-lang#57253 r? @michaelwoerister

@michaelwoerister

Make some lints incremental Blocked on rust-lang#57253 r? @michaelwoerister

@michaelwoerister

Make some lints incremental Blocked on rust-lang#57253 r? @michaelwoerister

@michaelwoerister

Make some lints incremental Blocked on rust-lang#57253 r? @michaelwoerister

rust-highfive assigned michaelwoerister Jan 2, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 2, 2019

Zoxc force-pushed the incr-passes2 branch from 31241ce to 234715a Compare January 2, 2019 21:22

Zoxc mentioned this pull request Jan 2, 2019

Make some lints incremental #57293

Merged

Zoxc force-pushed the incr-passes2 branch from 234715a to 959c870 Compare January 13, 2019 22:51

Zoxc changed the title ~~[WIP] Make privacy checking, intrinsic checking and liveness checking incremental~~ Make privacy checking, intrinsic checking and liveness checking incremental Jan 14, 2019

michaelwoerister reviewed Jan 14, 2019

View reviewed changes

petrochenkov assigned petrochenkov and unassigned petrochenkov Jan 14, 2019

Zoxc added 2 commits January 15, 2019 00:55

Make privacy checking, intrinsic checking and liveness checking incre…

e459000

…mental

Address comments

e301f90

Zoxc force-pushed the incr-passes2 branch from 959c870 to e301f90 Compare January 14, 2019 23:55

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 15, 2019

Centril mentioned this pull request Jan 15, 2019

Rollup of 8 pull requests #57624

Closed

Centril added a commit to Centril/rust that referenced this pull request Jan 15, 2019

Rollup merge of rust-lang#57253 - Zoxc:incr-passes2, r=michaelwoerister

104e41f

Make privacy checking, intrinsic checking and liveness checking incremental Blocked on rust-lang#51487 r? @michaelwoerister

Centril mentioned this pull request Jan 15, 2019

Rollup of 7 pull requests #57627

Closed

Centril added a commit to Centril/rust that referenced this pull request Jan 17, 2019

Rollup merge of rust-lang#57253 - Zoxc:incr-passes2, r=michaelwoerister

ce882c1

Make privacy checking, intrinsic checking and liveness checking incremental Blocked on rust-lang#51487 r? @michaelwoerister

Centril mentioned this pull request Jan 17, 2019

Rollup of 19 pull requests #57687

Closed

Centril added a commit to Centril/rust that referenced this pull request Jan 17, 2019

Rollup merge of rust-lang#57253 - Zoxc:incr-passes2, r=michaelwoerister

05030e2

Make privacy checking, intrinsic checking and liveness checking incremental Blocked on rust-lang#51487 r? @michaelwoerister

Centril mentioned this pull request Jan 17, 2019

Rollup of 19 pull requests #57688

Closed

Centril added a commit to Centril/rust that referenced this pull request Jan 17, 2019

Rollup merge of rust-lang#57253 - Zoxc:incr-passes2, r=michaelwoerister

51cfa49

Make privacy checking, intrinsic checking and liveness checking incremental Blocked on rust-lang#51487 r? @michaelwoerister

Centril mentioned this pull request Jan 17, 2019

Rollup of 18 pull requests #57690

Closed

bors added a commit that referenced this pull request Jan 19, 2019

Auto merge of #57253 - Zoxc:incr-passes2, r=michaelwoerister

1bc6bae

Make privacy checking, intrinsic checking and liveness checking incremental Blocked on #51487 r? @michaelwoerister

bors merged commit e301f90 into rust-lang:master Jan 19, 2019

Zoxc deleted the incr-passes2 branch January 19, 2019 10:29

bors added a commit that referenced this pull request Jan 19, 2019

Auto merge of #57293 - Zoxc:incr-passes3, r=<try>

bc1de3e

[WIP] Make some lints incremental Blocked on #57253 r? @michaelwoerister

bors added a commit that referenced this pull request Jan 31, 2019

Auto merge of #57293 - Zoxc:incr-passes3, r=<try>

1caecbc

Make some lints incremental Blocked on #57253 r? @michaelwoerister

bors added a commit that referenced this pull request Mar 14, 2019

Auto merge of #57293 - Zoxc:incr-passes3, r=<try>

080e703

Make some lints incremental Blocked on #57253 r? @michaelwoerister

bors added a commit that referenced this pull request Mar 26, 2019

Auto merge of #57293 - Zoxc:incr-passes3, r=<try>

ca674ea

Make some lints incremental Blocked on #57253 r? @michaelwoerister

Centril added a commit to Centril/rust that referenced this pull request Mar 27, 2019

Rollup merge of rust-lang#57293 - Zoxc:incr-passes3, r=michaelwoerister

d7dfa2e

Make some lints incremental Blocked on rust-lang#57253 r? @michaelwoerister

Centril added a commit to Centril/rust that referenced this pull request Mar 27, 2019

Rollup merge of rust-lang#57293 - Zoxc:incr-passes3, r=michaelwoerister

4c76175

Make some lints incremental Blocked on rust-lang#57253 r? @michaelwoerister

Centril added a commit to Centril/rust that referenced this pull request Mar 27, 2019

Rollup merge of rust-lang#57293 - Zoxc:incr-passes3, r=michaelwoerister

6a3b639

Make some lints incremental Blocked on rust-lang#57253 r? @michaelwoerister

cuviper added a commit to cuviper/rust that referenced this pull request Mar 28, 2019

Rollup merge of rust-lang#57293 - Zoxc:incr-passes3, r=michaelwoerister

74a69f2

Make some lints incremental Blocked on rust-lang#57253 r? @michaelwoerister

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make privacy checking, intrinsic checking and liveness checking incremental #57253

Make privacy checking, intrinsic checking and liveness checking incremental #57253

Zoxc commented Jan 2, 2019

Zoxc commented Jan 2, 2019

bors commented Jan 2, 2019

bors commented Jan 2, 2019

Zoxc commented Jan 2, 2019

rust-timer commented Jan 2, 2019

rust-timer commented Jan 2, 2019

bors commented Jan 13, 2019

Zoxc commented Jan 14, 2019

bors commented Jan 14, 2019

Zoxc commented Jan 14, 2019

rust-timer commented Jan 14, 2019

rust-timer commented Jan 14, 2019

michaelwoerister left a comment

michaelwoerister Jan 14, 2019

michaelwoerister Jan 14, 2019

michaelwoerister Jan 14, 2019

Zoxc commented Jan 15, 2019

bors commented Jan 15, 2019

Centril commented Jan 15, 2019

bors commented Jan 15, 2019

bors commented Jan 19, 2019

bors commented Jan 19, 2019


		let krate = tcx.hir().krate();

		for &module in tcx.hir().krate().modules.keys() {

Make privacy checking, intrinsic checking and liveness checking incremental #57253

Make privacy checking, intrinsic checking and liveness checking incremental #57253

Conversation

Zoxc commented Jan 2, 2019

Zoxc commented Jan 2, 2019

bors commented Jan 2, 2019

bors commented Jan 2, 2019

Zoxc commented Jan 2, 2019

rust-timer commented Jan 2, 2019

rust-timer commented Jan 2, 2019

bors commented Jan 13, 2019

Zoxc commented Jan 14, 2019

bors commented Jan 14, 2019

Zoxc commented Jan 14, 2019

rust-timer commented Jan 14, 2019

rust-timer commented Jan 14, 2019

michaelwoerister left a comment

Choose a reason for hiding this comment

michaelwoerister Jan 14, 2019

Choose a reason for hiding this comment

michaelwoerister Jan 14, 2019

Choose a reason for hiding this comment

michaelwoerister Jan 14, 2019

Choose a reason for hiding this comment

Zoxc commented Jan 15, 2019

bors commented Jan 15, 2019

Centril commented Jan 15, 2019

bors commented Jan 15, 2019

bors commented Jan 19, 2019

bors commented Jan 19, 2019