Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default images #57552

Merged
merged 2 commits into from
Jan 22, 2019
Merged

Default images #57552

merged 2 commits into from
Jan 22, 2019

Conversation

GuillaumeGomez
Copy link
Member

Add default rust logo (the image at the top of the sidebar) and default favicon. No more missing image or inexistent icon on the documentation tabs!

r? @QuietMisdreavus

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 12, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:3393d272:start=1547328588020696191,finish=1547328669354442686,duration=81333746495
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:12:47] 
[01:12:47] running 118 tests
[01:13:12] .iiiii...i.....i..i...i..i.i..i.ii..i.....i..i....i..........iiii..........i...ii...i.......ii.i.i.i 100/118
[01:13:17] ......iii.i.....ii
[01:13:17] 
[01:13:17]  finished in 29.641
[01:13:17] travis_fold:end:test_debuginfo

---
[01:41:04] travis_fold:end:stage0-linkchecker

[01:41:04] travis_time:end:stage0-linkchecker:start=1547334740123542332,finish=1547334742173308995,duration=2049766663

[01:41:06] settings.html:1: broken link - favicon.ico
[01:41:12] thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:39:9
[01:41:12] 
[01:41:12] 
[01:41:12] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:41:12] expected success, got: exit code: 101
[01:41:12] expected success, got: exit code: 101
[01:41:12] 
[01:41:12] 
[01:41:12] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:41:12] Build completed unsuccessfully in 0:40:12
[01:41:12] make: *** [check] Error 1
[01:41:12] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:16356450
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sat Jan 12 23:12:30 UTC 2019
---
travis_time:end:03a49628:start=1547334751833000743,finish=1547334751838704482,duration=5703739
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:01778b1a
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:03ad72c0
travis_time:start:03ad72c0
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:03338160
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@QuietMisdreavus
Copy link
Member

[01:41:06] settings.html:1: broken link - favicon.ico
[01:41:12] thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:39:9

Does the settings page not get the right favicon information?

@GuillaumeGomez
Copy link
Member Author

I need to check but I think the problem might come from "upper" pages.

@GuillaumeGomez
Copy link
Member Author

Updated.

@QuietMisdreavus
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 21, 2019

📌 Commit b5d167f has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2019
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 21, 2019
…ietMisdreavus

Default images

Add default rust logo (the image at the top of the sidebar) and default favicon. No more missing image or inexistent icon on the documentation tabs!

r? @QuietMisdreavus
Centril added a commit to Centril/rust that referenced this pull request Jan 21, 2019
…ietMisdreavus

Default images

Add default rust logo (the image at the top of the sidebar) and default favicon. No more missing image or inexistent icon on the documentation tabs!

r? @QuietMisdreavus
Centril added a commit to Centril/rust that referenced this pull request Jan 22, 2019
…ietMisdreavus

Default images

Add default rust logo (the image at the top of the sidebar) and default favicon. No more missing image or inexistent icon on the documentation tabs!

r? @QuietMisdreavus
bors added a commit that referenced this pull request Jan 22, 2019
Rollup of 9 pull requests

Successful merges:

 - #57537 (Small perf improvement for fmt)
 - #57552 (Default images)
 - #57604 (Make `str` indexing generic on `SliceIndex`.)
 - #57667 (Fix memory leak in P::filter_map)
 - #57677 (const_eval: Predetermine the layout of all locals when pushing a stack frame)
 - #57791 (Add regression test for #54582)
 - #57798 (Corrected spelling inconsistency)
 - #57809 (Add powerpc64-unknown-freebsd)
 - #57813 (fix validation range printing when encountering undef)

Failed merges:

r? @ghost
@bors bors merged commit b5d167f into rust-lang:master Jan 22, 2019
@bors
Copy link
Contributor

bors commented Jan 22, 2019

⌛ Testing commit b5d167f with merge ad30e9a...

@GuillaumeGomez GuillaumeGomez deleted the default-images branch January 22, 2019 20:10
@jethrogb
Copy link
Contributor

jethrogb commented Jan 23, 2019

git status always shows me these files as modifed now:

rust/src$ git status
On branch master
Your branch is up-to-date with 'upstream/master'.
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   librustdoc/html/static/favicon.ico
	modified:   librustdoc/html/static/rust-logo.png

no changes added to commit (use "git add" and/or "git commit -a")
rust/src$ rm librustdoc/html/static/favicon.ico librustdoc/html/static/rust-logo.png
rust/src$ git checkout .
rust/src$ git status
On branch master
Your branch is up-to-date with 'upstream/master'.
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   librustdoc/html/static/favicon.ico
	modified:   librustdoc/html/static/rust-logo.png

no changes added to commit (use "git add" and/or "git commit -a")

@jethrogb
Copy link
Contributor

This is #57858

@pietroalbini
Copy link
Member

As a temporary fix you can add the content of #57858 to .git/info/attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants