Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-clickable urls #57710

Merged
merged 1 commit into from
Jan 18, 2019
Merged

Fix non-clickable urls #57710

merged 1 commit into from
Jan 18, 2019

Conversation

GuillaumeGomez
Copy link
Member

Fixes #57695

I didn't find anywhere where this rule was useful. Why did you add it @JohnHeitmann?

r? @QuietMisdreavus

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 17, 2019
@QuietMisdreavus
Copy link
Member

@bors rollup

r=me, but i want to hold off actually putting this into the queue until we hear back from @JohnHeitmann.

@JohnHeitmann
Copy link
Contributor

JohnHeitmann commented Jan 18, 2019 via email •
edited
Loading

@bors
Copy link
Contributor

bors commented Jan 18, 2019

@JohnHeitmann: 🔑 Insufficient privileges: not in try users

@JohnHeitmann
Copy link
Contributor

+1 to your change. Thanks for handling that, and sorry for the breakage!

Here's what happened:

Prior to my changes that selector was setting the z-index to a positive number-- I'm not sure why. When I simplified the markup, for some reason that positive z-index caused the code headers to bleed into the "Important traits..." tooltip like this (I just repro'd this to be sure):

screen shot 2019-01-17 at 9 45 24 pm

I don't know why I set it to a negative value instead of deleting it. I'd guess it was just a quick 'n dirty fix I forgot to revisit before submission. I just tested your change in a few scenarios and don't see any problems with it.

For the future: another easy to miss z problem happens in the mobile overlay menus. I tested to be sure and your patch doesn't re-break those either.

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 18, 2019
Closed
@GuillaumeGomez
Copy link
Member Author

Ok, so now I know where the issue is. :)

@GuillaumeGomez
Copy link
Member Author

@bors: r=QuietMisdreavus

@bors
Copy link
Contributor

bors commented Jan 18, 2019

📌 Commit 2518987 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2019
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 18, 2019
@GuillaumeGomez
Rollup merge of rust-lang#57710 - GuillaumeGomez:non-clickable, r=Qui…
6647f21 
…etMisdreavus

Fix non-clickable urls

Fixes rust-lang#57695

I didn't find anywhere where this rule was useful. Why did you add it @JohnHeitmann?

r? @QuietMisdreavus
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 18, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jan 18, 2019
@Centril
Rollup merge of rust-lang#57710 - GuillaumeGomez:non-clickable, r=Qui…
ff583ac 
…etMisdreavus

Fix non-clickable urls

Fixes rust-lang#57695

I didn't find anywhere where this rule was useful. Why did you add it @JohnHeitmann?

r? @QuietMisdreavus
@Centril Centril mentioned this pull request Jan 18, 2019
Merged
bors added a commit that referenced this pull request Jan 18, 2019
@bors
Auto merge of #57737 - Centril:rollup, r=Centril
c76f3c3 
Rollup of 10 pull requests

Successful merges:

 - #56594 (Remove confusing comment about ideally using `!` for `c_void`)
 - #57340 (Use correct tracking issue for c_variadic)
 - #57357 (Cleanup PartialEq docs.)
 - #57551 (resolve: Add a test for issue #57539)
 - #57636 (Fix sources sidebar not showing up)
 - #57646 (Fixes text becoming invisible when element targetted)
 - #57654 (Add some links in std::fs.)
 - #57683 (Document Unpin in std::prelude documentation)
 - #57685 (Enhance `Pin` impl applicability for `PartialEq` and `PartialOrd`.)
 - #57710 (Fix non-clickable urls)

Failed merges:

r? @ghost
@bors bors merged commit 2518987 into rust-lang:master Jan 18, 2019
@GuillaumeGomez GuillaumeGomez deleted the non-clickable branch January 19, 2019 11:46
@tspiteri
Copy link
Contributor

@GuillaumeGomez @QuietMisdreavus Should this be backported to beta? Currently the beta docs have non-clickable method names. (I guess the highlighting will be fixed when #57859 is eventually backported.)

@QuietMisdreavus QuietMisdreavus added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Feb 21, 2019
@QuietMisdreavus
Copy link
Member

Oof, i didn't realize this issue was on beta. Nominating (and immediately accepting) backport.

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Feb 22, 2019
Merged
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 22, 2019
bors added a commit that referenced this pull request Feb 23, 2019
@bors
Auto merge of #58656 - Mark-Simulacrum:beta-rollups, r=pietroalbini
bb2d0ea 
Beta rollups

 - #58649
 - #58592
 - #58574
 - #58227
 - #58056
 - #57859
 - #57710

A few of these are via #58641.

r? @pietroalbini
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@GuillaumeGomez @QuietMisdreavus @JohnHeitmann @bors @tspiteri @pietroalbini @rust-highfive