extra testing of how NLL handles wildcard type `_` #57729

pnkfelix · 2019-01-18T11:25:46Z

test that wildcard type _ is not duplicated by type Foo<X> = (X, X); and potentially instantiated at different types when used in type ascriptions in let bindings.

(NLL's handling of this for the type ascription expression form is currently broken, or at least differs from what AST-borrowck does. I'll file a separate bug about that. Its not something critical to address since that expression is guarded by #![feature(type_ascription)].)

cc #55748

rust-highfive · 2019-01-18T11:25:56Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

nikomatsakis · 2019-01-25T21:38:44Z

@bors r+ rollup

bors · 2019-01-25T21:38:45Z

📌 Commit b3690c6 has been approved by nikomatsakis

…constraints-on-bindings-too, r=nikomatsakis extra testing of how NLL handles wildcard type `_` test that wildcard type `_` is not duplicated by `type Foo<X> = (X, X);` and potentially instantiated at different types when used in type ascriptions in let bindings. (NLL's handling of this for the type ascription *expression form* is currently broken, or at least differs from what AST-borrowck does. I'll file a separate bug about that. Its not something critical to address since that expression is guarded by `#![feature(type_ascription)]`.) cc rust-lang#55748

Centril · 2019-01-26T17:18:24Z

Failed in rollup, #57912 (comment).

@bors r-

Dylan-DPC-zz · 2019-02-25T09:31:52Z

ping from triage @pnkfelix you need to resolve #57912 (comment)

pnkfelix · 2019-03-11T11:16:09Z

will investigate

rust-highfive · 2019-03-11T12:30:27Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:06f52cff:start=1552303047776962028,finish=1552303118820251189,duration=71043289161
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
[01:10:18] .................................................................................................... 3400/5449
[01:10:21] ................................................ii...i..ii.......................................... 3500/5449
[01:10:25] .................................................................................................... 3600/5449
[01:10:29] .................................................................................................... 3700/5449
[01:10:32] ......F....................................................ii....................................... 3800/5449
[01:10:36] .................................................................................................... 4000/5449
[01:10:38] ...................................i................................................................ 4100/5449
[01:10:41] .................................................................................................... 4200/5449
[01:10:52] .................................................................................................... 4300/5449
---
[01:11:33] 
[01:11:33] ---- [ui] ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs stdout ----
[01:11:33] diff of stderr:
[01:11:33] 
[01:11:33] - error: unsatisfied lifetime constraints
[01:11:33] + error: lifetime may not live long enough
[01:11:33] 2   --> $DIR/issue-55748-pat-types-constrain-bindings.rs:35:5
[01:11:33] 3    |
[01:11:33] 4 LL | fn coupled_regions_lhs<'a>(_x: &'a u32, s: &'static u32) -> &'static u32 {
[01:11:33] 
[01:11:33] 7 LL |     y //~ ERROR unsatisfied lifetime constraints
[01:11:33] 8    |     ^ returning this value requires that `'a` must outlive `'static`
[01:11:33] - error: unsatisfied lifetime constraints
[01:11:33] - error: unsatisfied lifetime constraints
[01:11:33] + error: lifetime may not live long enough
[01:11:33] 11   --> $DIR/issue-55748-pat-types-constrain-bindings.rs:49:5
[01:11:33] 12    |
[01:11:33] 13 LL | fn coupled_types_lhs<'a>(_x: &'a u32, s: &'static u32) -> &'static u32 {
[01:11:33] 
[01:11:33] 16 LL |     y //~ ERROR unsatisfied lifetime constraints
[01:11:33] 17    |     ^ returning this value requires that `'a` must outlive `'static`
[01:11:33] - error: unsatisfied lifetime constraints
[01:11:33] - error: unsatisfied lifetime constraints
[01:11:33] + error: lifetime may not live long enough
[01:11:33] 20   --> $DIR/issue-55748-pat-types-constrain-bindings.rs:62:5
[01:11:33] 21    |
[01:11:33] 22 LL | fn coupled_wilds_lhs<'a>(_x: &'a u32, s: &'static u32) -> &'static u32 {
[01:11:33] 
[01:11:33] The actual stderr differed from the expected stderr.
[01:11:33] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings/issue-55748-pat-types-constrain-bindings.stderr
[01:11:33] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings/issue-55748-pat-types-constrain-bindings.stderr
[01:11:33] To update references, rerun the tests and pass the `--bless` flag
[01:11:33] To only update this specific test, also pass `--test-args nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs`
[01:11:33] error: 1 errors occurred comparing output.
[01:11:33] status: exit code: 1
[01:11:33] status: exit code: 1
[01:11:33] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings/auxiliary" "-A" "unused"
[01:11:33] ------------------------------------------
[01:11:33] 
[01:11:33] ------------------------------------------
[01:11:33] stderr:
[01:11:33] stderr:
[01:11:33] ------------------------------------------
[01:11:33] {"message":"lifetime may not live long enough","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs","byte_start":903,"byte_end":905,"line_start":28,"line_end":28,"column_start":24,"column_end":26,"is_primary":false,"text":[{"text":"fn coupled_regions_lhs<'a>(_x: &'a u32, s: &'static u32) -> &'static u32 {","highlight_start":24,"highlight_end":26}],"label":"lifetime `'a` defined here","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs","byte_start":1175,"byte_end":1176,"line_start":35,"line_end":35,"column_start":5,"column_end":6,"is_primary":true,"text":[{"text":"    y //~ ERROR unsatisfied lifetime constraints","highlight_start":5,"highlight_end":6}],"label":"returning this value requires that `'a` must outlive `'static`","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: lifetime may not live long enough\n  --> /checkout/src/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs:35:5\n   |\nLL | fn coupled_regions_lhs<'a>(_x: &'a u32, s: &'static u32) -> &'static u32 {\n   |                        -- lifetime `'a` defined here\n...\nLL |     y //~ ERROR unsatisfied lifetime constraints\n   |     ^ returning this value requires that `'a` must outlive `'static`\n\n"}
[01:11:33] {"message":"lifetime may not live long enough","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs","byte_start":1343,"byte_end":1345,"line_start":42,"line_end":42,"column_start":22,"column_end":24,"is_primary":false,"text":[{"text":"fn coupled_types_lhs<'a>(_x: &'a u32, s: &'static u32) -> &'static u32 {","highlight_start":22,"highlight_end":24}],"label":"lifetime `'a` defined here","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs","byte_start":1612,"byte_end":1613,"line_start":49,"line_end":49,"column_start":5,"column_end":6,"is_primary":true,"text":[{"text":"    y //~ ERROR unsatisfied lifetime constraints","highlight_start":5,"highlight_end":6}],"label":"returning this value requires that `'a` must outlive `'static`","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: lifetime may not live long enough\n  --> /checkout/src/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs:49:5\n   |\nLL | fn coupled_types_lhs<'a>(_x: &'a u32, s: &'static u32) -> &'static u32 {\n   |                      -- lifetime `'a` defined here\n...\nLL |     y //~ ERROR unsatisfied lifetime constraints\n   |     ^ returning this value requires that `'a` must outlive `'static`\n\n"}
[01:11:33] {"message":"lifetime may not live long enough","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs","byte_start":1780,"byte_end":1782,"line_start":56,"line_end":56,"column_start":22,"column_end":24,"is_primary":false,"text":[{"text":"fn coupled_wilds_lhs<'a>(_x: &'a u32, s: &'static u32) -> &'static u32 {","highlight_start":22,"highlight_end":24}],"label":"lifetime `'a` defined here","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs","byte_start":2041,"byte_end":2042,"line_start":62,"line_end":62,"column_start":5,"column_end":6,"is_primary":true,"text":[{"text":"    y //~ ERROR unsatisfied lifetime constraints","highlight_start":5,"highlight_end":6}],"label":"returning this value requires that `'a` must outlive `'static`","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: lifetime may not live long enough\n  --> /checkout/src/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs:62:5\n   |\nLL | fn coupled_wilds_lhs<'a>(_x: &'a u32, s: &'static u32) -> &'static u32 {\n   |                      -- lifetime `'a` defined here\n...\nLL |     y //~ ERROR unsatisfied lifetime constraints\n   |     ^ returning this value requires that `'a` must outlive `'static`\n\n"}
[01:11:33] 
[01:11:33] ------------------------------------------
[01:11:33] 
[01:11:33] thread '[ui] ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
---
[01:11:33] 
[01:11:33] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:11:33] 
[01:11:33] 
[01:11:33] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:11:33] 
[01:11:33] 
[01:11:33] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:11:33] Build completed unsuccessfully in 0:04:12
[01:11:33] Build completed unsuccessfully in 0:04:12
[01:11:33] Makefile:48: recipe for target 'check' failed
[01:11:33] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0b9c9220
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Mon Mar 11 12:30:21 UTC 2019
---
travis_time:end:03039b2b:start=1552307422674730006,finish=1552307422679299880,duration=4569874
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1f2c9f33
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:2ef040d2
travis_time:start:2ef040d2
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:24c586cb
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

pnkfelix · 2019-03-13T10:42:35Z

@bors r=nikomatsakis rollup

bors · 2019-03-13T10:42:38Z

📌 Commit 0c04937d64b3277f8d709715723b56236eb8e376 has been approved by nikomatsakis

rust-highfive · 2019-03-13T11:34:19Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0af23df9:start=1552472370872613646,finish=1552472371789196158,duration=916582512
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
[01:13:10] .................................................................................................... 3400/5468
[01:13:14] .................................................................ii...i..ii......................... 3500/5468
[01:13:18] .................................................................................................... 3600/5468
[01:13:22] .................................................................................................... 3700/5468
[01:13:25] .......................F....................................................ii...................... 3800/5468
[01:13:30] .................................................................................................... 4000/5468
[01:13:32] ....................................................i............................................... 4100/5468
[01:13:35] .................................................................................................... 4200/5468
[01:13:44] .................................................................................................... 4300/5468
---
[01:14:29] 
[01:14:29] ---- [ui] ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs stdout ----
[01:14:29] diff of stderr:
[01:14:29] 
[01:14:29] 4 LL | fn coupled_regions_lhs<'a>(_x: &'a u32, s: &'static u32) -> &'static u32 {
[01:14:29] 5    |                        -- lifetime `'a` defined here
[01:14:29] 6 ...
[01:14:29] - LL |     y //~ ERROR unsatisfied lifetime constraints
[01:14:29] + LL |     y
[01:14:29] 8    |     ^ returning this value requires that `'a` must outlive `'static`
[01:14:29] 10 error: lifetime may not live long enough
[01:14:29] 
[01:14:29] 
[01:14:29] 13 LL | fn coupled_types_lhs<'a>(_x: &'a u32, s: &'static u32) -> &'static u32 {
[01:14:29] 14    |                      -- lifetime `'a` defined here
[01:14:29] 15 ...
[01:14:29] - LL |     y //~ ERROR unsatisfied lifetime constraints
[01:14:29] + LL |     y
[01:14:29] 17    |     ^ returning this value requires that `'a` must outlive `'static`
[01:14:29] 19 error: lifetime may not live long enough
[01:14:29] 
[01:14:29] 
[01:14:29] 22 LL | fn coupled_wilds_lhs<'a>(_x: &'a u32, s: &'static u32) -> &'static u32 {
[01:14:29] 23    |                      -- lifetime `'a` defined here
[01:14:29] 24 ...
[01:14:29] - LL |     y //~ ERROR unsatisfied lifetime constraints
[01:14:29] + LL |     y
[01:14:29] 26    |     ^ returning this value requires that `'a` must outlive `'static`
[01:14:29] 28 error: aborting due to 3 previous errors
[01:14:29] 
[01:14:29] 
[01:14:29] The actual stderr differed from the expected stderr.
[01:14:29] The actual stderr differed from the expected stderr.
[01:14:29] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings/issue-55748-pat-types-constrain-bindings.stderr
[01:14:29] To update references, rerun the tests and pass the `--bless` flag
[01:14:29] To only update this specific test, also pass `--test-args nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs`
[01:14:29] error: 1 errors occurred comparing output.
[01:14:29] status: exit code: 1
[01:14:29] status: exit code: 1
[01:14:29] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings/auxiliary" "-A" "unused"
[01:14:29] ------------------------------------------
[01:14:29] 
[01:14:29] ------------------------------------------
[01:14:29] stderr:
[01:14:29] stderr:
[01:14:29] ------------------------------------------
[01:14:29] {"message":"lifetime may not live long enough","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs","byte_start":903,"byte_end":905,"line_start":28,"line_end":28,"column_start":24,"column_end":26,"is_primary":false,"text":[{"text":"fn coupled_regions_lhs<'a>(_x: &'a u32, s: &'static u32) -> &'static u32 {","highlight_start":24,"highlight_end":26}],"label":"lifetime `'a` defined here","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs","byte_start":1175,"byte_end":1176,"line_start":35,"line_end":35,"column_start":5,"column_end":6,"is_primary":true,"text":[{"text":"    y //~ ERROR unsatisfied lifetime constraints","highlight_start":5,"highlight_end":6}],"label":"returning this value requires that `'a` must outlive `'static`","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: lifetime may not live long enough\n  --> /checkout/src/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs:35:5\n   |\nLL | fn coupled_regions_lhs<'a>(_x: &'a u32, s: &'static u32) -> &'static u32 {\n   |                        -- lifetime `'a` defined here\n...\nLL |     y //~ ERROR unsatisfied lifetime constraints\n   |     ^ returning this value requires that `'a` must outlive `'static`\n\n"}
[01:14:29] {"message":"lifetime may not live long enough","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs","byte_start":1343,"byte_end":1345,"line_start":42,"line_end":42,"column_start":22,"column_end":24,"is_primary":false,"text":[{"text":"fn coupled_types_lhs<'a>(_x: &'a u32, s: &'static u32) -> &'static u32 {","highlight_start":22,"highlight_end":24}],"label":"lifetime `'a` defined here","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs","byte_start":1612,"byte_end":1613,"line_start":49,"line_end":49,"column_start":5,"column_end":6,"is_primary":true,"text":[{"text":"    y //~ ERROR unsatisfied lifetime constraints","highlight_start":5,"highlight_end":6}],"label":"returning this value requires that `'a` must outlive `'static`","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: lifetime may not live long enough\n  --> /checkout/src/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs:49:5\n   |\nLL | fn coupled_types_lhs<'a>(_x: &'a u32, s: &'static u32) -> &'static u32 {\n   |                      -- lifetime `'a` defined here\n...\nLL |     y //~ ERROR unsatisfied lifetime constraints\n   |     ^ returning this value requires that `'a` must outlive `'static`\n\n"}
[01:14:29] {"message":"lifetime may not live long enough","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs","byte_start":1780,"byte_end":1782,"line_start":56,"line_end":56,"column_start":22,"column_end":24,"is_primary":false,"text":[{"text":"fn coupled_wilds_lhs<'a>(_x: &'a u32, s: &'static u32) -> &'static u32 {","highlight_start":22,"highlight_end":24}],"label":"lifetime `'a` defined here","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs","byte_start":2041,"byte_end":2042,"line_start":62,"line_end":62,"column_start":5,"column_end":6,"is_primary":true,"text":[{"text":"    y //~ ERROR unsatisfied lifetime constraints","highlight_start":5,"highlight_end":6}],"label":"returning this value requires that `'a` must outlive `'static`","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: lifetime may not live long enough\n  --> /checkout/src/test/ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs:62:5\n   |\nLL | fn coupled_wilds_lhs<'a>(_x: &'a u32, s: &'static u32) -> &'static u32 {\n   |                      -- lifetime `'a` defined here\n...\nLL |     y //~ ERROR unsatisfied lifetime constraints\n   |     ^ returning this value requires that `'a` must outlive `'static`\n\n"}
[01:14:29] 
[01:14:29] ------------------------------------------
[01:14:29] 
[01:14:29] thread '[ui] ui/nll/user-annotations/issue-55748-pat-types-constrain-bindings.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3325:9
---
[01:14:29] 
[01:14:29] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:14:29] 
[01:14:29] 
[01:14:29] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:14:29] 
[01:14:29] 
[01:14:29] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:14:29] Build completed unsuccessfully in 0:04:21
[01:14:29] Build completed unsuccessfully in 0:04:21
[01:14:29] make: *** [check] Error 1
[01:14:29] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:105e4114
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Wed Mar 13 11:34:12 UTC 2019
---
travis_time:end:006e1b40:start=1552476853851533607,finish=1552476853856763896,duration=5230289
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:01ad86f0
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:266819f4
travis_time:start:266819f4
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:05832280
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2019-03-13T14:39:22Z

@bors r-

The UI test output is changed thanks to #59044.

…);` and potentially instantiated at different types. (Updated to reflect changes in diagnostic output and compiletest infrastructure.)

pnkfelix · 2019-03-14T07:13:56Z

@bors r=nikomatsakis rollup

bors · 2019-03-14T07:13:57Z

📌 Commit 4e5692d has been approved by nikomatsakis

…constraints-on-bindings-too, r=nikomatsakis extra testing of how NLL handles wildcard type `_` test that wildcard type `_` is not duplicated by `type Foo<X> = (X, X);` and potentially instantiated at different types when used in type ascriptions in let bindings. (NLL's handling of this for the type ascription *expression form* is currently broken, or at least differs from what AST-borrowck does. I'll file a separate bug about that. Its not something critical to address since that expression is guarded by `#![feature(type_ascription)]`.) cc rust-lang#55748

@ghost

Rollup of 11 pull requests Successful merges: - #56348 (Add todo!() macro) - #57729 (extra testing of how NLL handles wildcard type `_`) - #57847 (dbg!() without parameters) - #58778 (Implement ExactSizeIterator for ToLowercase and ToUppercase) - #58812 (Clarify distinction between floor() and trunc()) - #58939 (Fix a tiny error in documentation of std::pin.) - #59116 (Be more discerning on when to attempt suggesting a comma in a macro invocation) - #59252 (add self to mailmap) - #59275 (Replaced self-reflective explicit types with clearer `Self` or `Self::…` in stdlib docs) - #59280 (Stabilize refcell_map_split feature) - #59290 (Run branch cleanup after copy prop) Failed merges: r? @ghost

rust-highfive assigned nikomatsakis Jan 18, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 18, 2019

pnkfelix mentioned this pull request Jan 18, 2019

NLL: investigate ascription when a _ wildcard tyvar is repeated #55748

Closed

nikomatsakis approved these changes Jan 25, 2019

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2019

Centril mentioned this pull request Jan 26, 2019

Rollup of 10 pull requests #57911

Closed

Centril mentioned this pull request Jan 26, 2019

Rollup of 9 pull requests #57912

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 26, 2019

pnkfelix closed this Mar 11, 2019

pnkfelix reopened this Mar 11, 2019

pnkfelix changed the title ~~extra testing of how NLL handles wildcard type _~~ [WIP] extra testing of how NLL handles wildcard type _ Mar 11, 2019

pnkfelix force-pushed the issue-55748-pat-types-are-constraints-on-bindings-too branch from b3690c6 to 0c04937 Compare March 13, 2019 10:18

pnkfelix changed the title ~~[WIP] extra testing of how NLL handles wildcard type _~~ extra testing of how NLL handles wildcard type _ Mar 13, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 13, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 13, 2019

test that wildcard type _ is not duplicated by `type Foo<X> = (X, X…

4e5692d

…);` and potentially instantiated at different types. (Updated to reflect changes in diagnostic output and compiletest infrastructure.)

pnkfelix force-pushed the issue-55748-pat-types-are-constraints-on-bindings-too branch from 0c04937 to 4e5692d Compare March 13, 2019 20:59

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 14, 2019

Mark-Simulacrum mentioned this pull request Mar 14, 2019

Rollup of 16 pull requests #59183

Closed

Centril mentioned this pull request Mar 16, 2019

Rollup of 18 pull requests #59223

Closed

Centril mentioned this pull request Mar 16, 2019

Rollup of 9 pull requests #59244

Closed

sanxiyn mentioned this pull request Mar 18, 2019

Rollup of 8 pull requests #59271

Closed

Centril mentioned this pull request Mar 19, 2019

Rollup of 12 pull requests #59289

Closed

Centril mentioned this pull request Mar 19, 2019

Rollup of 11 pull requests #59293

Merged

bors merged commit 4e5692d into rust-lang:master Mar 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

extra testing of how NLL handles wildcard type `_` #57729

extra testing of how NLL handles wildcard type `_` #57729

pnkfelix commented Jan 18, 2019 •

edited

Loading

rust-highfive commented Jan 18, 2019

nikomatsakis commented Jan 25, 2019

bors commented Jan 25, 2019

Centril commented Jan 26, 2019

Dylan-DPC-zz commented Feb 25, 2019

pnkfelix commented Mar 11, 2019

rust-highfive commented Mar 11, 2019

pnkfelix commented Mar 13, 2019

bors commented Mar 13, 2019

rust-highfive commented Mar 13, 2019

kennytm commented Mar 13, 2019

pnkfelix commented Mar 14, 2019

bors commented Mar 14, 2019

extra testing of how NLL handles wildcard type _ #57729

extra testing of how NLL handles wildcard type _ #57729

Conversation

pnkfelix commented Jan 18, 2019 • edited Loading

rust-highfive commented Jan 18, 2019

nikomatsakis commented Jan 25, 2019

bors commented Jan 25, 2019

Centril commented Jan 26, 2019

Dylan-DPC-zz commented Feb 25, 2019

pnkfelix commented Mar 11, 2019

rust-highfive commented Mar 11, 2019

pnkfelix commented Mar 13, 2019

bors commented Mar 13, 2019

rust-highfive commented Mar 13, 2019

kennytm commented Mar 13, 2019

pnkfelix commented Mar 14, 2019

bors commented Mar 14, 2019

extra testing of how NLL handles wildcard type `_` #57729

extra testing of how NLL handles wildcard type `_` #57729

pnkfelix commented Jan 18, 2019 •

edited

Loading