Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] rustbuild: fix build with rust 1.33 #57990

Merged
merged 1 commit into from
Jan 31, 2019
Merged

[beta] rustbuild: fix build with rust 1.33 #57990

merged 1 commit into from
Jan 31, 2019

Conversation

Keruspe
Copy link
Contributor

@Keruspe Keruspe commented Jan 30, 2019

Fixes #57262

@Keruspe
rustbuild: fix build with rust 1.33
2cccf59 
Fixes rust-lang#57262

Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 30, 2019
@Centril Centril added I-nominated T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Jan 30, 2019
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jan 30, 2019

📌 Commit 2cccf59 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 30, 2019
@Mark-Simulacrum Mark-Simulacrum removed I-nominated T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Jan 30, 2019
@bors
Copy link
Contributor

bors commented Jan 31, 2019

⌛ Testing commit 2cccf59 with merge 1045131...

bors added a commit that referenced this pull request Jan 31, 2019
@bors
Auto merge of #57990 - Keruspe:beta, r=alexcrichton
1045131 
[beta] rustbuild: fix build with rust 1.33

Fixes #57262
@bors
Copy link
Contributor

bors commented Jan 31, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing 1045131 to beta...

@bors bors merged commit 2cccf59 into rust-lang:beta Jan 31, 2019
@cuviper cuviper mentioned this pull request Mar 1, 2019
Closed
@jnbr jnbr mentioned this pull request Mar 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Keruspe @rust-highfive @alexcrichton @bors @Centril @Mark-Simulacrum