Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more profiler events #58309

Merged
merged 3 commits into from
Feb 14, 2019
Merged

Conversation

wesleywiser
Copy link
Member

@wesleywiser wesleywiser commented Feb 8, 2019

  • Adds Start\Stop events for time spent loading incremental query results from disk.

  • Adds Start\Stop events for time spent blocked waiting for queries to complete (when parallel queries are enabled).

r? @michaelwoerister

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 8, 2019
src/librustc/util/profiling.rs Outdated Show resolved Hide resolved
src/librustc/util/profiling.rs Outdated Show resolved Hide resolved
src/librustc/util/profiling.rs Outdated Show resolved Hide resolved
@wesleywiser wesleywiser force-pushed the add_more_profiler_events branch from 3f16a63 to 7690f4a Compare February 10, 2019 19:23
@wesleywiser
Copy link
Member Author

@ljedrz Fixed, thanks!

This captures time spent blocked when a query is waiting for another
query to finish executing in another thread.
@wesleywiser wesleywiser force-pushed the add_more_profiler_events branch from 7690f4a to e9ebc2e Compare February 11, 2019 23:02
@michaelwoerister
Copy link
Member

Thanks, @wesleywiser!
@bors r+

@bors
Copy link
Contributor

bors commented Feb 12, 2019

📌 Commit e9ebc2e has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2019
Centril added a commit to Centril/rust that referenced this pull request Feb 14, 2019
…s, r=michaelwoerister

Add more profiler events

- Adds Start\Stop events for time spent loading incremental query results from disk.

- Adds Start\Stop events for time spent blocked waiting for queries to complete (when parallel queries are enabled).

r? @michaelwoerister
bors added a commit that referenced this pull request Feb 14, 2019
Rollup of 7 pull requests

Successful merges:

 - #58309 (Add more profiler events)
 - #58347 (Closure bounds fixes)
 - #58365 (Add an option to print the status of incremental tasks / dep nodes after running them)
 - #58371 (Check user type annotations for range patterns.)
 - #58378 (rustc: Implement incremental "fat" LTO)
 - #58407 (specify "upper camel case" in style lint)
 - #58449 (Notify @topecongiro when the state of rustfmt has changed)

Failed merges:

r? @ghost
@bors bors merged commit e9ebc2e into rust-lang:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants