update stdsimd and remove now-unused MaybeUninit::into_inner

[RalfJung]

That's a huge diff for stdsimd... Cc @gnzlbg @alexcrichton

[rust-highfive]

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

[rust-highfive]

⚠️ Warning ⚠️

• These commits modify submodules.

[RalfJung]

Hm, this fails to build:

error: couldn't read src/libcore/core_arch_docs.md: No such file or directory (os error 2)                                                                                                                       
 --> src/libcore/../stdsimd/crates/core_arch/src/mod.rs:8:17
  |
8 | #[doc(include = "core_arch_docs.md")]
  |                 ^^^^^^^^^^^^^^^^^^^ couldn't read file
  |
  = help: external doc paths are relative to the crate root

[gnzlbg]

cc @QuietMisdreavus it appears that #[doc(include = "core_arch_docs.md")] does not respect #[path].

@RalfJung can you test if creating a symlink from libcore/core_arch_docs.md to stdsimd/crates/core_arch/src/core_arch_docs.md solves this issue?

Also, libstd probably needs to be compiled with --cfg feature="std_detect_file_io" --cfg feature="std_detect_dlsym_getauxval", so those two should probably be added here: https://github.com/rust-lang/rust/blob/master/src/libstd/Cargo.toml#L50

[RalfJung]

can you test if creating a symlink from libcore/core_arch_docs.md to stdsimd/crates/core_arch/src/core_arch_docs.md solves this issue?

That seems to help. But don't ask me what it'll do on Windows...

libstd probably needs to be compiled with --cfg feature="std_detect_file_io" --cfg feature="std_detect_dlsym_getauxval", so those two should probably be added

Like this? However, they should probably be documented. If you tell me which text to put there I'll do it. :P

[gnzlbg]

Like this? However, they should probably be documented. If you tell me which text to put there I'll do it. :P

Yes that's exactly what I meant!

I think a comment stating:

# Enable std_detect default features:
# https://github.com/rust-lang-nursery/stdsimd/blob/master/crates/std_detect/Cargo.toml

would be enough.

That seems to help. But don't ask me what it'll do on Windows...

I don't think that will work... Maybe this PR to stdsimd fixes this here: rust-lang/stdarch#680

[RalfJung]

Well let us see.

[bors]

☔ The latest upstream changes (presumably #58341) made this pull request unmergeable. Please resolve the merge conflicts.

[RalfJung]

Seems like travis is happy?

I resolved the conflicts.

[gnzlbg]

r? @gnzlbg LGTM.

@bors: r+

[RalfJung]

Seems like bors didn't see this, maybe because of the ":"?

@bors r=gnzlbg

[bors]

📌 Commit 9d47226ae7be90d2501f13ff12093d6fbd80d4bf has been approved by gnzlbg

[Centril]

In-between-rollup-filler, @bors p=1

[bors]

⌛ Testing commit 9d47226ae7be90d2501f13ff12093d6fbd80d4bf with merge 92e9f3fac3a2bf6ba4ecb146ecbd163639fd94e3...

[RalfJung]

Seems like I somehow lost the part where into_inner gets removed.^^ But that's okay, that part is easy to submit later (and can be rollup'd).

[bors]

💔 Test failed - status-appveyor

[RalfJung]

Log ends in

C:\projects\rust\build\tmp\dist\rust.wxs(144) : warning LGHT1076 : ICE61: This product should remove only older versions of itself. The Maximum version is not less than the current product. (1.34.65535 1.34.0.0)
[TIMING] Extended { stage: 2, host: "i686-pc-windows-gnu", target: "i686-pc-windows-gnu" } -- 1101.683
Build completed successfully in 3:19:57
Command exited with code 259
set PATH=%PATH%;"C:\Program Files (x86)\Windows Kits\10\Debuggers\X64"
if exist %LOCALAPPDATA%\CrashDumps for %%f in (%LOCALAPPDATA%\CrashDumps\*) do cdb -c "k;q" -G -z "%%f"

Is that just a timeout?

[bors]

💔 Test failed - checks-travis

[hellow554]

@RalfJung yes, thanks. Sorry that it causes additional headache. 😟

[gnzlbg]

@RalfJung the problem is that a change in rustc to allow_internal_unstable required a change to stdsimd, which was applied, and appeared to work there, but the update of rust to that version hasnt been done yet, and it apparently fails: I've sent rust-lang/stdarch#687 . This might fix the error, but I'm not sure, am travelling, and can't really test it properly.

[RalfJung]

All right, I updated the submodule to include that commit.

[RalfJung]

@bors r=gnzlbg

[bors]

📌 Commit aba0d29 has been approved by gnzlbg

[Mark-Simulacrum]

@bors p=10

[bors]

⌛ Testing commit aba0d29 with merge d215d95...

[bors]

☀️ Test successful - checks-travis, status-appveyor
Approved by: gnzlbg
Pushing d215d95 to master...

[rust-highfive]

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_fold:end:services

travis_fold:start:git.checkout
travis_time:start:1383b75c
$ git clone --depth=2 --branch=master https://github.com/rust-lang/rust.git rust-lang/rust
---
  fi
travis_time:end:107a5e32:start=1550468230195332216,finish=1550468230206722480,duration=11390264
travis_fold:end:before_script.3
travis_time:start:04d96fa6
$ MESSAGE_FILE=$(mktemp -t msg.XXXXXX); . src/ci/docker/x86_64-gnu-tools/repo.sh; commit_toolstate_change "$MESSAGE_FILE" "$TRAVIS_BUILD_DIR/src/tools/publish_toolstate.py" "$(git rev-parse HEAD)" "$(git log --format=%s -n1 HEAD)" "$MESSAGE_FILE" "$TOOLSTATE_REPO_ACCESS_TOKEN";
Cloning into 'rust-toolstate'...
I/O error: HTTP Error 422: Unprocessable Entity
📣 Toolstate changed by <unknown PR>!
Tested on commit rust-lang/rust@d215d9591f27d0663445e65615090621153c31df.
Direct link to PR: <<unknown>>
💔 miri on windows: test-fail → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
💔 miri on linux: test-fail → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
Traceback (most recent call last):
  File "/home/travis/build/rust-lang/rust/src/tools/publish_toolstate.py", line 219, in <module>
    'Content-Type': 'application/json',
  File "/usr/lib/python2.7/urllib2.py", line 154, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 435, in open
    response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 548, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 473, in error

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[RalfJung]

Uh, what?

$ MESSAGE_FILE=$(mktemp -t msg.XXXXXX); . src/ci/docker/x86_64-gnu-tools/repo.sh; commit_toolstate_change "$MESSAGE_FILE" "$TRAVIS_BUILD_DIR/src/tools/publish_toolstate.py" "$(git rev-parse HEAD)" "$(git log --format=%s -n1 HEAD)" "$MESSAGE_FILE" "$TOOLSTATE_REPO_ACCESS_TOKEN";
Cloning into 'rust-toolstate'...
I/O error: HTTP Error 422: Unprocessable Entity
📣 Toolstate changed by <unknown PR>!
Tested on commit rust-lang/rust@d215d9591f27d0663445e65615090621153c31df.
Direct link to PR: <<unknown>>
💔 miri on windows: test-fail → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
💔 miri on linux: test-fail → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
Traceback (most recent call last):
  File "/home/travis/build/rust-lang/rust/src/tools/publish_toolstate.py", line 219, in <module>
    'Content-Type': 'application/json',
  File "/usr/lib/python2.7/urllib2.py", line 154, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 435, in open
    response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 548, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 473, in error

@rust-lang/infra @oli-obk

[oli-obk]

fix is in #58541 (comment)