Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #58446

Merged
merged 34 commits into from
Feb 14, 2019
Merged

Rollup of 8 pull requests #58446

merged 34 commits into from
Feb 14, 2019

Commits on Feb 3, 2019

  1. Update the future/task API

    This change updates the future and task API as discussed in the stabilization RFC at rust-lang/rfcs#2592.
    
    Changes:
    - Replacing UnsafeWake with RawWaker and RawWakerVtable
    - Removal of LocalWaker
    - Removal of Arc-based Wake trait
    Matthias247 committed Feb 3, 2019
    Configuration menu
    Copy the full SHA
    d9a4b22 View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-Authored-By: Matthias247 <matthias.einwag@live.com>
    Centril and Matthias247 committed Feb 3, 2019
    Configuration menu
    Copy the full SHA
    01a704c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9e6bc3c View commit details
    Browse the repository at this point in the history
  4. Fix test

    Matthias247 committed Feb 3, 2019
    Configuration menu
    Copy the full SHA
    f005e1c View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2019

  1. Configuration menu
    Copy the full SHA
    e1ec814 View commit details
    Browse the repository at this point in the history
  2. review suggestions

    Matthias247 committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    363e992 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2019

  1. Configuration menu
    Copy the full SHA
    8e7ef03 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2019

  1. Configuration menu
    Copy the full SHA
    a1c4cf6 View commit details
    Browse the repository at this point in the history
  2. Reweork incompatible match arms error

    - Point at the body expression of the match arm with the type error.
    - Point at the prior match arms explicitely stating the evaluated type.
    - Point at the entire match expr in a secondary span, instead of primary.
    - For type errors in the first match arm, the cause is outside of the
      match, treat as implicit block error to give a more appropriate error.
    estebank committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    9e934e2 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2019

  1. Configuration menu
    Copy the full SHA
    7eb6a2a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    802c897 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7d6bfc5 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2019

  1. Configuration menu
    Copy the full SHA
    1ef34a5 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2019

  1. Configuration menu
    Copy the full SHA
    05b4e7c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ea159e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7cfba1c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    235523c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    87dd2e1 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2019

  1. Merging master

    Matthias247 committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    871338c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e73f96a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b376ae6 View commit details
    Browse the repository at this point in the history
  4. fix whitespace

    RalfJung committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    1a5304a View commit details
    Browse the repository at this point in the history
  5. fix rebase fallout

    RalfJung committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    22d5e6a View commit details
    Browse the repository at this point in the history
  6. Convert old doc links to current edition

    Use footnote style to bypass the tidy check
    tesuji committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    e7f8e63 View commit details
    Browse the repository at this point in the history
  7. suggestion-diagnostics: as_ref improve snippet

    Improve the code snippet suggested in suggestion-diagnostics when
    suggesting the use of as_ref.
    dlrobertson committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    285d4a7 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2019

  1. Reduce the size of hir::Expr.

    From 104 bytes to 72 bytes on x86-64. This slightly reduces instruction
    counts.
    
    Also add an assertion about the size.
    nnethercote committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    5d65e8c View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#57451 - dlrobertson:can_use_as_ref_nit, r=e…

    …stebank
    
    suggestion-diagnostics: as_ref improve snippet
    
    Improve the code snippet suggested in suggestion-diagnostics when
    suggesting the use of as_ref.
    
    Given:
    
    ```rust
    fn test(x: &usize) {}
    fn main() {
        Some(42).map(|x| test(x));
    }
    ```
    
    Suggest
    
    ```
      help: consider using `as_ref` instead: `as_ref().map`
    ```
    
    Instead of
    
    ```
      help: consider using `as_ref` instead: `as_ref().`
    ```
    Centril authored Feb 14, 2019
    Configuration menu
    Copy the full SHA
    93ecae6 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#57856 - lzutao:fix-old-first-edition, r=ste…

    …veklabnik
    
    Convert old first edition links to current edition one
    
    r? @steveklabnik
    Centril authored Feb 14, 2019
    Configuration menu
    Copy the full SHA
    aa896f3 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#57992 - Matthias247:waker4, r=cramertj

    Update the future/task API
    
    This change updates the future and task API as discussed in the stabilization RFC at rust-lang/rfcs#2592.
    
    Changes:
    - Replacing UnsafeWake with RawWaker and RawWakerVtable
    - Removal of LocalWaker
    - Removal of Arc-based Wake trait
    Centril authored Feb 14, 2019
    Configuration menu
    Copy the full SHA
    919cf42 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#58258 - nnethercote:shrink-hir-Expr, r=mich…

    …aelwoerister
    
    Reduce the size of `hir::Expr`.
    
    From 104 bytes to 72 bytes on x86-64. This slightly reduces instruction
    counts.
    
    Also add an assertion about the size.
    Centril authored Feb 14, 2019
    Configuration menu
    Copy the full SHA
    b6ed206 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#58267 - estebank:match-arms, r=matthewjasper

    Tweak "incompatible match arms" error
    
    - Point at the body expression of the match arm with the type error.
    - Point at the prior match arms explicitly stating the evaluated type.
    - Point at the entire match expr in a secondary span, instead of primary.
    - For type errors in the first match arm, the cause is outside of the
      match, treat as implicit block error to give a more appropriate error.
    
    Fix rust-lang#46776, fix rust-lang#57206.
    CC rust-lang#24157, rust-lang#38234.
    Centril authored Feb 14, 2019
    Configuration menu
    Copy the full SHA
    4ad3cf2 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#58296 - estebank:hidden-suggestion, r=oli-obk

    Hidden suggestion support
    
    Add way to hide suggestion snippet window from cli output to avoid cluttered spans that don't enhance understanding.
    
    r? @pietroalbini CC @zackmdavis
    Centril authored Feb 14, 2019
    Configuration menu
    Copy the full SHA
    56e1916 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#58301 - RalfJung:fat-ptr-eq, r=oli-obk

    Enable comparing fat pointers
    
    Also refactor our binops a bit to make that happen more easily.
    
    r? @oli-obk
    Centril authored Feb 14, 2019
    Configuration menu
    Copy the full SHA
    fab0f9b View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#58308 - gnzlbg:context_insert_intr, r=eddyb

    Extract block to insert an intrinsic into its own function
    
    r? @eddyb
    Centril authored Feb 14, 2019
    Configuration menu
    Copy the full SHA
    a0767d6 View commit details
    Browse the repository at this point in the history