Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 19 pull requests #58495

Merged
merged 60 commits into from
Feb 17, 2019
Merged

Rollup of 19 pull requests #58495

merged 60 commits into from
Feb 17, 2019

Commits on Jan 26, 2019

  1. Configuration menu
    Copy the full SHA
    1ac7277 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2019

  1. Configuration menu
    Copy the full SHA
    270151b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    65440a3 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2019

  1. Fix rust-lang#57730

    Zoxc committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    e6d5f25 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2019

  1. Configuration menu
    Copy the full SHA
    397eb4f View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2019

  1. Configuration menu
    Copy the full SHA
    9d2a0b9 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2019

  1. Remove code for updating copyright years in generate-deriving-span-tests

    It's no longer necessary, as there is no license header anymore.
    KamilaBorowska committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    0d28a24 View commit details
    Browse the repository at this point in the history
  2. Remove initial newline from automatically generated span tests

    This change was accidentally introduced while removing license headers.
    KamilaBorowska committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    df420aa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8f6d05b View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2019

  1. Configuration menu
    Copy the full SHA
    d264755 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2019

  1. Configuration menu
    Copy the full SHA
    6156def View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2019

  1. Configuration menu
    Copy the full SHA
    7b2a08c View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2019

  1. Configuration menu
    Copy the full SHA
    3777b86 View commit details
    Browse the repository at this point in the history
  2. Revert "Remove mentions of unstable sort_by_cached key from stable do…

    …cumentation"
    
    This reverts commit 9c7b69e.
    scottmcm committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    317f153 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d15c358 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    91f67fd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    719be24 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    26ade1c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7f5dc49 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    72be9a6 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e24af6c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b17ca01 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4c1a1c3 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    767dadf View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    c154bf7 View commit details
    Browse the repository at this point in the history
  14. Use posix_spawn_file_actions_addchdir_np when possible

    This is a non-POSIX extension implemented in Solaris and in glibc 2.29.
    With this we can still use `posix_spawn()` when `Command::current_dir()`
    has been set, otherwise we fallback to `fork(); chdir(); exec()`.
    cuviper committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    a301655 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    6bce2b8 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2019

  1. mask compiler_builtins docs

    Since `compiler_builtins` is being injected automatically, its docs
    aren't masked. This commit masks the crate's docs if it's brought in as
    an extern crate.
    euclio committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    f565efd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c339ae View commit details
    Browse the repository at this point in the history
  3. Update const fn tests

    varkor committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    feb3408 View commit details
    Browse the repository at this point in the history
  4. Fix documentation typo

    varkor committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    519783a View commit details
    Browse the repository at this point in the history
  5. add .stderr file

    nikomatsakis committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    cce2c89 View commit details
    Browse the repository at this point in the history
  6. Add updated NLL tests

    varkor committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    8ca4406 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b5ab2c7 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1d6ce52 View commit details
    Browse the repository at this point in the history
  9. make Centril happy

    RalfJung committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    95ef9b4 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2019

  1. compile-pass test for rust-lang#53606

    Saleem Jaffer committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    2c8e708 View commit details
    Browse the repository at this point in the history
  2. Fix runtime error in generate-keyword-tests

    The script was made unusable after removing license headers.
    KamilaBorowska committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    14001e8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4ad8770 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2019

  1. Configuration menu
    Copy the full SHA
    84e88da View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#58074 - scottmcm:stabilize-sort_by_cached_k…

    …ey, r=SimonSapin
    
    Stabilize slice_sort_by_cached_key
    
    I was going to ask on the tracking issue (rust-lang#34447), but decided to just send this and hope for an FCP here.  The method was added last March by rust-lang#48639.
    
    Signature: https://doc.rust-lang.org/std/primitive.slice.html#method.sort_by_cached_key
    ```rust
    impl [T] {
        pub fn sort_by_cached_key<K, F>(&mut self, f: F)
            where F: FnMut(&T) -> K, K: Ord;
    }
    ```
    
    That's an identical signature to the existing `sort_by_key`, so I think the questions are just naming, implementation, and the usual "do we want this?".
    
    The implementation seems to have proven its use in rustc at least, which many uses: https://github.com/rust-lang/rust/search?l=Rust&q=sort_by_cached_key
    
    (I'm asking because it's exactly what I just needed the other day:
    ```rust
        all_positions.sort_by_cached_key(|&n|
            data::CITIES.iter()
                .map(|x| *metric_closure.get_edge(n, x.pos).unwrap())
                .sum::<usize>()
        );
    ```
    since caching that key is a pretty obviously good idea.)
    
    Closes rust-lang#34447
    kennytm committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    f05e6bf View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#58196 - varkor:const-fn-feature-gate-error,…

    … r=oli-obk
    
    Add specific feature gate error for const-unstable features
    
    Before:
    ```
    error: `impl Trait` in const fn is unstable
     --> src/lib.rs:7:19
      |
    7 | const fn foo() -> impl T {
      |                   ^^^^^^
    
    error: aborting due to previous error
    ```
    
    After:
    ```
    error[E0723]: `impl Trait` in const fn is unstable (see issue rust-lang#57563)
     --> src/lib.rs:7:19
      |
    7 | const fn foo() -> impl T {
      |                   ^^^^^^
      = help: add #![feature(const_fn)] to the crate attributes to enable
    
    error: aborting due to previous error
    ```
    
    This improves the situation with rust-lang#57563. Fixes rust-lang#57544. Fixes rust-lang#54469.
    
    r? @oli-obk
    kennytm committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    49107c3 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#58293 - xfix:patch-16, r=Mark-Simulacrum

    Remove code for updating copyright years in generate-deriving-span-tests
    
    It's no longer necessary, as there is no license header anymore.
    kennytm committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    9472f0c View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#58306 - GuillaumeGomez:crate-browser-histor…

    …y, r=QuietMisdreavus
    
    Don't default on std crate when manipulating browser history
    
    Fixes rust-lang#58263.
    
    r? @QuietMisdreavus
    kennytm committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    9a3e22e View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#58359 - taiki-e:impl_snapshot_for, r=oli-obk

    librustc_mir: use ? in impl_snapshot_for! macro
    kennytm committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    092d191 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#58429 - RalfJung:box, r=TimNN

    fix Box::into_unique effecitvely transmuting to a raw ptr
    
    Miri/Stacked Borrows treat `Box` specially: they assert that it is unique, and tag it appropriately. However, currently, `Box::into_inner` is not aware of that and returns a raw pointer (wrapped in a `Unique`) that carries the same tag as the box, meaning it carries a `Uniq` tag. This leads to all sorts of problems when people use the raw pointer they get out of the `Unique` type.
    
    In the future, it'd be interesting to make `Unique` also carry some kind of uniqueness. In that case, something like this would instead be needed whenever a raw pointer is extracted from a `Unique`. However, that is out-of-scope for the current version of Stacked Borrows. So until then, this changes `into_unique` to perform a proper reference-to-raw-ptr-cast, which clears the tag.
    kennytm committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    13b055d View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#58433 - RalfJung:miri-mark-tests, r=TimNN

    Update which libcore/liballoc tests Miri ignores, and document why
    kennytm committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    0fecb6d View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#58438 - cuviper:posix_spawn_file_actions_ad…

    …dchdir_np, r=alexcrichton
    
    Use posix_spawn_file_actions_addchdir_np when possible
    
    This is a non-POSIX extension implemented in Solaris and in glibc 2.29.
    With this we can still use `posix_spawn()` when `Command::current_dir()`
    has been set, otherwise we fallback to `fork(); chdir(); exec()`.
    kennytm committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    50f3c81 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#58440 - gnzlbg:v6, r=japaric

    Whitelist the ARM v6 target-feature
    kennytm committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    30019ed View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#58448 - euclio:missing-summaries, r=QuietMi…

    …sdreavus
    
    rustdoc: mask `compiler_builtins` docs
    
    Fixes rust-lang#46783.
    
    I wasn't able to fully confirm the underlying cause, but my theory is that functions in `compiler_builtins` were overwriting functions with the same names in libcore in the search index. Since the functions in `compiler_builtins` didn't have docs, that's why they weren't appearing in the results.
    
    Masking the `compiler_builtins` crate fixes the search results. It appears that this crate was accidentally unmasked in rust-lang#49503.
    kennytm committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    762b988 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#58468 - RalfJung:maybe-uninit-split, r=Centril

    split MaybeUninit into several features, expand docs a bit
    
    This splits the `maybe_uninit` feature gate into several:
    
    * `maybe_uninit` for what we will hopefully stabilize soon-ish.
    * `maybe_uninit_ref` for creating references into `MaybeUninit`, for which the rules are not yet clear.
    * `maybe_uninit_slice` for handling slices of `MaybeUninit`, which needs more API design work.
    * `maybe_uninit_array` for creating arrays of `MaybeUninit` using a macro (because we don't have rust-lang#49147 yet).
    
    Is that an okay thing to do? The goal is to help people avoid APIs we do not want to stabilize yet. I used this to make sure rustc itself does not use `get_ref` and `get_mut`.
    
    I also extended the docs to advise against uninitialized integers -- again this is something for which the rules are still being discussed.
    kennytm committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    9a2437c View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    d6a98f4 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    3ba6177 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2019

  1. Rollup merge of rust-lang#58479 - saleemjaffer:test_promote_evaluatio…

    …n_unused_result, r=oli-obk
    
    compile-pass test for rust-lang#53606
    
    fixes rust-lang#53606
    kennytm committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    cfa6a70 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#58489 - xfix:fix-keyword-tests-runtime-erro…

    …r, r=alexcrichton
    
    Fix runtime error in generate-keyword-tests
    
    The script was made unusable after removing license headers.
    kennytm committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    4739cd8 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#57929 - GuillaumeGomez:rustodc-remove-old-s…

    …tyle-files, r=ollie27
    
    Rustdoc remove old style files
    
    Reopening of rust-lang#56577 (which I can't seem to reopen...).
    
    I made the flag unstable so with this change, what was blocking the PR is now gone I assume.
    kennytm committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    f8ccdeb View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#58395 - vi:checked_duration_since, r=dtolnay

    Instant::checked_duration_since
    kennytm committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    17b07f9 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#58496 - nathan:doc-std-path-pathbuf-pop, r=…

    …frewsxcv
    
    Fix documentation for std::path::PathBuf::pop
    
    Closes rust-lang#58474.
    kennytm committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    98f1865 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#58509 - phansch:add_myself_to_clippy_toolst…

    …ate_maintainers, r=oli-obk
    
    Notify myself when Clippy toolstate changes
    kennytm committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    4fcee62 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#58521 - sfackler:error-iter-issue, r=withou…

    …tboats
    
    Fix tracking issue for error iterators
    kennytm committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    c65a82a View commit details
    Browse the repository at this point in the history