Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: support methods on primitives in intra-doc links #58642

Merged
merged 2 commits into from
Feb 24, 2019

Conversation

tspiteri
Copy link
Contributor

Fixes #58598.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 22, 2019
@rust-highfive
Copy link
Collaborator

r? @GuillaumeGomez

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-lang rust-lang deleted a comment from rust-highfive Feb 22, 2019
@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Feb 22, 2019

📌 Commit bba0ea2 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 22, 2019
Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019
… r=GuillaumeGomez

rustdoc: support methods on primitives in intra-doc links

Fixes rust-lang#58598.
Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019
… r=GuillaumeGomez

rustdoc: support methods on primitives in intra-doc links

Fixes rust-lang#58598.
Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019
… r=GuillaumeGomez

rustdoc: support methods on primitives in intra-doc links

Fixes rust-lang#58598.
Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019
… r=GuillaumeGomez

rustdoc: support methods on primitives in intra-doc links

Fixes rust-lang#58598.
@Centril
Copy link
Contributor

Centril commented Feb 23, 2019

@bors rollup-

@tspiteri
Copy link
Contributor Author

@ bors rollup-

@Centril I rebased onto master after #58100 (Transition librustdoc to Rust 2018) was merged and added a commit to fix the build; will this PR be rollup-ed again?

@Centril
Copy link
Contributor

Centril commented Feb 24, 2019

@bors r=GuillaumeGomez rollup

@bors
Copy link
Contributor

bors commented Feb 24, 2019

📌 Commit aa0fa75 has been approved by GuillaumeGomez

Centril added a commit to Centril/rust that referenced this pull request Feb 24, 2019
… r=GuillaumeGomez

rustdoc: support methods on primitives in intra-doc links

Fixes rust-lang#58598.
bors added a commit that referenced this pull request Feb 24, 2019
Rollup of 6 pull requests

Successful merges:

 - #57364 (Improve parsing diagnostic for negative supertrait bounds)
 - #58183 (Clarify guarantees for `Box` allocation)
 - #58442 (Simplify the unix `Weak` functionality)
 - #58454 (Refactor Windows stdio and remove stdin double buffering )
 - #58511 (Const to op simplification)
 - #58642 (rustdoc: support methods on primitives in intra-doc links)

Failed merges:

r? @ghost
@bors bors merged commit aa0fa75 into rust-lang:master Feb 24, 2019
@tspiteri tspiteri deleted the intra-rustdoc-prim-method branch February 24, 2019 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants