-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow lang and lib features to share names #58741
Conversation
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
Looks good! @bors r=alexreg |
📌 Commit 0f6b148 has been approved by |
@bors p=1 (So that this can land ahead of #57760 (comment) when we r+ p=1 that again.) |
📌 Commit 0f6b148 has been approved by |
r? @alexreg |
I think I have deja vu. |
⌛ Testing commit 0f6b148 with merge 4aedbcf6ac902f3c2e395c68fa8f752dd6a13908... |
💔 Test failed - checks-travis |
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors retry |
Interesting. Maybe this sneaked in with more recent refactorings in the last year? Although I haven't seen any regressions relating to this. I'm not sure... |
⌛ Testing commit 0f6b148 with merge 37ab9096515882ae082629b25091e4a6e750a88e... |
💔 Test failed - checks-travis |
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@petrochenkov Well, the evidence says otherwise...? |
@bors retry |
Allow lang and lib features to share names Fixes #58715. I didn't add a test, because there's currently no standard lang test feature and I felt apprehensive about adding a permanently unstable feature. Instead, a shared lang/lib feature will be used in #57760 and will essentially provide an immediately test.
☀️ Test successful - checks-travis, status-appveyor |
Fixes #58715.
I didn't add a test, because there's currently no standard lang test feature and I felt apprehensive about adding a permanently unstable feature. Instead, a shared lang/lib feature will be used in #57760 and will essentially provide an immediately test.