Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 18 pull requests #58763

Closed
wants to merge 56 commits into from
Closed

Rollup of 18 pull requests #58763

wants to merge 56 commits into from

Commits on Feb 19, 2019

  1. improve unused doc comment diagnostic reporting

    Report all unused attributes on a given doc comment instead of just the
    first one, and extend the span of sugared doc comments to encompass the
    whole comment.
    euclio committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    d339468 View commit details
    Browse the repository at this point in the history
  2. expand unused doc comment diagnostic

    Report the diagnostic on macro expansions, and add a label indicating
    why the comment is unused.
    euclio committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    b5fadf0 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2019

  1. Configuration menu
    Copy the full SHA
    890ef48 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    906ec8a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1536852 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2019

  1. Deny async fn in 2015 edition

    Fix style issues and update diagnostic messages
    
    Update src/librustc_passes/diagnostics.rs
    
    Co-Authored-By: doctorn <me@nathancorbyn.com>
    
    Deny nested `async fn` in Rust 2015 edition
    
    Deny nested `async fn` in Rust 2015 edition
    
    Deny nested `async fn` in Rust 2015 edition
    doctorn committed Feb 24, 2019
    Configuration menu
    Copy the full SHA
    8300f51 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b7d4f96 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2019

  1. Configuration menu
    Copy the full SHA
    f1b88ab View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2019

  1. Update dlmalloc to 0.1.3

    Jethro Beekman committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    6c44bbb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eddd07c View commit details
    Browse the repository at this point in the history
  3. Disable running several Stdio doctests

    * A number of `Stdio` related doc examples include running the "rev"
    command to illustrate piping commands. The majority of these tests are
    marked as `no_run` except for two tests which were not
    * Not running these tests is unlikely to cause any negative impact, and
    doing so also allows the test suite to pass in environments where the
    "rev" command is unavailable
    ipetkov committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    abd88a9 View commit details
    Browse the repository at this point in the history
  4. update scoped_tls to 1.0

    Marcel Hellwig committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    5b97516 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    992694a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b23fd43 View commit details
    Browse the repository at this point in the history
  7. update Cargo.lock

    hellow554 committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    56fb287 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2d62619 View commit details
    Browse the repository at this point in the history
  9. Add tests

    TimDiekmann committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    4839d8c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    6375efc View commit details
    Browse the repository at this point in the history
  11. Satisfy tidy

    TimDiekmann committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    278cb91 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    baea3c7 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    c5f3830 View commit details
    Browse the repository at this point in the history
  14. Clarify rotate_{left,right} docs

    I wondered what the `<<!` operator is although the exclamation mark was
    only the end of the sentence.
    tbu- committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    998896c View commit details
    Browse the repository at this point in the history
  15. Normalize the type Self resolves to in an impl

    This is required at the very least in order to evaluate associated
    constants for arrays (see rust-lang#58212).
    Angelos Oikonomopoulos committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    9b4055b View commit details
    Browse the repository at this point in the history
  16. Changing error message to reflect changes with the 2018 edition

    Signed-off-by: Adonis <adonis.settouf@gmail.com>
    
    Update src/libsyntax/ext/tt/quoted.rs
    
    Co-Authored-By: asettouf <adonis.settouf@gmail.com>
    
    Update src/libsyntax/ext/tt/quoted.rs
    
    Co-Authored-By: asettouf <adonis.settouf@gmail.com>
    
    Update src/libsyntax/ext/tt/quoted.rs
    
    Co-Authored-By: asettouf <adonis.settouf@gmail.com>
    
    Update src/libsyntax/ext/tt/quoted.rs
    
    Co-Authored-By: asettouf <adonis.settouf@gmail.com>
    
    Update src/libsyntax/ext/tt/quoted.rs
    
    Co-Authored-By: asettouf <adonis.settouf@gmail.com>
    
    Update src/libsyntax/ext/tt/quoted.rs
    
    Co-Authored-By: asettouf <adonis.settouf@gmail.com>
    
    Update src/test/ui/macros/macro-at-most-once-rep-2015-ques-rep.stderr
    
    Co-Authored-By: asettouf <adonis.settouf@gmail.com>
    
    Update src/test/ui/macros/macro-at-most-once-rep-2015-ques-rep.stderr
    
    Co-Authored-By: asettouf <adonis.settouf@gmail.com>
    
    Stabilize split_ascii_whitespace
    
    Tracking issue FCP to merge: rust-lang#48656 (comment)
    
    fix stabilization order of uniform_paths.
    
    hir: add HirId to main Hir nodes
    
    Fix `std::os::fortanix_sgx::usercalls::raw::UsercallNrs`
    
    Fixes fortanix/rust-sgx#88
    
    Update src/libsyntax/ext/tt/quoted.rs
    
    Co-Authored-By: asettouf <adonis.settouf@gmail.com>
    
    Revert "Merge remote-tracking branch 'upstream/master'"
    
    This reverts commit 751f05bd155e2c55d4177fe8211df634faf3a644, reversing
    changes made to 545a3e62b0cb473108869a61b271bc589afb49da.
    asettouf committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    c1f3d15 View commit details
    Browse the repository at this point in the history
  17. Mention unwind(aborts) in diagnostics for #[unwind]

    Simplify input validation for `#[unwind]`, add tests
    petrochenkov committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    5d8fd8b View commit details
    Browse the repository at this point in the history
  18. Add a test for rust-lang#10876

    varkor committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    6fd716d View commit details
    Browse the repository at this point in the history
  19. Add tests for rust-lang#26448

    varkor committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    26e5fc3 View commit details
    Browse the repository at this point in the history
  20. Add a test for rust-lang#26619

    varkor committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    d6448a4 View commit details
    Browse the repository at this point in the history
  21. Add a test for rust-lang#44127

    varkor committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    eef9612 View commit details
    Browse the repository at this point in the history
  22. Add a test for rust-lang#44255

    varkor committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    ad6940d View commit details
    Browse the repository at this point in the history
  23. Add a test for rust-lang#46101

    varkor committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    4e5f780 View commit details
    Browse the repository at this point in the history
  24. Add a test for rust-lang#55731

    varkor committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    d76a632 View commit details
    Browse the repository at this point in the history
  25. Add a test for rust-lang#57781

    varkor committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    0b2f320 View commit details
    Browse the repository at this point in the history
  26. Add a test for rust-lang#22892

    varkor committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    41d4ec6 View commit details
    Browse the repository at this point in the history
  27. Add a test for rust-lang#28587

    varkor committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    caa0799 View commit details
    Browse the repository at this point in the history
  28. Add a test for rust-lang#26577

    varkor committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    16f276b View commit details
    Browse the repository at this point in the history
  29. Add a test for rust-lang#27054

    varkor committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    79c2788 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    5ab5747 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2019

  1. Rollup merge of rust-lang#57882 - euclio:unused-doc-attributes, r=est…

    …ebank
    
    overhaul unused doc comments lint
    
    This PR contains a number of improvements to the `unused_doc_comments` lint.
    
    - Extends the span to cover the entire comment when using sugared doc comments.
    - Triggers the lint for all unused doc comments on a node, instead of just the first one.
    - Triggers the lint on macro expansions, and provides a help note explaining that doc comments must be expanded by the macro.
    - Adds a label pointing at the node that cannot be documented.
    
    Furthermore, this PR fixes any instances in rustc where a macro expansion was erroneously documented.
    Centril authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    03ab58d View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#58075 - asettouf:master, r=varkor

    Fix for issue  rust-lang#58050
    
    Hi,
    
    a quick PR to mention in the compiler error message that `?` is a macro operator, as according to issue rust-lang#58050
    
    It passed `python x.py test src/tools/tidy`  locally, as well as the recommendation to run `/x.py test src/test/ui --stage 1 --bless`.
    
    Let me know if anything else is needed.
    Centril authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    5418e2a View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#58627 - euclio:rustdoc-pass-order, r=QuietM…

    …isdreavus
    
    rustdoc: move collapse and unindent docs passes earlier
    
    Moves these passes as early as possible so later passes will see the same markdown that is passed to the test collector.
    
    Fixes rust-lang#58473, and a similar issue with the private-doc-tests lint.
    
    r? @QuietMisdreavus
    Centril authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    bcc7ec1 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#58629 - euclio:debug-empty-str, r=alexcrichton

    rust-lldb: fix crash when printing empty string
    
    Fixes rust-lang#52185.
    
    ~Re-enables the pretty-std debuginfo test and tweaks the test as necessary to get it to pass again. This reveals that lldb's formatting of enums is broken (rust-lang#58492). I also removed the emoji from the test because I couldn't get the docker image's gdb to print the emoji, just octal escapes (https://github.com/rust-lang/rust/pull/53154/files#r208263904).~
    Centril authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    eac298a View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#58630 - nnethercote:fix-fold_clobber, r=pet…

    …rochenkov
    
    Make `visit_clobber` panic-safe.
    
    Local measurements indicate the performance effect is negligible.
    
    r? @petrochenkov
    Centril authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    34baa82 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#58678 - doctorn:refuse-async-fn-2015-editio…

    …n, r=varkor
    
    Deny `async fn` in 2015 edition
    
    This commit prevents code using `async fn` from being compiled in Rust 2015 edition.
    
    Compiling code of the form:
    
    ```rust
    async fn foo() {}
    ```
    
    Will now result in the error:
    
    ```
    error[E0670]: `async fn` is not permitted in the 2015 edition
     --> async.rs:1:1
      |
    1 | async fn foo() {}
      | ^^^^^
    
    error: aborting due to error
    
    For more information about an error, try `rustc --explain E0670`.
    ```
    
    This resolves rust-lang#58652 and also resolves rust-lang#53714.
    
    r? @varkor
    Centril authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    9c44efd View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#58680 - varkor:xpy-help-index-error, r=alex…

    …crichton
    
    Fix an indexing error when using `x.py help`
    
    Fixes rust-lang#58640.
    Centril authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    08e2d0d View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#58703 - shepmaster:read_line_return, r=centril

    Fix copy-pasted typo for read_string return value
    Centril authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    11552e4 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#58743 - varkor:bulk-needstest-1, r=alexcric…

    …hton
    
    Add tests for several E-needstest issues
    
    This PR adds a number of tests for various `E-needstest` errors. These tend to have been left open for a long time and seem unlikely to be closed otherwise.
    
    Closes rust-lang#10876.
    Closes rust-lang#22892.
    Closes rust-lang#26448.
    Closes rust-lang#26577.
    Closes rust-lang#26619.
    Closes rust-lang#27054.
    Closes rust-lang#28587.
    Closes rust-lang#44127.
    Closes rust-lang#44255.
    Closes rust-lang#55731.
    Closes rust-lang#57781.
    Centril authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    b6e34a0 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#58744 - jethrogb:jb/dlmalloc-0.1.3, r=alexc…

    …richton
    
    Update dlmalloc to 0.1.3
    
    r? @alexcrichton
    Centril authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    372742b View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#58746 - ipetkov:std-process-docs, r=cramertj

    std: docs: Disable running several Stdio doctests
    
    * A number of `Stdio` related doc examples include running the "rev"
    command to illustrate piping commands. The majority of these tests are
    marked as `no_run` except for two tests which were not
    * Not running these tests is unlikely to cause any negative impact, and
    doing so also allows the test suite to pass in environments where the
    "rev" command is unavailable
    Centril authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    86f8f81 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#58748 - hellow554:scoped_tls, r=estebank

    update scoped_tls to 1.0
    
    scoped_tls has been updated to version 1.0
    This PR will hopefully merge flawlessly :)
    
    This fixes, among others, alexcrichton/scoped-tls#9
    
    Note, that the nightly feature has been removed in alexcrichton/scoped-tls@64bd7b8
    Centril authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    0ac99f0 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#58749 - kenta7777:reduce-repetition, r=oli-obk

    Reduce Repetitions of (n << amt) >> amt
    
    Fixes part of [rust-lang#49937](rust-lang#49937).
    Centril authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    bd2dab8 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#58750 - TimDiekmann:master, r=oli-obk

    Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const
    Centril authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    4253413 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#58752 - taiki-e:update-string_cache_codegen…

    …, r=alexcrichton
    
    Update string_cache_codegen to 0.4.2
    
    This removes two dependencies of the old version (string_cache is already the latest version).
    Centril authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    a96150c View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#58755 - tbu-:pr_doc_clarifyrotate, r=Centril

    Clarify `rotate_{left,right}` docs
    
    I wondered what the `<<!` operator is although the exclamation mark was
    only the end of the sentence.
    Centril authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    5dacb01 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#58757 - aoikonomopoulos:issue-58212, r=oli-obk

    Normalize the type Self resolves to in an impl
    
    This is required at the very least in order to evaluate associated
    constants for arrays.
    
    Fixes rust-lang#57796
    Fixes rust-lang#58212.
    
    r? @oli-obk
    cc @hellow554
    Centril authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    6743257 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#58762 - petrochenkov:unwind, r=Mark-Simulacrum

    Mention `unwind(aborts)` in diagnostics for `#[unwind]`
    
    Simplify input validation for `#[unwind]`, add tests
    
    cc rust-lang#58760
    r? @Mark-Simulacrum
    Centril authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    ae28eec View commit details
    Browse the repository at this point in the history