HirIdification: almost there #58992
Closed
HirIdification: almost there #58992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
False alarm, RLS seems unaffected; clippy fix sent. |
|
Looks good. Feel free to append it to #58915 |
|
Closing in favor of #58915 which is higher in the queue and now also contains the commits from this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next iteration of HirIdification (#57578). Builds on #58915 (and thus can be appended to it).
Removes
NodeIdfrom:PathSegmentPatKindDestination(replaces it withHirId)In addition this PR also removes
Visitor::visit_def_mention, which doesn't seem to be doing anything.r? @Zoxc