Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 24 pull requests #59012

Merged
merged 62 commits into from
Mar 9, 2019
Merged

Rollup of 24 pull requests #59012

merged 62 commits into from
Mar 9, 2019

Commits on Feb 13, 2019

  1. Add FreeBSD armv6 and armv7 targets

    MikaelUrankar committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    adddee4 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2019

  1. Configuration menu
    Copy the full SHA
    dc4973d View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2019

  1. Configuration menu
    Copy the full SHA
    edbbfad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    df852c0 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2019

  1. Remove stray ` in the documentation for the FromIterator implementati…

    …on for Option
    Alexandra V committed Mar 3, 2019
    Configuration menu
    Copy the full SHA
    020539e View commit details
    Browse the repository at this point in the history
  2. race condition in thread local storage example

    The example had a potential race condition that would still pass the test.
    If the thread which was supposed to modify it's own thread local was slower than the instruction to
    modify in the main thread, then the test would pass even in case of a failure.
    This is would be minor if the child thread was waited for since it check using an `assert_eq` for
    the same thing, but vice versa.
    However, if the `assert_eq` failed this would trigger a panic, which is not at all caught by the
    example since the thread is not waited on.
    
    Signed-off-by: benaryorg <binary@benary.org>
    benaryorg committed Mar 3, 2019
    Configuration menu
    Copy the full SHA
    2293d22 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    41e60d1 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2019

  1. Configuration menu
    Copy the full SHA
    1fec8c2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b129de4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9ed94e5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6dd2a85 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9e8a62b View commit details
    Browse the repository at this point in the history
  6. Add fixme

    estebank committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    f2718dc View commit details
    Browse the repository at this point in the history
  7. Add an explicit test for issue rust-lang#50582

    This code no longer ICEs, and @yodaldevoid found that it was fixed by
    commit fe5710a. While that added a similar test, we can explicitly test
    this reproducer too.
    
    Closes rust-lang#50582.
    cuviper committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    842014d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e6387b6 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    cd9a0cf View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    cbe3344 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2019

  1. Configuration menu
    Copy the full SHA
    2983d9c View commit details
    Browse the repository at this point in the history
  2. Unrolled await macro.

    Was then able to the minimise the reproduction a little further.
    gilescope committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    33a6469 View commit details
    Browse the repository at this point in the history
  3. Remove JSBackend from config.toml

    JSBackend is implied when building the emscripten backend, and not available for the standard llvm backend.  This commit also puts the example config in sync with the defaults in src/bootstrap/native.rs
    ThisIsADogHello authored Mar 5, 2019
    Configuration menu
    Copy the full SHA
    c0cef33 View commit details
    Browse the repository at this point in the history
  4. Removed whitespace

    gilescope committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    fcec51d View commit details
    Browse the repository at this point in the history
  5. Add self to mailmap

    Lucretiel authored Mar 5, 2019
    Configuration menu
    Copy the full SHA
    8ebc609 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2019

  1. Configuration menu
    Copy the full SHA
    669be1a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0d39797 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    143e7d5 View commit details
    Browse the repository at this point in the history
  4. Regression test for rust-lang#58813

    (Update: Fixed test; revision is meant to introduce compile-failure, w/o ICE.)
    pnkfelix committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    c076701 View commit details
    Browse the repository at this point in the history
  5. Avoid ICE during repr(packed) well-formedness check via delay_span_…

    …bug.
    
    (It is possible that there is a more fundamental invariant being
    violated, in terms of the `check_type_defn` code assuming that lifting
    to tcx will always succeed. But I am unaware of any test input that
    hits this that isn't already type-incorrect in some fashion.)
    pnkfelix committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    d2482fd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    533f011 View commit details
    Browse the repository at this point in the history
  7. Surround found token with `

    estebank committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    02eb523 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2019

  1. Make -Z treat-err-as-bug take a number of errors to be emitted

    `-Z treat-err-as-bug=0` will cause `rustc` to panic after the first
    error is reported. `-Z treat-err-as-bug=2` will cause `rustc` to
    panic after 3 errors have been reported.
    estebank committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    7a55a00 View commit details
    Browse the repository at this point in the history
  2. Fix incorrect default

    estebank authored Mar 7, 2019
    Configuration menu
    Copy the full SHA
    7694ca1 View commit details
    Browse the repository at this point in the history
  3. fix bad use of with_emitter

    estebank committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    754037d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c41ddf1 View commit details
    Browse the repository at this point in the history
  5. fix bad logic

    estebank committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    a7563a3 View commit details
    Browse the repository at this point in the history
  6. Fix with_emitter callers

    estebank committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    bc9b936 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e3299f2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    29716ef View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8bb62d1 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2019

  1. Rollup merge of rust-lang#58080 - MikaelUrankar:freebsd_arm, r=sanxiyn

    Add FreeBSD armv6 and armv7 targets
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    19e39cb View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#58204 - estebank:impl-trait-semi, r=zackmdavis

    On return type `impl Trait` for block with no expr point at last semi
    
    Partial solution, doesn't actually validate that the last statement in the function body can satisfy the trait bound, but it's a good incremental improvement over the status quo.
    
    ```
    error[E0277]: the trait bound `(): Bar` is not satisfied
      --> $DIR/impl-trait-return-trailing-semicolon.rs:3:13
       |
    LL | fn foo() -> impl Bar {
       |             ^^^^^^^^ the trait `Bar` is not implemented for `()`
    LL |     5;
       |      - consider removing this semicolon
       |
       = note: the return type of a function must have a statically known size
    ```
    
    Partially addresses rust-lang#54771.
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    4797568 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#58269 - taeguk:add-some-sources-to-rust-src…

    …-distribution, r=Mark-Simulacrum
    
    Add librustc and libsyntax to rust-src distribution.
    
    Fixes rust-lang#58268.
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    bf7b502 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#58369 - nox:sync-hash-map-entry, r=Amanieu

    Make the Entry API of HashMap<K, V> Sync and Send
    
    Fixes rust-lang#45219
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    55dc386 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#58861 - estebank:fix-negative-traits, r=pet…

    …rochenkov
    
    Expand where negative supertrait specific error is shown
    
    Fix rust-lang#58857.
    
    r? @petrochenkov
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    a68f760 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#58877 - estebank:macro-borrow, r=davidtwco

    Suggest removal of `&` when borrowing macro and appropriate
    
    Fix rust-lang#58815.
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    4fbeb11 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#58883 - estebank:unused-closure-arg, r=varkor

    Suggest appropriate code for unused field when destructuring pattern
    
    Fix rust-lang#56472.
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    3005b4d View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#58891 - Delta-Psi:doc-fixes, r=Centril

    Remove stray ` in the docs for the FromIterator implementation for Option
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    9c99511 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#58893 - benaryorg:thread_local_example_join…

    …, r=alexcrichton
    
    race condition in thread local storage example
    
    The example had a potential race condition that would still pass the test.
    If the thread which was supposed to modify it's own thread local was slower than the instruction to
    modify in the main thread, then the test would pass even in case of a failure.
    This is would be minor if the child thread was waited for since it check using an `assert_eq` for the
    same thing, but vice versa.
    However, if the `assert_eq` failed this would trigger a panic, which is not at all caught by the
    example since the thread is not waited on.
    
    Signed-off-by: benaryorg <binary@benary.org>
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    4bff63f View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#58906 - Nemo157:generator-state-debug-info,…

    … r=Zoxc
    
    Monomorphize generator field types for debuginfo
    
    Fixes rust-lang#58888
    
    r? @Zoxc
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    4083c69 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#58911 - pnkfelix:issue-58435-regression-tes…

    …t, r=alexcrichton
    
    Regression test for rust-lang#58435.
    
    Fix rust-lang#58435
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    c789291 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#58912 - pnkfelix:issue-58813-incr-comp-regr…

    …ess-test, r=petrochenkov
    
    Regression test for rust-lang#58813
    
    Fix rust-lang#58813
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    eaafcb7 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#58916 - tspiteri:release-notes, r=petrochenkov

    Fix release note problems noticed after merging.
    
    Cherry picked from stable branch.
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    d9c6908 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#58918 - gilescope:async-await-issue-testcas…

    …e, r=petrochenkov
    
    Regression test added for an async ICE.
    
    Regression test for rust-lang#57084 (as suggested in issue).
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    c99a240 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#58921 - cuviper:issue-50582, r=varkor

    Add an explicit test for issue rust-lang#50582
    
    This code no longer ICEs, and @yodaldevoid found that it was fixed by
    commit fe5710a. While that added a similar test, we can explicitly test
    this reproducer too.
    
    Closes rust-lang#50582.
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    416edc1 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#58926 - gabi-250:tcx-lifetimes, r=petrochenkov

    Make the lifetime parameters of tcx consistent.
    
    I have implemented `codegen_allocator` for my backend, but I've had to make a small change to its signature in `ExtraBackendMethods`. I wonder if this change is justified, or if it is too specific to my use case to be useful to anyone else.
    
    `write_metadata` and `codegen_allocator` are both called from `codegen_crate` (in `librustc_codegen_ssa/base.rs`), and they both receive the same `tcx` as an argument:
    
    https://github.com/rust-lang/rust/blob/c196097e588b05e86b5ce6de992b2a6e6a7027bd/src/librustc_codegen_ssa/base.rs#L555-L557
    
    and:
    
    https://github.com/rust-lang/rust/blob/c196097e588b05e86b5ce6de992b2a6e6a7027bd/src/librustc_codegen_ssa/base.rs#L640-L642
    
    However, `codegen_allocator` accepts a `TyCtxt` with any lifetime parameters (`tcx: TyCtxt<'_, '_, '_>`), while `write_metadata` requires that the `tcx` argument is of type `TyCtxt<'b, 'gcx, 'gcx>`. In my implementation, I've found that it's necessary for `tcx` in `codegen_allocator` to also have the `<'b, 'gcx, 'gcx>` lifetime parameters.
    
    Have I misunderstood the purpose of the parameters of `TyCtxt`? I've read [here](https://rust-lang.github.io/rustc-guide/ty.html) that the last two parameters only need to be distinct if the function needs to be used during type inference, but I don't think that is the case here.
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    40daa06 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#58931 - estebank:elide-receiver-tyerr, r=va…

    …rkor
    
    Elide invalid method receiver error when it contains TyErr
    
    Fix rust-lang#58712.
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    254bc42 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#58940 - ThisIsADogHello:patch-1, r=alexcric…

    …hton
    
    Remove JSBackend from config.toml
    
    JSBackend is implied when building the emscripten backend, and not available for the standard llvm backend.  This commit also puts the example config in sync with the defaults in src/bootstrap/native.rs
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    b2f7968 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    1d33fc9 View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#58961 - estebank:issue-58462, r=varkor

    On incorrect cfg literal/identifier, point at the right span
    
    CC rust-lang#58462
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    54a5073 View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#58963 - seanmonstar:patch-3, r=cramertj

    libstd: implement Error::source for io::Error
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    378a011 View commit details
    Browse the repository at this point in the history
  22. Rollup merge of rust-lang#58970 - pnkfelix:issue-58158-size-of-assoc-…

    …type-ice, r=petrochenkov
    
    delay_span_bug in wfcheck's ty.lift_to_tcx unwrap
    
    Fix rust-lang#58158
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    c51c90c View commit details
    Browse the repository at this point in the history
  23. Rollup merge of rust-lang#58984 - estebank:multi-treat-err-as-bug, r=…

    …oli-obk
    
    Teach `-Z treat-err-as-bug` to take a number of errors to emit
    
    `-Z treat-err-as-bug` will cause `rustc` to panic after the first error is reported, like previously. `-Z treat-err-as-bug=2` will cause `rustc` to panic after 2 errors have been reported.
    
    Fix rust-lang#58983.
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    72d4c1e View commit details
    Browse the repository at this point in the history
  24. Rollup merge of rust-lang#59007 - varkor:invalid-const-arg-test, r=pe…

    …trochenkov
    
    Add a test for invalid const arguments
    
    Closes rust-lang#58811.
    pietroalbini authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    961e378 View commit details
    Browse the repository at this point in the history