-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 24 pull requests #59012
Rollup of 24 pull requests #59012
Commits on Feb 13, 2019
-
Add FreeBSD armv6 and armv7 targets
MikaelUrankar committedFeb 13, 2019 Configuration menu - View commit details
-
Copy full SHA for adddee4 - Browse repository at this point
Copy the full SHA adddee4View commit details
Commits on Mar 1, 2019
-
Configuration menu - View commit details
-
Copy full SHA for dc4973d - Browse repository at this point
Copy the full SHA dc4973dView commit details
Commits on Mar 2, 2019
-
Configuration menu - View commit details
-
Copy full SHA for edbbfad - Browse repository at this point
Copy the full SHA edbbfadView commit details -
Configuration menu - View commit details
-
Copy full SHA for df852c0 - Browse repository at this point
Copy the full SHA df852c0View commit details
Commits on Mar 3, 2019
-
Remove stray ` in the documentation for the FromIterator implementati…
…on for Option
Alexandra V committedMar 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 020539e - Browse repository at this point
Copy the full SHA 020539eView commit details -
race condition in thread local storage example
The example had a potential race condition that would still pass the test. If the thread which was supposed to modify it's own thread local was slower than the instruction to modify in the main thread, then the test would pass even in case of a failure. This is would be minor if the child thread was waited for since it check using an `assert_eq` for the same thing, but vice versa. However, if the `assert_eq` failed this would trigger a panic, which is not at all caught by the example since the thread is not waited on. Signed-off-by: benaryorg <binary@benary.org>
Configuration menu - View commit details
-
Copy full SHA for 2293d22 - Browse repository at this point
Copy the full SHA 2293d22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41e60d1 - Browse repository at this point
Copy the full SHA 41e60d1View commit details
Commits on Mar 4, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 1fec8c2 - Browse repository at this point
Copy the full SHA 1fec8c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b129de4 - Browse repository at this point
Copy the full SHA b129de4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ed94e5 - Browse repository at this point
Copy the full SHA 9ed94e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6dd2a85 - Browse repository at this point
Copy the full SHA 6dd2a85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e8a62b - Browse repository at this point
Copy the full SHA 9e8a62bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f2718dc - Browse repository at this point
Copy the full SHA f2718dcView commit details -
Add an explicit test for issue rust-lang#50582
This code no longer ICEs, and @yodaldevoid found that it was fixed by commit fe5710a. While that added a similar test, we can explicitly test this reproducer too. Closes rust-lang#50582.
Configuration menu - View commit details
-
Copy full SHA for 842014d - Browse repository at this point
Copy the full SHA 842014dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e6387b6 - Browse repository at this point
Copy the full SHA e6387b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd9a0cf - Browse repository at this point
Copy the full SHA cd9a0cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for cbe3344 - Browse repository at this point
Copy the full SHA cbe3344View commit details
Commits on Mar 5, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 2983d9c - Browse repository at this point
Copy the full SHA 2983d9cView commit details -
Was then able to the minimise the reproduction a little further.
Configuration menu - View commit details
-
Copy full SHA for 33a6469 - Browse repository at this point
Copy the full SHA 33a6469View commit details -
Remove JSBackend from config.toml
JSBackend is implied when building the emscripten backend, and not available for the standard llvm backend. This commit also puts the example config in sync with the defaults in src/bootstrap/native.rs
Configuration menu - View commit details
-
Copy full SHA for c0cef33 - Browse repository at this point
Copy the full SHA c0cef33View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcec51d - Browse repository at this point
Copy the full SHA fcec51dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ebc609 - Browse repository at this point
Copy the full SHA 8ebc609View commit details
Commits on Mar 6, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 669be1a - Browse repository at this point
Copy the full SHA 669be1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d39797 - Browse repository at this point
Copy the full SHA 0d39797View commit details -
Configuration menu - View commit details
-
Copy full SHA for 143e7d5 - Browse repository at this point
Copy the full SHA 143e7d5View commit details -
Regression test for rust-lang#58813
(Update: Fixed test; revision is meant to introduce compile-failure, w/o ICE.)
Configuration menu - View commit details
-
Copy full SHA for c076701 - Browse repository at this point
Copy the full SHA c076701View commit details -
Avoid ICE during
repr(packed)
well-formedness check via delay_span_……bug. (It is possible that there is a more fundamental invariant being violated, in terms of the `check_type_defn` code assuming that lifting to tcx will always succeed. But I am unaware of any test input that hits this that isn't already type-incorrect in some fashion.)
Configuration menu - View commit details
-
Copy full SHA for d2482fd - Browse repository at this point
Copy the full SHA d2482fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 533f011 - Browse repository at this point
Copy the full SHA 533f011View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02eb523 - Browse repository at this point
Copy the full SHA 02eb523View commit details
Commits on Mar 7, 2019
-
Make
-Z treat-err-as-bug
take a number of errors to be emitted`-Z treat-err-as-bug=0` will cause `rustc` to panic after the first error is reported. `-Z treat-err-as-bug=2` will cause `rustc` to panic after 3 errors have been reported.
Configuration menu - View commit details
-
Copy full SHA for 7a55a00 - Browse repository at this point
Copy the full SHA 7a55a00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7694ca1 - Browse repository at this point
Copy the full SHA 7694ca1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 754037d - Browse repository at this point
Copy the full SHA 754037dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c41ddf1 - Browse repository at this point
Copy the full SHA c41ddf1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7563a3 - Browse repository at this point
Copy the full SHA a7563a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc9b936 - Browse repository at this point
Copy the full SHA bc9b936View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3299f2 - Browse repository at this point
Copy the full SHA e3299f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29716ef - Browse repository at this point
Copy the full SHA 29716efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8bb62d1 - Browse repository at this point
Copy the full SHA 8bb62d1View commit details
Commits on Mar 8, 2019
-
Rollup merge of rust-lang#58080 - MikaelUrankar:freebsd_arm, r=sanxiyn
Add FreeBSD armv6 and armv7 targets
Configuration menu - View commit details
-
Copy full SHA for 19e39cb - Browse repository at this point
Copy the full SHA 19e39cbView commit details -
Rollup merge of rust-lang#58204 - estebank:impl-trait-semi, r=zackmdavis
On return type `impl Trait` for block with no expr point at last semi Partial solution, doesn't actually validate that the last statement in the function body can satisfy the trait bound, but it's a good incremental improvement over the status quo. ``` error[E0277]: the trait bound `(): Bar` is not satisfied --> $DIR/impl-trait-return-trailing-semicolon.rs:3:13 | LL | fn foo() -> impl Bar { | ^^^^^^^^ the trait `Bar` is not implemented for `()` LL | 5; | - consider removing this semicolon | = note: the return type of a function must have a statically known size ``` Partially addresses rust-lang#54771.
Configuration menu - View commit details
-
Copy full SHA for 4797568 - Browse repository at this point
Copy the full SHA 4797568View commit details -
Rollup merge of rust-lang#58269 - taeguk:add-some-sources-to-rust-src…
…-distribution, r=Mark-Simulacrum Add librustc and libsyntax to rust-src distribution. Fixes rust-lang#58268.
Configuration menu - View commit details
-
Copy full SHA for bf7b502 - Browse repository at this point
Copy the full SHA bf7b502View commit details -
Rollup merge of rust-lang#58369 - nox:sync-hash-map-entry, r=Amanieu
Make the Entry API of HashMap<K, V> Sync and Send Fixes rust-lang#45219
Configuration menu - View commit details
-
Copy full SHA for 55dc386 - Browse repository at this point
Copy the full SHA 55dc386View commit details -
Rollup merge of rust-lang#58861 - estebank:fix-negative-traits, r=pet…
…rochenkov Expand where negative supertrait specific error is shown Fix rust-lang#58857. r? @petrochenkov
Configuration menu - View commit details
-
Copy full SHA for a68f760 - Browse repository at this point
Copy the full SHA a68f760View commit details -
Rollup merge of rust-lang#58877 - estebank:macro-borrow, r=davidtwco
Suggest removal of `&` when borrowing macro and appropriate Fix rust-lang#58815.
Configuration menu - View commit details
-
Copy full SHA for 4fbeb11 - Browse repository at this point
Copy the full SHA 4fbeb11View commit details -
Rollup merge of rust-lang#58883 - estebank:unused-closure-arg, r=varkor
Suggest appropriate code for unused field when destructuring pattern Fix rust-lang#56472.
Configuration menu - View commit details
-
Copy full SHA for 3005b4d - Browse repository at this point
Copy the full SHA 3005b4dView commit details -
Rollup merge of rust-lang#58891 - Delta-Psi:doc-fixes, r=Centril
Remove stray ` in the docs for the FromIterator implementation for Option
Configuration menu - View commit details
-
Copy full SHA for 9c99511 - Browse repository at this point
Copy the full SHA 9c99511View commit details -
Rollup merge of rust-lang#58893 - benaryorg:thread_local_example_join…
…, r=alexcrichton race condition in thread local storage example The example had a potential race condition that would still pass the test. If the thread which was supposed to modify it's own thread local was slower than the instruction to modify in the main thread, then the test would pass even in case of a failure. This is would be minor if the child thread was waited for since it check using an `assert_eq` for the same thing, but vice versa. However, if the `assert_eq` failed this would trigger a panic, which is not at all caught by the example since the thread is not waited on. Signed-off-by: benaryorg <binary@benary.org>
Configuration menu - View commit details
-
Copy full SHA for 4bff63f - Browse repository at this point
Copy the full SHA 4bff63fView commit details -
Rollup merge of rust-lang#58906 - Nemo157:generator-state-debug-info,…
… r=Zoxc Monomorphize generator field types for debuginfo Fixes rust-lang#58888 r? @Zoxc
Configuration menu - View commit details
-
Copy full SHA for 4083c69 - Browse repository at this point
Copy the full SHA 4083c69View commit details -
Rollup merge of rust-lang#58911 - pnkfelix:issue-58435-regression-tes…
…t, r=alexcrichton Regression test for rust-lang#58435. Fix rust-lang#58435
Configuration menu - View commit details
-
Copy full SHA for c789291 - Browse repository at this point
Copy the full SHA c789291View commit details -
Rollup merge of rust-lang#58912 - pnkfelix:issue-58813-incr-comp-regr…
…ess-test, r=petrochenkov Regression test for rust-lang#58813 Fix rust-lang#58813
Configuration menu - View commit details
-
Copy full SHA for eaafcb7 - Browse repository at this point
Copy the full SHA eaafcb7View commit details -
Rollup merge of rust-lang#58916 - tspiteri:release-notes, r=petrochenkov
Fix release note problems noticed after merging. Cherry picked from stable branch.
Configuration menu - View commit details
-
Copy full SHA for d9c6908 - Browse repository at this point
Copy the full SHA d9c6908View commit details -
Rollup merge of rust-lang#58918 - gilescope:async-await-issue-testcas…
…e, r=petrochenkov Regression test added for an async ICE. Regression test for rust-lang#57084 (as suggested in issue).
Configuration menu - View commit details
-
Copy full SHA for c99a240 - Browse repository at this point
Copy the full SHA c99a240View commit details -
Rollup merge of rust-lang#58921 - cuviper:issue-50582, r=varkor
Add an explicit test for issue rust-lang#50582 This code no longer ICEs, and @yodaldevoid found that it was fixed by commit fe5710a. While that added a similar test, we can explicitly test this reproducer too. Closes rust-lang#50582.
Configuration menu - View commit details
-
Copy full SHA for 416edc1 - Browse repository at this point
Copy the full SHA 416edc1View commit details -
Rollup merge of rust-lang#58926 - gabi-250:tcx-lifetimes, r=petrochenkov
Make the lifetime parameters of tcx consistent. I have implemented `codegen_allocator` for my backend, but I've had to make a small change to its signature in `ExtraBackendMethods`. I wonder if this change is justified, or if it is too specific to my use case to be useful to anyone else. `write_metadata` and `codegen_allocator` are both called from `codegen_crate` (in `librustc_codegen_ssa/base.rs`), and they both receive the same `tcx` as an argument: https://github.com/rust-lang/rust/blob/c196097e588b05e86b5ce6de992b2a6e6a7027bd/src/librustc_codegen_ssa/base.rs#L555-L557 and: https://github.com/rust-lang/rust/blob/c196097e588b05e86b5ce6de992b2a6e6a7027bd/src/librustc_codegen_ssa/base.rs#L640-L642 However, `codegen_allocator` accepts a `TyCtxt` with any lifetime parameters (`tcx: TyCtxt<'_, '_, '_>`), while `write_metadata` requires that the `tcx` argument is of type `TyCtxt<'b, 'gcx, 'gcx>`. In my implementation, I've found that it's necessary for `tcx` in `codegen_allocator` to also have the `<'b, 'gcx, 'gcx>` lifetime parameters. Have I misunderstood the purpose of the parameters of `TyCtxt`? I've read [here](https://rust-lang.github.io/rustc-guide/ty.html) that the last two parameters only need to be distinct if the function needs to be used during type inference, but I don't think that is the case here.
Configuration menu - View commit details
-
Copy full SHA for 40daa06 - Browse repository at this point
Copy the full SHA 40daa06View commit details -
Rollup merge of rust-lang#58931 - estebank:elide-receiver-tyerr, r=va…
…rkor Elide invalid method receiver error when it contains TyErr Fix rust-lang#58712.
Configuration menu - View commit details
-
Copy full SHA for 254bc42 - Browse repository at this point
Copy the full SHA 254bc42View commit details -
Rollup merge of rust-lang#58940 - ThisIsADogHello:patch-1, r=alexcric…
…hton Remove JSBackend from config.toml JSBackend is implied when building the emscripten backend, and not available for the standard llvm backend. This commit also puts the example config in sync with the defaults in src/bootstrap/native.rs
Configuration menu - View commit details
-
Copy full SHA for b2f7968 - Browse repository at this point
Copy the full SHA b2f7968View commit details -
Rollup merge of rust-lang#58950 - Lucretiel:patch-5, r=alexcrichton
Add self to mailmap
Configuration menu - View commit details
-
Copy full SHA for 1d33fc9 - Browse repository at this point
Copy the full SHA 1d33fc9View commit details -
Rollup merge of rust-lang#58961 - estebank:issue-58462, r=varkor
On incorrect cfg literal/identifier, point at the right span CC rust-lang#58462
Configuration menu - View commit details
-
Copy full SHA for 54a5073 - Browse repository at this point
Copy the full SHA 54a5073View commit details -
Rollup merge of rust-lang#58963 - seanmonstar:patch-3, r=cramertj
libstd: implement Error::source for io::Error
Configuration menu - View commit details
-
Copy full SHA for 378a011 - Browse repository at this point
Copy the full SHA 378a011View commit details -
Rollup merge of rust-lang#58970 - pnkfelix:issue-58158-size-of-assoc-…
…type-ice, r=petrochenkov delay_span_bug in wfcheck's ty.lift_to_tcx unwrap Fix rust-lang#58158
Configuration menu - View commit details
-
Copy full SHA for c51c90c - Browse repository at this point
Copy the full SHA c51c90cView commit details -
Rollup merge of rust-lang#58984 - estebank:multi-treat-err-as-bug, r=…
…oli-obk Teach `-Z treat-err-as-bug` to take a number of errors to emit `-Z treat-err-as-bug` will cause `rustc` to panic after the first error is reported, like previously. `-Z treat-err-as-bug=2` will cause `rustc` to panic after 2 errors have been reported. Fix rust-lang#58983.
Configuration menu - View commit details
-
Copy full SHA for 72d4c1e - Browse repository at this point
Copy the full SHA 72d4c1eView commit details -
Rollup merge of rust-lang#59007 - varkor:invalid-const-arg-test, r=pe…
…trochenkov Add a test for invalid const arguments Closes rust-lang#58811.
Configuration menu - View commit details
-
Copy full SHA for 961e378 - Browse repository at this point
Copy the full SHA 961e378View commit details