-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When encountering ||{}()
, suggest the likely intended (||{})()
#59035
Merged
+53
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Mar 9, 2019
@bors r+ |
📌 Commit 9aa89b2 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 9, 2019
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 10, 2019
…twco When encountetring `||{}()`, suggest the likely intended `(||{})()` Fix rust-lang#55851.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 10, 2019
…twco When encountetring `||{}()`, suggest the likely intended `(||{})()` Fix rust-lang#55851.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 10, 2019
…twco When encountetring `||{}()`, suggest the likely intended `(||{})()` Fix rust-lang#55851.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 11, 2019
…twco When encountetring `||{}()`, suggest the likely intended `(||{})()` Fix rust-lang#55851.
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Mar 13, 2019
…twco When encountetring `||{}()`, suggest the likely intended `(||{})()` Fix rust-lang#55851.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 16, 2019
…twco When encountetring `||{}()`, suggest the likely intended `(||{})()` Fix rust-lang#55851.
estebank
changed the title
When encountetring
When encountering Mar 18, 2019
||{}()
, suggest the likely intended (||{})()
||{}()
, suggest the likely intended (||{})()
bors
added a commit
that referenced
this pull request
Mar 22, 2019
When encountering `||{}()`, suggest the likely intended `(||{})()` Fix #55851.
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merged-by-bors
This PR was explicitly merged by bors.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #55851.