replace redundant note in deprecation warning #59389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
varkor
reviewed
Mar 24, 2019
euclio
force-pushed
the
deprecated-suggestion
branch
from
4bb9494
to
b163204
Compare
varkor
reviewed
Mar 24, 2019
src/librustc/middle/stability.rs
Outdated
| @@ -576,7 +576,7 @@ impl<'a, 'gcx, 'tcx> TyCtxt<'a, 'gcx, 'tcx> { | |||
| if let hir::Node::Expr(_) = self.hir().get_by_hir_id(id) { | |||
| diag.span_suggestion( | |||
| span, | |||
| &msg, | |||
| "replace the usage of the deprecated item", | |||
There was a problem hiding this comment.
Suggested change
| "replace the usage of the deprecated item", | |
| "replace the use of the deprecated item", |
euclio
force-pushed
the
deprecated-suggestion
branch
from
b163204
to
8d7c2bb
Compare
|
@bors r+ rollup |
|
📌 Commit 8d7c2bb has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 26, 2019
replace redundant note in deprecation warning
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 26, 2019
replace redundant note in deprecation warning
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 26, 2019
replace redundant note in deprecation warning
bors
added a commit
that referenced
this pull request
Mar 26, 2019
Rollup of 10 pull requests Successful merges: - #59150 (Expand suggestions for type ascription parse errors) - #59232 (Merge `Promoted` and `Static` in `mir::Place`) - #59267 (Provide suggestion when using field access instead of path) - #59315 (Add no_hash to query macro and move some queries over) - #59334 (Update build instructions in README.md) - #59362 (Demo `FromIterator` short-circuiting) - #59374 (Simplify checked_duration_since) - #59389 (replace redundant note in deprecation warning) - #59410 (Clarify `{Ord,f32,f64}::clamp` docs a little) - #59419 (Utilize `?` instead of `return None`.) Failed merges: r? @ghost
bors
added a commit
that referenced
this pull request
Mar 26, 2019
Rollup of 10 pull requests Successful merges: - #59150 (Expand suggestions for type ascription parse errors) - #59232 (Merge `Promoted` and `Static` in `mir::Place`) - #59267 (Provide suggestion when using field access instead of path) - #59315 (Add no_hash to query macro and move some queries over) - #59334 (Update build instructions in README.md) - #59362 (Demo `FromIterator` short-circuiting) - #59374 (Simplify checked_duration_since) - #59389 (replace redundant note in deprecation warning) - #59410 (Clarify `{Ord,f32,f64}::clamp` docs a little) - #59419 (Utilize `?` instead of `return None`.) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.