-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update libtest to version 0.0.2 #59440
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This made it to the stage1 build, this is blocked on #59336 landing, that should solve the circular dependency between test and libtest. |
#59336 has landed. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Now the build gets up to the ui tests, but some tests fail with the error:
It's unclear which of the sysroot crates is the problematic one. |
Not sure if this makes any sense what I did, but in looking into what's going one here: At super-high-level glance, I wonder if logic in bootstrap |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
☔ The latest upstream changes (presumably #59766) made this pull request unmergeable. Please resolve the merge conflicts. |
ping from triage @alexcrichton waiting for your review @gnzlbg you have conflicts to resolve |
This has my approval, it's waiting for tests to pass |
Update getopts This is a prerequisite to fixing #32352. The rustbuild fix has been pulled out of #59440. r? @alexcrichton
Triage ping @gnzlbg, this is waiting on merge conflicts to be resolved, and the tests need to pass |
Howdy! This is a Triage ping for @gnzlbg, |
Display name of crate requiring rustc_private in error messages. This is extraction and rebase of one part of rust-lang#59440 that doesn't involve external things. r? @oli-obk
@gnzlbg Unfortunately this has sat idle for far too long, and I'm going to have to close this. Thanks for contribution anyway. |
This updates libtest to version 0.0.2.
r? @alexcrichton