Improve the dbg! macro docs #59528
Improve the dbg! macro docs #59528
Conversation
|
r? @shepmaster (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @Centril |
Wrapped lines earlier such that it is more coherent with the rest of the text. Co-Authored-By: DevQps <46896178+DevQps@users.noreply.github.com>
Removed duplicate line. Co-Authored-By: DevQps <46896178+DevQps@users.noreply.github.com>
|
@Centril Thanks for the suggestions. I wasn't aware that the text was written up to a specific length (makes sense now I look at it). I committed your changes! |
|
Thanks! @bors r+ rollup |
|
📌 Commit 8705de4 has been approved by |
bors
added
S-waiting-on-bors
…ntril Improve the dbg! macro docs # Description As stated has been discussed in rust-lang#58383 the docs do not clearly state why it is useful to have the option to use `dbg!` in release builds as well. This PR should change that. closes rust-lang#58383
…ntril Improve the dbg! macro docs # Description As stated has been discussed in rust-lang#58383 the docs do not clearly state why it is useful to have the option to use `dbg!` in release builds as well. This PR should change that. closes rust-lang#58383
Rollup of 10 pull requests Successful merges: - #59376 (RFC 2008: Enum Variants) - #59453 (Recover from parse error in tuple syntax) - #59455 (Account for short-hand field syntax when suggesting borrow) - #59499 (Fix broken download link in the armhf-gnu image) - #59512 (implement `AsRawFd` for stdio locks) - #59525 (Whitelist some rustc attrs) - #59528 (Improve the dbg! macro docs ) - #59532 (In doc examples, don't ignore read/write results) - #59534 (rustdoc: collapse blanket impls in the same way as normal impls) - #59537 (Fix OnceWith docstring.) Failed merges: r? @ghost
|
@Centril I am just trying to learn here a bit, so I hope you don't mind this question: But I seems that by doing the roll-up commit, you pushed the changes into master? Does that mean this branch can be closed now? I did some changes that @lzutao did as well, not sure if they were taken with the roll-up as well? Or am I just misunderstanding the whole roll-up part? :) EDIT: I just read your other comment :) I'll try my best :) |
|
#59550 hasn't been merged yet; but when it will, ordinarily this PR would also be merged. However, since you added commits it won't be automatically closed by GH. Instead, once the rollup is merged, close this PR manually and you can make a new PR with the other changes if you like. |
|
@Centril Alright thanks! I will close the other one I opened in meanwhile then, and just wait for this to finish and then add a new one! Thanks for all the support, stuff is a bit new here, so it takes me some time understand the complete process :) |
|
#59550 was merged. |
Changed reference style in dbg macro docs. # Description A continuation of Pull Request rust-lang#59528 : - Fixed method of referencing and adjusted the references as suggested by @lzutao
Changed reference style in dbg macro docs. # Description A continuation of Pull Request rust-lang#59528 : - Fixed method of referencing and adjusted the references as suggested by @lzutao
Changed reference style in dbg macro docs. # Description A continuation of Pull Request rust-lang#59528 : - Fixed method of referencing and adjusted the references as suggested by @lzutao
Description
As stated has been discussed in #58383 the docs do not clearly state why it is useful to have the option to use
dbg!in release builds as well. This PR should change that.closes #58383