Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use arenas to avoid Lrc in queries #1 #59540

Merged
merged 6 commits into from
Apr 27, 2019
Merged

Use arenas to avoid Lrc in queries #1 #59540

merged 6 commits into from
Apr 27, 2019

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Mar 29, 2019

Based on #59536.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 29, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:1f05e1cc:start=1553963065637996403,finish=1553963068176834388,duration=2538837985
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
#######################################                                   54.4%
######################################################################## 100.0%
[00:02:06] extracting /checkout/obj/build/cache/2019-03-20/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:02:06]     Updating crates.io index
[00:02:19] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:19] Build completed unsuccessfully in 0:00:29
[00:02:19] make: *** [prepare] Error 1
[00:02:19] Makefile:69: recipe for target 'prepare' failed
[00:02:20] Command failed. Attempt 2/5:
[00:02:20] Command failed. Attempt 2/5:
[00:02:20] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:20] Build completed unsuccessfully in 0:00:00
[00:02:20] Makefile:69: recipe for target 'prepare' failed
[00:02:20] make: *** [prepare] Error 1
[00:02:22] Command failed. Attempt 3/5:
[00:02:22] Command failed. Attempt 3/5:
[00:02:23] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:23] Build completed unsuccessfully in 0:00:00
[00:02:23] make: *** [prepare] Error 1
[00:02:23] Makefile:69: recipe for target 'prepare' failed
[00:02:26] Command failed. Attempt 4/5:
[00:02:26] Command failed. Attempt 4/5:
[00:02:26] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:26] Build completed unsuccessfully in 0:00:00
[00:02:26] make: *** [prepare] Error 1
[00:02:26] Makefile:69: recipe for target 'prepare' failed
[00:02:30] Command failed. Attempt 5/5:
[00:02:30] Command failed. Attempt 5/5:
[00:02:30] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:30] Build completed unsuccessfully in 0:00:00
[00:02:30] make: *** [prepare] Error 1
[00:02:30] Makefile:69: recipe for target 'prepare' failed
[00:02:30] The command has failed after 5 attempts.
---
travis_time:end:036bc424:start=1553963233251356842,finish=1553963233256944278,duration=5587436
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:19a02b64
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:119daaa6
travis_time:start:119daaa6
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:02578598
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@eddyb
Copy link
Member

eddyb commented Mar 30, 2019

Can you say which commits should be reviewed? Thanks.

cc @michaelwoerister

@Zoxc Zoxc changed the title Use arenas to avoid Lrc in queries #1 [WIP] Use arenas to avoid Lrc in queries #1 Mar 30, 2019
@Zoxc
Copy link
Contributor Author

Zoxc commented Mar 30, 2019

@eddyb I'll probably just wait for the based on PRs to get merged (feel free to review those). I want to do some perf runs for these too.

@bors
Copy link
Contributor

bors commented Mar 30, 2019

☔ The latest upstream changes (presumably #59561) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0d6dfe30:start=1553978227791232532,finish=1553978230171093863,duration=2379861331
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
[01:07:08] ..........................................i......................................................... 600/5513
[01:07:13] .................................................................................................... 700/5513
[01:07:18] .................................................................................................... 800/5513
[01:07:23] .................................................................................................... 900/5513
[01:07:29] .i...........F...i.................................................................................. 1000/5513
[01:07:33] ..................................iiiii............................................................. 1100/5513
[01:07:40] .................................................................................................... 1300/5513
[01:07:43] .................................................................................................... 1400/5513
[01:07:47] .................................................................................................... 1500/5513
[01:07:50] .................................................................................................... 1600/5513
[01:07:50] .................................................................................................... 1600/5513
[01:07:54] ..................................................i................................................. 1700/5513
[01:07:58] .................................................................................................... 1800/5513
[01:08:02] .................................................................................................... 1900/5513
[01:08:06] .................................................................................................... 2000/5513
[01:08:10] ....................................................................................i............... 2100/5513
[01:08:14] .................................................................................................... 2200/5513
[01:08:19] ..................................F.............F................................................... 2300/5513
[01:08:29] .................................................................................................... 2500/5513
[01:08:33] .................................................................................................... 2600/5513
[01:08:37] .................................................................................................... 2700/5513
[01:08:43] .................................................................................................... 2800/5513
---
[01:10:42] 
[01:10:42] ---- [ui] ui/cycle-projection-based-on-where-clause.rs stdout ----
[01:10:42] diff of stderr:
[01:10:42] 
[01:10:42] 11 LL |           T : Add<T::Item>
[01:10:42] 13 
[01:10:42] 13 
[01:10:42] - error[E0220]: associated type `Item` not found for `T`
[01:10:42] -   --> $DIR/cycle-projection-based-on-where-clause.rs:17:19
[01:10:42] -    |
[01:10:42] - LL |           T : Add<T::Item>
[01:10:42] -    |                   ^^^^^^^ associated type `Item` not found
[01:10:42] + error: aborting due to previous error
[01:10:42] - error: aborting due to 2 previous errors
[01:10:42] - 
[01:10:42] - Some errors occurred: E0220, E0391.
[01:10:42] - For more information about an error, try `rustc --explain E0220`.
[01:10:42] - For more information about an error, try `rustc --explain E0220`.
[01:10:42] + For more information about this error, try `rustc --explain E0391`.
[01:10:42] 24 
[01:10:42] 
[01:10:42] 
[01:10:42] The actual stderr differed from the expected stderr.
[01:10:42] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/cycle-projection-based-on-where-clause/cycle-projection-based-on-where-clause.stderr
[01:10:42] To update references, rerun the tests and pass the `--bless` flag
[01:10:42] To only update this specific test, also pass `--test-args cycle-projection-based-on-where-clause.rs`
[01:10:42] error: 1 errors occurred comparing output.
[01:10:42] status: exit code: 1
[01:10:42] status: exit code: 1
[01:10:42] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/cycle-projection-based-on-where-clause.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/cycle-projection-based-on-where-clause/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/cycle-projection-based-on-where-clause/auxiliary" "-A" "unused"
[01:10:42] ------------------------------------------
[01:10:42] 
[01:10:42] ------------------------------------------
[01:10:42] stderr:
[01:10:42] stderr:
[01:10:42] ------------------------------------------
[01:10:42] {"message":"cycle detected when computing the bounds for type parameter `T`","code":{"code":"E0391","explanation":"\nThis error indicates that some types or traits depend on each other\nand therefore cannot be constructed.\n\nThe following example contains a circular dependency between two traits:\n\n```compile_fail,E0391\ntrait FirstTrait : SecondTrait {\n\n}\n\ntrait SecondTrait : FirstTrait {\n\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/cycle-projection-based-on-where-clause.rs","byte_start":548,"byte_end":555,"line_start":17,"line_end":17,"column_start":19,"column_end":26,"is_primary":true,"text":[{"text":"          T : Add<T::Item>","highlight_start":19,"highlight_end":26}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"...which again requires computing the bounds for type parameter `T`, completing the cycle","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"cycle used when processing `A`","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/cycle-projection-based-on-where-clause.rs","byte_start":548,"byte_end":555,"line_start":17,"line_end":17,"column_start":19,"column_end":26,"is_primary":true,"text":[{"text":"          T : Add<T::Item>","highlight_start":19,"highlight_end":26}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null}],"rendered":"error[E0391]: cycle detected when computing the bounds for type parameter `T`\n  --> /checkout/src/test/ui/cycle-projection-based-on-where-clause.rs:17:19\n   |\nLL |           T : Add<T::Item>\n   |                   ^^^^^^^\n   |\n   = note: ...which again requires computing the bounds for type parameter `T`, completing the cycle\nnote: cycle used when processing `A`\n  --> /checkout/src/test/ui/cycle-projection-based-on-where-clause.rs:17:19\n   |\nLL |           T : Add<T::Item>\n   |                   ^^^^^^^\n\n"}
[01:10:42] {"message":"For more information about this error, try `rustc --explain E0391`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0391`.\n"}
[01:10:42] 
[01:10:42] ------------------------------------------
[01:10:42] 
---
[01:10:42] 
[01:10:42] 17 LL | | {}
[01:10:42] 18    | |__^
[01:10:42] 19 
[01:10:42] - error[E0220]: associated type `Item` not found for `Self`
[01:10:42] -    |
[01:10:42] -    |
[01:10:42] - LL | trait T : Iterator<Item=Self::Item>
[01:10:42] -    |                         ^^^^^^^^^^ associated type `Item` not found
[01:10:42] + error: aborting due to previous error
[01:10:42] - error: aborting due to 2 previous errors
[01:10:42] - 
[01:10:42] - Some errors occurred: E0220, E0391.
[01:10:42] - For more information about an error, try `rustc --explain E0220`.
[01:10:42] - For more information about an error, try `rustc --explain E0220`.
[01:10:42] + For more information about this error, try `rustc --explain E0391`.
[01:10:42] 30 
[01:10:42] 
[01:10:42] 
[01:10:42] The actual stderr differed from the expected stderr.
[01:10:42] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-20772/issue-20772.stderr
[01:10:42] To update references, rerun the tests and pass the `--bless` flag
[01:10:42] To only update this specific test, also pass `--test-args issues/issue-20772.rs`
[01:10:42] error: 1 errors occurred comparing output.
[01:10:42] status: exit code: 1
[01:10:42] status: exit code: 1
[01:10:42] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-20772.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-20772/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-20772/auxiliary" "-A" "unused"
[01:10:42] ------------------------------------------
[01:10:42] 
[01:10:42] ------------------------------------------
[01:10:42] stderr:
[01:10:42] stderr:
[01:10:42] ------------------------------------------
[01:10:42] {"message":"cycle detected when computing the supertraits of `T`","code":{"code":"E0391","explanation":"\nThis error indicates that some types or traits depend on each other\nand therefore cannot be constructed.\n\nThe following example contains a circular dependency between two traits:\n\n```compile_fail,E0391\ntrait FirstTrait : SecondTrait {\n\n}\n\ntrait SecondTrait : FirstTrait {\n\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/issues/issue-20772.rs","byte_start":0,"byte_end":119,"line_start":1,"line_end":4,"column_start":1,"column_end":3,"is_primary":true,"text":[{"text":"trait T : Iterator<Item=Self::Item>","highlight_start":1,"highlight_end":36},{"text":"//~^ ERROR cycle detected","highlight_start":1,"highlight_end":26},{"text":"//~| ERROR associated type `Item` not found for `Self`","highlight_start":1,"highlight_end":55},{"text":"{}","highlight_start":1,"highlight_end":3}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"...which again requires computing the supertraits of `T`, completing the cycle","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"cycle used when collecting item types in top-level module","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/issues/issue-20772.rs","byte_start":0,"byte_end":119,"line_start":1,"line_end":4,"column_start":1,"column_end":3,"is_primary":true,"text":[{"text":"trait T : Iterator<Item=Self::Item>","highlight_start":1,"highlight_end":36},{"text":"//~^ ERROR cycle detected","highlight_start":1,"highlight_end":26},{"text":"//~| ERROR associated type `Item` not found for `Self`","highlight_start":1,"highlight_end":55},{"text":"{}","highlight_start":1,"highlight_end":3}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null}],"rendered":"error[E0391]: cycle detected when computing the supertraits of `T`\n  --> /checkout/src/test/ui/issues/issue-20772.rs:1:1\n   |\nLL | / trait T : Iterator<Item=Self::Item>\nLL | | //~^ ERROR cycle detected\nLL | | //~| ERROR associated type `Item` not found for `Self`\nLL | | {}\n   | |__^\n   |\n   = note: ...which again requires computing the supertraits of `T`, completing the cycle\nnote: cycle used when collecting item types in top-level module\n  --> /checkout/src/test/ui/issues/issue-20772.rs:1:1\n   |\nLL | / trait T : Iterator<Item=Self::Item>\nLL | | //~^ ERROR cycle detected\nLL | | //~| ERROR associated type `Item` not found for `Self`\nLL | | {}\n   | |__^\n\n"}
[01:10:42] {"message":"For more information about this error, try `rustc --explain E0391`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0391`.\n"}
[01:10:42] 
[01:10:42] ------------------------------------------
[01:10:42] 
[01:10:42] 
[01:10:42] thread '[ui] ui/issues/issue-20772.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3422:9
[01:10:42] 
[01:10:42] ---- [ui] ui/issues/issue-21177.rs stdout ----
[01:10:42] diff of stderr:
[01:10:42] 
[01:10:42] 11 LL | fn foo<T: Trait<A = T::B>>() { }
[01:10:42] 13 
[01:10:42] 13 
[01:10:42] - error[E0220]: associated type `B` not found for `T`
[01:10:42] -    |
[01:10:42] -    |
[01:10:42] - LL | fn foo<T: Trait<A = T::B>>() { }
[01:10:42] -    |                     ^^^^ associated type `B` not found
[01:10:42] + error: aborting due to previous error
[01:10:42] - error: aborting due to 2 previous errors
[01:10:42] - 
[01:10:42] - Some errors occurred: E0220, E0391.
[01:10:42] - For more information about an error, try `rustc --explain E0220`.
[01:10:42] - For more information about an error, try `rustc --explain E0220`.
[01:10:42] + For more information about this error, try `rustc --explain E0391`.
[01:10:42] 24 
[01:10:42] 
[01:10:42] 
[01:10:42] The actual stderr differed from the expected stderr.
[01:10:42] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-21177/issue-21177.stderr
[01:10:42] To update references, rerun the tests and pass the `--bless` flag
[01:10:42] To only update this specific test, also pass `--test-args issues/issue-21177.rs`
[01:10:42] error: 1 errors occurred comparing output.
[01:10:42] status: exit code: 1
[01:10:42] status: exit code: 1
[01:10:42] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-21177.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-21177/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-21177/auxiliary" "-A" "unused"
[01:10:42] ------------------------------------------
[01:10:42] 
[01:10:42] ------------------------------------------
[01:10:42] stderr:
[01:10:42] stderr:
[01:10:42] ------------------------------------------
[01:10:42] {"message":"cycle detected when computing the bounds for type parameter `T`","code":{"code":"E0391","explanation":"\nThis error indicates that some types or traits depend on each other\nand therefore cannot be constructed.\n\nThe following example contains a circular dependency between two traits:\n\n```compile_fail,E0391\ntrait FirstTrait : SecondTrait {\n\n}\n\ntrait SecondTrait : FirstTrait {\n\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/issues/issue-21177.rs","byte_start":61,"byte_end":65,"line_start":6,"line_end":6,"column_start":21,"column_end":25,"is_primary":true,"text":[{"text":"fn foo<T: Trait<A = T::B>>() { }","highlight_start":21,"highlight_end":25}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"...which again requires computing the bounds for type parameter `T`, completing the cycle","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"cycle used when processing `foo`","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/issues/issue-21177.rs","byte_start":61,"byte_end":65,"line_start":6,"line_end":6,"column_start":21,"column_end":25,"is_primary":true,"text":[{"text":"fn foo<T: Trait<A = T::B>>() { }","highlight_start":21,"highlight_end":25}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null}],"rendered":"error[E0391]: cycle detected when computing the bounds for type parameter `T`\n  --> /checkout/src/test/ui/issues/issue-21177.rs:6:21\n   |\nLL | fn foo<T: Trait<A = T::B>>() { }\n   |                     ^^^^\n   |\n   = note: ...which again requires computing the bounds for type parameter `T`, completing the cycle\nnote: cycle used when processing `foo`\n  --> /checkout/src/test/ui/issues/issue-21177.rs:6:21\n   |\nLL | fn foo<T: Trait<A = T::B>>() { }\n   |                     ^^^^\n\n"}
[01:10:42] {"message":"For more information about this error, try `rustc --explain E0391`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0391`.\n"}
[01:10:42] 
[01:10:42] ------------------------------------------
[01:10:42] 
---
[01:10:42] 
[01:10:42] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:516:22
[01:10:42] 
[01:10:42] 
[01:10:42] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:10:42] 
[01:10:42] 
[01:10:42] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:10:42] Build completed unsuccessfully in 0:05:00
[01:10:42] Build completed unsuccessfully in 0:05:00
[01:10:42] make: *** [check] Error 1
[01:10:42] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:29a9a308
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sat Mar 30 21:48:04 UTC 2019
---
travis_time:end:24d6d63a:start=1553982486506860227,finish=1553982486515825617,duration=8965390
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:04992e20
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:22569c90
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Apr 2, 2019

☔ The latest upstream changes (presumably #59632) made this pull request unmergeable. Please resolve the merge conflicts.

@Zoxc
Copy link
Contributor Author

Zoxc commented Apr 13, 2019

@bors try

@bors
Copy link
Contributor

bors commented Apr 13, 2019

⌛ Trying commit 9c3de34 with merge f426a56...

bors added a commit that referenced this pull request Apr 13, 2019
[WIP] Use arenas to avoid Lrc in queries #1

Based on #59536.
@bors
Copy link
Contributor

bors commented Apr 13, 2019

☀️ Try build successful - checks-travis
Build commit: f426a56

@Zoxc
Copy link
Contributor Author

Zoxc commented Apr 13, 2019

@rust-timer build f426a56

@rust-timer
Copy link
Collaborator

Success: Queued f426a56 with parent 99da733, comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit f426a56

@Zoxc
Copy link
Contributor Author

Zoxc commented Apr 14, 2019

@bors try

@bors
Copy link
Contributor

bors commented Apr 14, 2019

⌛ Trying commit afcb1b647d249c94aabffdea0fc61364326636be with merge db1920baeb0c1fe34e4fdadb0699d94254383036...

@bors
Copy link
Contributor

bors commented Apr 14, 2019

☀️ Try build successful - checks-travis
Build commit: db1920baeb0c1fe34e4fdadb0699d94254383036

@Zoxc
Copy link
Contributor Author

Zoxc commented Apr 14, 2019

@rust-timer build db1920baeb0c1fe34e4fdadb0699d94254383036

@rust-timer
Copy link
Collaborator

Success: Queued db1920baeb0c1fe34e4fdadb0699d94254383036 with parent ee621f4, comparison URL.

@Zoxc
Copy link
Contributor Author

Zoxc commented Apr 25, 2019

@bors try

@bors
Copy link
Contributor

bors commented Apr 25, 2019

⌛ Trying commit 53269c7 with merge 6da7e37...

bors added a commit that referenced this pull request Apr 25, 2019
[WIP] Use arenas to avoid Lrc in queries #1

Based on #59536.
@bors
Copy link
Contributor

bors commented Apr 25, 2019

☀️ Try build successful - checks-travis
Build commit: 6da7e37

@Zoxc
Copy link
Contributor Author

Zoxc commented Apr 25, 2019

@rust-timer build 6da7e37

@rust-timer
Copy link
Collaborator

Success: Queued 6da7e37 with parent 112f7e9, comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit 6da7e37

@michaelwoerister
Copy link
Member

Nice! Feel free to r=me on the current state of the PR.

@Zoxc Zoxc changed the title [WIP] Use arenas to avoid Lrc in queries #1 Use arenas to avoid Lrc in queries #1 Apr 26, 2019
@Zoxc
Copy link
Contributor Author

Zoxc commented Apr 26, 2019

@bors r=michaelwoerister

@bors
Copy link
Contributor

bors commented Apr 26, 2019

📌 Commit 53269c7 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 26, 2019
@bors
Copy link
Contributor

bors commented Apr 27, 2019

⌛ Testing commit 53269c7 with merge cfeb917...

bors added a commit that referenced this pull request Apr 27, 2019
Use arenas to avoid Lrc in queries #1

Based on #59536.
@bors
Copy link
Contributor

bors commented Apr 27, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: michaelwoerister
Pushing cfeb917 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 27, 2019
@bors bors merged commit 53269c7 into rust-lang:master Apr 27, 2019
@Zoxc Zoxc deleted the the-arena-2 branch April 27, 2019 17:49
bors added a commit that referenced this pull request May 19, 2019
Use arenas to avoid Lrc in queries #2

The `Remove subtle Default impl for Value` makes the compilation stop due earlier due to cycle errors, since there's no longer a default value to continue the compilation with.

Based on #59540.
Centril added a commit to Centril/rust that referenced this pull request May 22, 2019
Use arenas to avoid Lrc in queries rust-lang#2

The `Remove subtle Default impl for Value` makes the compilation stop due earlier due to cycle errors, since there's no longer a default value to continue the compilation with.

Based on rust-lang#59540.
Centril added a commit to Centril/rust that referenced this pull request May 23, 2019
…erister

Use arenas to avoid Lrc in queries rust-lang#2

The `Remove subtle Default impl for Value` makes the compilation stop due earlier due to cycle errors, since there's no longer a default value to continue the compilation with.

Based on rust-lang#59540.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants