Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clippy #59965

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Update clippy #59965

merged 1 commit into from
Apr 15, 2019

Conversation

Manishearth
Copy link
Member

One of our tests using the alloc crate broke because alloc was stabilized.

r? @oli-obk

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 14, 2019
@matthiaskrgr
Copy link
Member

Clippy broke again in the meantime: #59967 (comment)

@Manishearth
Copy link
Member Author

Ah, more HirIDfication

@Manishearth
Copy link
Member Author

(I'm on it)

@Manishearth
Copy link
Member Author

rust-lang/rust-clippy#3961

@Manishearth
Copy link
Member Author

Updated. r? anyone?

@Xanewok
Copy link
Member

Xanewok commented Apr 14, 2019

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Apr 14, 2019

📌 Commit feaf2ae has been approved by Xanewok

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2019
@bors
Copy link
Contributor

bors commented Apr 14, 2019

⌛ Testing commit feaf2ae with merge 11ea66fa9edb031147b255f9e30a825b076253d2...

@bors
Copy link
Contributor

bors commented Apr 14, 2019

⌛ Testing commit feaf2ae with merge c090ab4...

bors added a commit that referenced this pull request Apr 14, 2019
@bors
Auto merge of #59965 - Manishearth:clippyup, r=Xanewok
c090ab4 
Update clippy

One of our tests using the alloc crate broke because alloc was stabilized.

r? @oli-obk
@bors
Copy link
Contributor

bors commented Apr 15, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Xanewok
Pushing c090ab4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 15, 2019
@bors bors merged commit feaf2ae into rust-lang:master Apr 15, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #59965!

Tested on commit c090ab4.
Direct link to PR: #59965

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 rls on windows: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Apr 15, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#59965!
b03113f 
Tested on commit rust-lang/rust@c090ab4.
Direct link to PR: <rust-lang/rust#59965>

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 rls on windows: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
@Xanewok Xanewok mentioned this pull request Apr 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Manishearth @rust-highfive @matthiaskrgr @Xanewok @bors @oli-obk