Add tests for concrete const types #60550
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @varkor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
src/test/ui/const-generics/concrete-const-impl-static-method.rs
Outdated
Show resolved
Hide resolved
src/test/ui/const-generics/concrete-const-impl-associated-non-method.rs
Outdated
Show resolved
Hide resolved
|
Looks good, thanks! If you could merge the |
varkor
added
S-waiting-on-author
BenLewis-Seequent
force-pushed
the
concrete_const_tests
branch
from
3da1d64
to
bfa15f3
Compare
|
@Skinny121: thank you very much! @bors r+ rollup |
|
📌 Commit bfa15f3 has been approved by |
bors
added
S-waiting-on-bors
…arkor Add tests for concrete const types In response to the request for help in rust-lang#44580 (comment), I have added several ui tests around the use of concrete const types, i.e. A<2>. r? @varkor
Rollup of 8 pull requests Successful merges: - #59979 (to_xe_bytes for isize and usize returns an array of different size) - #60491 (std: Update compiler-builtins crate) - #60550 (Add tests for concrete const types) - #60572 (Add test for #59972) - #60627 (test for #50518) - #60634 (Document + Cleanup lang_items.rs) - #60641 (Instead of ICEing on incorrect pattern, use delay_span_bug) - #60644 (Use `delay_span_bug` for "Failed to unify obligation") Failed merges: r? @ghost
In response to the request for help in #44580 (comment), I have added several ui tests around the use of concrete const types, i.e. A<2>.
r? @varkor