Remove the unstable and deprecated mpsc_select #60921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Note: Beyond the API changes, I only removed obviously unused/unreachable code. I suspect more cleanup is possible, like the remaining |
This comment has been minimized.
This comment has been minimized.
This removes macro `select!` and `std::sync::mpsc::{Handle, Select}`,
which were all unstable and have been deprecated since 1.32.
cuviper
force-pushed
the
remove-mpsc_select
branch
from
99e77a8 to
f950193
Compare
|
@bors r+ |
|
📌 Commit f950193 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
May 20, 2019
Remove the unstable and deprecated mpsc_select
This removes macro `select!` and `std::sync::mpsc::{Handle, Select}`,
which were all unstable and have been deprecated since 1.32.
Closes #27800
r? @SimonSapin
|
☀️ Test successful - checks-travis, status-appveyor |
This was referenced Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes macro
select!andstd::sync::mpsc::{Handle, Select},which were all unstable and have been deprecated since 1.32.
Closes #27800
r? @SimonSapin