Haiku: the maximum stack size is 16 MB #61683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Jun 9, 2019
|
r? @nagisa |
|
Could the commit message have more information on the crash (such as where this limitation comes from, how the the crash manifests itself) so that it can be traced back to something when looking at the line? |
Centril
added
S-waiting-on-author
When one tries to create a thread with a requested stack size larger than 16 MB, the call will fail and the compiler will bail out. Therefore we should limit the size of the thread stack to 16 MB on Haiku.
|
@nagisa I updated the log message. Does this make it clear? |
|
@bors r+ |
|
📌 Commit 56a7f1e has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 10, 2019
Haiku: the maximum stack size is 16 MB This keeps the compiler from crashing every time it is invoked. No functional change on other platforms. This patch is similar to the limitation that is in the [librustdoc/lib.rs](https://github.com/rust-lang/rust/blob/57e13e0325c1d41161a31de1f8520538ec2c575c/src/librustdoc/lib.rs#L89).
bors
added a commit
that referenced
this pull request
Jun 10, 2019
Rollup of 5 pull requests Successful merges: - #59600 (Replaced linear token counting macros with optimized implementation) - #61501 (get rid of real_intrinsics module) - #61570 (Fix issues with const argument inference) - #61683 (Haiku: the maximum stack size is 16 MB) - #61697 (submodules: update clippy from 71be6f6 to c0dbd34) Failed merges: r? @ghost
workingjubilee
added
the
O-haiku
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the compiler from crashing every time it is invoked. No functional change on other platforms.
This patch is similar to the limitation that is in the librustdoc/lib.rs.