Add deny(unused_lifetimes) to all the crates that have deny(internal). #61735

eddyb · 2019-06-11T10:29:01Z

@Zoxc brought up, regarding #61722, that we don't force the removal of unused lifetimes.
Turns out that it's not that bad to enable for compiler crates (I wonder why it's not warn by default?).

I would've liked to enable single_use_lifetimes as well, but #53738 makes it unusable for now.

For the rustfmt commit, I used rust-lang/rustfmt#1324 (comment), and manually filtered out some noise.

r? @oli-obk cc @rust-lang/compiler

oli-obk · 2019-06-11T10:35:51Z

src/librustc/util/captures.rs

@@ -3,6 +3,8 @@
 /// Basically a workaround; see [this comment] for details.
 ///
 /// [this comment]: https://github.com/rust-lang/rust/issues/34511#issuecomment-373423999
+// FIXME(eddyb) false positive, the lifetime parameter is "phantom" but needed.
+#[allow(unused_lifetimes)]
 pub trait Captures<'a> { }


this should really be in core::marker

I'd rather impl Trait not need it at all.

oli-obk · 2019-06-11T10:39:34Z

I wonder why it's not warn by default?

because of the false positives you encountered. Rustc lints have a very high bar.

@bors r+

bors · 2019-06-11T10:39:35Z

📌 Commit 765fd84ddb3f6d9288a4114f4f5de730986064db has been approved by oli-obk

petrochenkov · 2019-06-11T10:39:56Z

src/libarena/lib.rs

@@ -13,6 +13,7 @@

 #![deny(rust_2018_idioms)]
 #![deny(internal)]
+#![deny(unused_lifetimes)]


Both deny(internal) and deny(unused_lifetimes) can be enabled through rustbuild (src\bootstrap\bin\rustc.rs) rather than through all crates individually, similarly to deny(warnings)/deny(bare_trait_objects).

Fair point. cc @flip1995

Did this locally and it revealed rustc_data_structures and rustc_macros were missing deny(internal) and deny(unused_lifetimes).

Looks like default_hash_types may be a problem.
Unlike other lints it's not universally applicable and is not a no-op for non-compiler crates.

It's even worse, the rustbuild thing seems to apply to all crates, not just compiler ones.

the rustbuild thing seems to apply to all crates

I expected that, but also expected internal lints to not report anything for non-compiler crates (since they don't have TyCtxt etc).

Yeah default_hash_types is also explicitly allowed in libstd for example.

Most of the internal lints shouldn't report anything in most of the crates. I will figure this out in #61545

Any reason why these are deny instead of warn? This means these are hard errors even with deny-warnings = false.

src/librustc/traits/auto_trait.rs

src/librustc/ty/layout.rs

eddyb · 2019-06-11T11:13:27Z

@bors rollup=never p=2

eddyb · 2019-06-11T12:26:35Z

@petrochenkov @oli-obk I've backed out the rustbuild changes, everything seemed fine but changing src/bootstrap/bin/rustc.rs doesn't trigger a rebuild. Turns out core, std etc. would be affected too.

@bors r=oli-obk

rust-highfive · 2019-06-11T15:36:11Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

The command "curl -fo /home/travis/stamp https://s3-us-west-1.amazonaws.com/rust-lang-ci2/rust-ci-mirror/2017-03-17-stamp-x86_64-unknown-linux-musl" failed. Retrying, 3 of 3.
curl: (56) GnuTLS recv error (-54): Error in the pull function.
The command "curl -fo /home/travis/stamp https://s3-us-west-1.amazonaws.com/rust-lang-ci2/rust-ci-mirror/2017-03-17-stamp-x86_64-unknown-linux-musl" failed 3 times.
travis_time:end:008aebd8:start=1560266168582463854,finish=1560267292706318734,duration=1124123854880
The command "case "$TRAVIS_OS_NAME" in linux) travis_retry curl -fo $HOME/stamp https://s3-us-west-1.amazonaws.com/rust-lang-ci2/rust-ci-mirror/2017-03-17-stamp-x86_64-unknown-linux-musl && chmod +x $HOME/stamp && export PATH=$PATH:$HOME ;; osx) if [[ "$SCRIPT" == "./x.py dist" ]]; then travis_retry brew update && travis_retry brew install xz && travis_retry brew install swig; fi && travis_retry curl -fo /usr/local/bin/sccache https://s3-us-west-1.amazonaws.com/rust-lang-ci2/rust-ci-mirror/2018-04-02-sccache-x86_64-apple-darwin && chmod +x /usr/local/bin/sccache && travis_retry curl -fo /usr/local/bin/stamp https://s3-us-west-1.amazonaws.com/rust-lang-ci2/rust-ci-mirror/2017-03-17-stamp-x86_64-apple-darwin && chmod +x /usr/local/bin/stamp && travis_retry curl -f http://releases.llvm.org/7.0.0/clang+llvm-7.0.0-x86_64-apple-darwin.tar.xz | tar xJf - && export CC=`pwd`/clang+llvm-7.0.0-x86_64-apple-darwin/bin/clang && export CXX=`pwd`/clang+llvm-7.0.0-x86_64-apple-darwin/bin/clang++ && export AR=ar ;; esac" failed and exited with 56 during .
Your build has been stopped.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

eddyb · 2019-06-11T16:41:31Z

@bors retry (network error?)

bors · 2019-06-11T20:45:27Z

⌛ Testing commit 1d720ec with merge 5f3656c...

@Zoxc

Add deny(unused_lifetimes) to all the crates that have deny(internal). @Zoxc brought up, regarding #61722, that we don't force the removal of unused lifetimes. Turns out that it's not that bad to enable for compiler crates (I wonder why it's not `warn` by default?). I would've liked to enable `single_use_lifetimes` as well, but #53738 makes it unusable for now. For the `rustfmt` commit, I used rust-lang/rustfmt#1324 (comment), and manually filtered out some noise. r? @oli-obk cc @rust-lang/compiler

bors · 2019-06-11T23:29:16Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 5f3656c to master...

rust-highfive · 2019-06-11T23:30:23Z

📣 Toolstate changed by #61735!

Tested on commit 5f3656c.
Direct link to PR: #61735

💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).

@Manishearth

Tested on commit rust-lang/rust@5f3656c. Direct link to PR: <rust-lang/rust#61735> 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).

Remove wrong lifetime from LintContext Rustup rust-lang/rust#61735 changelog: none

@Zoxc

rustc: replace `TyCtxt<'a, 'gcx, 'tcx>` with `TyCtxt<'gcx, 'tcx>`. This first lifetime parameter of `TyCtxt` has been phantom for a while, thanks to @Zoxc, but was never removed, and I'm doing this now in preparation for removing the `'gcx`/`'tcx` split. I wasn't going to do this as a separate step, and instead start converting uses of `TyCtxt` to a single-lifetime alias of it (e.g. `type TyCx<'tcx> = TyCtxt<'tcx, 'tcx, 'tcx>;`) but it turns out (as @Zoxc rightly predicted) that there is far more fallout from not needing a lifetime for the first parameter of `TyCtxt`. That is, going from `TyCtxt<'a, 'gcx, 'tcx>` to `TyCtxt<'tcx, 'gcx, 'tcx>` (the first commit in this PR) has the largest amount of fallout out of all the changes we might make (because it can require removing the `'a` parameter of `struct`s containing `tcx: TyCtxt<'a, ...>`), and is the hardest to automate (because `'a` is used everywhere, not just with `TyCtxt`, unlike, say `'gcx, 'tcx` -> `'tcx`). So I'm submitting this now to get it out of the way and reduce further friction in the future. **EDIT**: for the `rustfmt` commit, I used rust-lang/rustfmt#1324 (comment), and manually filtered out some noise, like in #61735, but unlike that PR, there was also a weird bug to work around. It should be reviewed separately, and dropped if unwanted. cc @rust-lang/compiler r? @nikomatsakis

@Zoxc

Unify all uses of 'gcx and 'tcx. This is made possible by @Zoxc landing #57214 (see #57214 (comment) for the decision). A bit of context for the approach: just like #61722, this is *not* how I originally intended to go about this, but @Zoxc and my own experimentation independently resulted in the same conclusion: The interim alias `type TyCx<'tcx> = TyCtxt<'tcx, 'tcx>;` attempt required more work (adding `use`s), even only for handling the `TyCtxt<'tcx, 'tcx>` case and not the general `TyCtxt<'gcx, 'tcx>` one. What this PR is based on is the realization that `'gcx` is a special-enough name that it can be replaced, without caring for context, with `'tcx`, and then repetitions of the name `'tcx` be compacted away. After that, only a small number of error categories remained, each category easily dealt with with either more mass replacements (e.g. `TyCtxt<'tcx, '_>` -> `TyCtxt<'tcx>`) or by hand. For the `rustfmt` commit, I used rust-lang/rustfmt#1324 (comment), and manually filtered out some noise, like in #61735 and #61722, and like the latter, there was also a weird bug to work around. It should be reviewed separately, and dropped if unwanted (in this PR it's pretty significant). cc @rust-lang/compiler r? @nikomatsakis

@eddyb

Implement another internal lints cc rust-lang#49509 This adds ~~two~~ one internal lint~~s~~: 1. LINT_PASS_IMPL_WITHOUT_MACRO: Make sure, that the `{declare,impl}_lint_pass` macro is used to implement lint passes. cc rust-lang#59669 2. ~~USAGE_OF_TYCTXT_AND_SPAN_ARGS: item 2 on the list in rust-lang#49509~~ ~~With 2. I wasn't sure, if this lint should be applied everywhere. That means a careful review of 0955835 would be great. Also 73fb9b4 allows this lint on some functions. Should I also apply this lint there?~~ TODO (not directly relevant for review): - [ ] rust-lang#59316 (comment) (not sure yet, if this works or how to query for `rustc_private`, since it's not in [`Features`](https://doc.rust-lang.org/nightly/nightly-rustc/syntax/feature_gate/struct.Features.html) 🤔 cc @eddyb) - [x] rust-lang#61735 (comment) - [x] Check explicitly for the `{declare,impl}_lint_pass!` macros r? @oli-obk

@eddyb

Implement another internal lints cc rust-lang#49509 This adds ~~two~~ one internal lint~~s~~: 1. LINT_PASS_IMPL_WITHOUT_MACRO: Make sure, that the `{declare,impl}_lint_pass` macro is used to implement lint passes. cc rust-lang#59669 2. ~~USAGE_OF_TYCTXT_AND_SPAN_ARGS: item 2 on the list in rust-lang#49509~~ ~~With 2. I wasn't sure, if this lint should be applied everywhere. That means a careful review of 0955835 would be great. Also 73fb9b4 allows this lint on some functions. Should I also apply this lint there?~~ TODO (not directly relevant for review): - [ ] rust-lang#59316 (comment) (not sure yet, if this works or how to query for `rustc_private`, since it's not in [`Features`](https://doc.rust-lang.org/nightly/nightly-rustc/syntax/feature_gate/struct.Features.html) 🤔 cc @eddyb) - [x] rust-lang#61735 (comment) - [x] Check explicitly for the `{declare,impl}_lint_pass!` macros r? @oli-obk

@eddyb

Implement another internal lints cc rust-lang#49509 This adds ~~two~~ one internal lint~~s~~: 1. LINT_PASS_IMPL_WITHOUT_MACRO: Make sure, that the `{declare,impl}_lint_pass` macro is used to implement lint passes. cc rust-lang#59669 2. ~~USAGE_OF_TYCTXT_AND_SPAN_ARGS: item 2 on the list in rust-lang#49509~~ ~~With 2. I wasn't sure, if this lint should be applied everywhere. That means a careful review of 0955835 would be great. Also 73fb9b4 allows this lint on some functions. Should I also apply this lint there?~~ TODO (not directly relevant for review): - [ ] rust-lang#59316 (comment) (not sure yet, if this works or how to query for `rustc_private`, since it's not in [`Features`](https://doc.rust-lang.org/nightly/nightly-rustc/syntax/feature_gate/struct.Features.html) 🤔 cc @eddyb) - [x] rust-lang#61735 (comment) - [x] Check explicitly for the `{declare,impl}_lint_pass!` macros r? @oli-obk

rust-highfive assigned oli-obk Jun 11, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2019

oli-obk reviewed Jun 11, 2019

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2019

petrochenkov reviewed Jun 11, 2019

View reviewed changes

Centril reviewed Jun 11, 2019

View reviewed changes

src/librustc/traits/auto_trait.rs Show resolved Hide resolved

src/librustc/ty/layout.rs Show resolved Hide resolved

eddyb added 12 commits June 11, 2019 14:11

rustc_target: deny(unused_lifetimes).

4d426bb

syntax_ext: deny(unused_lifetimes).

ce0ba38

rustc: deny(unused_lifetimes).

774724b

rustc_incremental: deny(unused_lifetimes).

26a0340

rustc_lint: deny(unused_lifetimes).

7dc3494

rustc_mir: deny(unused_lifetimes).

d110d30

rustc_traits: deny(unused_lifetimes).

8dddfde

rustc_borrowck: deny(unused_lifetimes).

7b353f2

rustc_codegen_*: deny(unused_lifetimes).

8ee1814

rustdoc: deny(unused_lifetimes).

4a21968

Add deny(unused_lifetimes) to all the crates that have deny(internal).

630ec88

Run rustfmt --file-lines ... for changes from previous commits.

1d720ec

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 11, 2019

eddyb force-pushed the must-use-life branch from 765fd84 to db09741 Compare June 11, 2019 11:49

This comment has been minimized.

Sign in to view

flip1995 mentioned this pull request Jun 11, 2019

Implement another internal lints #61545

Merged

3 tasks

eddyb force-pushed the must-use-life branch from 6fe0a15 to 1d720ec Compare June 11, 2019 12:24

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 11, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2019

eddyb mentioned this pull request Jun 11, 2019

rustc: replace TyCtxt<'a, 'gcx, 'tcx> with TyCtxt<'gcx, 'tcx>. #61722

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 11, 2019

bors merged commit 1d720ec into rust-lang:master Jun 11, 2019

bors mentioned this pull request Jun 11, 2019

Refactor interning to properly mark memory as mutable or immutable #58351

Merged

3 tasks

bors mentioned this pull request Jun 11, 2019

Remove rustc_mir dependency from rustc_borrowck #61590

Merged

tesuji mentioned this pull request Jun 12, 2019

Remove wrong lifetime from LintContext rust-lang/rust-clippy#4196

Closed

eddyb deleted the must-use-life branch June 12, 2019 03:36

bors added a commit to rust-lang/rust-clippy that referenced this pull request Jun 12, 2019

Auto merge of #4196 - lzutao:unused-lifetime, r=oli-obk

90d932f

Remove wrong lifetime from LintContext Rustup rust-lang/rust#61735 changelog: none

bors added a commit to rust-lang/rust-clippy that referenced this pull request Jun 12, 2019

Auto merge of #4196 - lzutao:unused-lifetime, r=oli-obk

f8300dd

Remove wrong lifetime from LintContext Rustup rust-lang/rust#61735 changelog: none

This was referenced Jun 13, 2019

single_use_lifetimes warns when deriving a struct #53738

Closed

Unify all uses of 'gcx and 'tcx. #61817

Merged

nikomatsakis mentioned this pull request Jun 14, 2019

Transition the compiler arenas #61838

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add deny(unused_lifetimes) to all the crates that have deny(internal). #61735

Add deny(unused_lifetimes) to all the crates that have deny(internal). #61735

eddyb commented Jun 11, 2019

oli-obk Jun 11, 2019

eddyb Jun 11, 2019

oli-obk commented Jun 11, 2019

bors commented Jun 11, 2019

petrochenkov Jun 11, 2019

eddyb Jun 11, 2019

eddyb Jun 11, 2019

petrochenkov Jun 11, 2019

eddyb Jun 11, 2019

petrochenkov Jun 11, 2019

flip1995 Jun 11, 2019

RalfJung Jun 11, 2019

eddyb commented Jun 11, 2019

This comment has been minimized.

This comment has been minimized.

eddyb commented Jun 11, 2019

rust-highfive commented Jun 11, 2019

eddyb commented Jun 11, 2019

bors commented Jun 11, 2019

bors commented Jun 11, 2019

rust-highfive commented Jun 11, 2019

Add deny(unused_lifetimes) to all the crates that have deny(internal). #61735

Add deny(unused_lifetimes) to all the crates that have deny(internal). #61735

Conversation

eddyb commented Jun 11, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oli-obk commented Jun 11, 2019

bors commented Jun 11, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eddyb commented Jun 11, 2019

This comment has been minimized.

This comment has been minimized.

eddyb commented Jun 11, 2019

rust-highfive commented Jun 11, 2019

eddyb commented Jun 11, 2019

bors commented Jun 11, 2019

bors commented Jun 11, 2019

rust-highfive commented Jun 11, 2019