Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate unit tests #61739

Merged
merged 15 commits into from
Jun 16, 2019
Merged

Separate unit tests #61739

merged 15 commits into from
Jun 16, 2019

Conversation

chansuke
Copy link
Contributor

I'm working on #61097.

About half of the modules are done but dozens of modules are still remaining. I will rebase and squash the commits later.

@petrochenkov
Copy link
Contributor

petrochenkov commented Jun 11, 2019

@chansuke
Thanks!

r=me once the rebase is done and CI is green (squashing is usually at the discretion of the author).
Every transitioned test module has an immediate value, I'd personally benefit from libsyntax tests being transitioned y e s t e r d a y.

r? @petrochenkov
@bors p=1 (conflict-prone)
cc @rust-lang/compiler

@Centril
Copy link
Contributor

Centril commented Jun 11, 2019

@bors p=10

More conflict prone than you think.

@petrochenkov petrochenkov added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 11, 2019
@chansuke chansuke changed the title [WIP] Separate unit tests Separate unit tests Jun 15, 2019
@chansuke
Copy link
Contributor Author

@petrochenkov Sorry for the late reply and thanks for the information (and aboutlibsyntax too). I will handle that, and yes, I will r=you after that.

@chansuke chansuke force-pushed the separate-unit-tests branch 3 times, most recently from 6762543 to 7c6e5e7 Compare June 16, 2019 04:33
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:09add028:start=1560659681254526332,finish=1560659683384089924,duration=2129563592
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---

[00:04:35] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:36] tidy error: /checkout/src/librustc/session/config/mod.rs: ignoring file length unnecessarily
[00:04:36] tidy error: /checkout/src/librustdoc/html/markdown/mod.rs:58: line longer than 100 chars
[00:04:36] tidy error: /checkout/src/librustdoc/html/markdown/mod.rs:61: line longer than 100 chars
[00:04:40] some tidy checks failed
[00:04:40] 
[00:04:40] 
[00:04:40] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:40] 
[00:04:40] 
[00:04:40] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:40] Build completed unsuccessfully in 0:01:11
---
travis_time:end:06f78912:start=1560659975883524854,finish=1560659975888238408,duration=4713554
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:08596afa
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0fae3122
travis_time:start:0fae3122
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:00c36868
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@petrochenkov
Copy link
Contributor

@chansuke
I've rebased this, fixed tidy issues and currently running testing.
I'll push to this PR and r+ after the testing is complete.

General hint for the following PRs - instead of

foo.rs

=>

foo/mod.rs
foo/tests.rs

you can use

foo.rs

=>

foo.rs
foo/tests.rs

This way you can avoid most of conflicts and won't have to rebase all the time.

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jun 16, 2019

📌 Commit 5a9643c has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 16, 2019
@bors
Copy link
Contributor

bors commented Jun 16, 2019

⌛ Testing commit 5a9643c with merge 37b6a5e...

bors added a commit that referenced this pull request Jun 16, 2019
Separate unit tests

I'm working on #61097.

About half of the modules are done but dozens of modules are still remaining. I will rebase and squash the commits later.
@bors
Copy link
Contributor

bors commented Jun 16, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: petrochenkov
Pushing 37b6a5e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 16, 2019
@bors bors merged commit 5a9643c into rust-lang:master Jun 16, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #61739!

Tested on commit 37b6a5e.
Direct link to PR: #61739

🎉 rls on windows: test-fail → test-pass (cc @Xanewok, @rust-lang/infra).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants