-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #62041
Rollup of 9 pull requests #62041
Commits on May 25, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 3dd114e - Browse repository at this point
Copy the full SHA 3dd114eView commit details
Commits on May 28, 2019
-
Configuration menu - View commit details
-
Copy full SHA for f65b6a8 - Browse repository at this point
Copy the full SHA f65b6a8View commit details
Commits on Jun 9, 2019
-
Changed the error message to more clearly explain what is allowed
Andrew committedJun 9, 2019 Configuration menu - View commit details
-
Copy full SHA for cf5df27 - Browse repository at this point
Copy the full SHA cf5df27View commit details -
changed the language of the error message to make it more clear
Andrew committedJun 9, 2019 Configuration menu - View commit details
-
Copy full SHA for 4e9615d - Browse repository at this point
Copy the full SHA 4e9615dView commit details
Commits on Jun 20, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 4410916 - Browse repository at this point
Copy the full SHA 4410916View commit details -
Configuration menu - View commit details
-
Copy full SHA for b710e08 - Browse repository at this point
Copy the full SHA b710e08View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6eb392 - Browse repository at this point
Copy the full SHA f6eb392View commit details -
Configuration menu - View commit details
-
Copy full SHA for 468647c - Browse repository at this point
Copy the full SHA 468647cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98cc18a - Browse repository at this point
Copy the full SHA 98cc18aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ed7585 - Browse repository at this point
Copy the full SHA 3ed7585View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21e63dd - Browse repository at this point
Copy the full SHA 21e63ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d1e223 - Browse repository at this point
Copy the full SHA 2d1e223View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe044a8 - Browse repository at this point
Copy the full SHA fe044a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae72c91 - Browse repository at this point
Copy the full SHA ae72c91View commit details -
Configuration menu - View commit details
-
Copy full SHA for a64456e - Browse repository at this point
Copy the full SHA a64456eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 73cb9ab - Browse repository at this point
Copy the full SHA 73cb9abView commit details -
Configuration menu - View commit details
-
Copy full SHA for cfd754d - Browse repository at this point
Copy the full SHA cfd754dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 165a95b - Browse repository at this point
Copy the full SHA 165a95bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 640bdbd - Browse repository at this point
Copy the full SHA 640bdbdView commit details
Commits on Jun 21, 2019
-
Configuration menu - View commit details
-
Copy full SHA for b4c73a2 - Browse repository at this point
Copy the full SHA b4c73a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a511cc - Browse repository at this point
Copy the full SHA 0a511ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d67510 - Browse repository at this point
Copy the full SHA 0d67510View commit details -
Configuration menu - View commit details
-
Copy full SHA for 004efa2 - Browse repository at this point
Copy the full SHA 004efa2View commit details -
* Move fs::create_dir_all calls into DocFS to provide a clean extension point if async extension there is needed. * Convert callsites of create_dir_all to ensure_dir to reduce syscalls. * Convert fs::write usage to DocFS.write (which also removes a lot of try_err! usage for easier reading) * Convert File::create calls to use Vec buffers and then DocFS.write in order to consistently reduce syscalls as well, make deferring to threads cleaner and avoid leaving dangling content if writing to existing files.... * Convert OpenOptions usage similarly - I could find no discussion on the use of create_new for that one output file vs all the other files render creates, if link redirection attacks are a concern DocFS will provide a good central point to introduce systematic create_new usage. (fs::write/File::create is vulnerable to link redirection attacks). * DocFS::write defers to rayon for IO on Windows producing a modest speedup: before this patch on my development workstation: $ time cargo +mystg1 doc -p winapi:0.3.7 Documenting winapi v0.3.7 Finished dev [unoptimized + debuginfo] target(s) in 6m 11s real 6m11.734s Afterwards: $ time cargo +mystg1 doc -p winapi:0.3.7 Compiling winapi v0.3.7 Documenting winapi v0.3.7 Finished dev [unoptimized + debuginfo] target(s) in 49.53s real 0m49.643s I haven't measured how much time is in the compilation logic vs in the IO and outputting etc, but this takes it from frustating to tolerable for me, at least for now.
Configuration menu - View commit details
-
Copy full SHA for 6392bc9 - Browse repository at this point
Copy the full SHA 6392bc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3eeb543 - Browse repository at this point
Copy the full SHA 3eeb543View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65f1295 - Browse repository at this point
Copy the full SHA 65f1295View commit details -
changed expected output in tests so it now passes with changed output
Andrew committedJun 21, 2019 Configuration menu - View commit details
-
Copy full SHA for 54acbd9 - Browse repository at this point
Copy the full SHA 54acbd9View commit details -
adding in these files that didn't get added in previous commit
Andrew committedJun 21, 2019 Configuration menu - View commit details
-
Copy full SHA for f4cd3c2 - Browse repository at this point
Copy the full SHA f4cd3c2View commit details -
Rollup merge of rust-lang#60971 - rbtcollins:docs-perf, r=rbtcollins,…
…GuillaumeGomez Add DocFS layer to rustdoc * Move fs::create_dir_all calls into DocFS to provide a clean extension point if async extension there is needed. * Convert callsites of create_dir_all to ensure_dir to reduce syscalls. * Convert fs::write usage to DocFS.write (which also removes a lot of try_err! usage for easier reading) * Convert File::create calls to use Vec buffers and then DocFS.write in order to both consistently reduce syscalls as well as make deferring to threads cleaner. * Convert OpenOptions usage similarly - I could find no discussion on the use of create_new for that one output file vs all the other files render creates, if link redirection attacks are a concern DocFS will provide a good central point to introduce systematic create_new usage. * DocFS::write defers to rayon for IO on Windows producing a modest speedup: before this patch on my development workstation: $ time cargo +mystg1 doc -p winapi:0.3.7 Documenting winapi v0.3.7 Finished dev [unoptimized + debuginfo] target(s) in 6m 11s real 6m11.734s user 0m0.015s sys 0m0.000s Afterwards: $ time cargo +mystg1 doc -p winapi:0.3.7 Compiling winapi v0.3.7 Documenting winapi v0.3.7 Finished dev [unoptimized + debuginfo] target(s) in 49.53s real 0m49.643s user 0m0.000s sys 0m0.015s I haven't measured how much time is in the compilation logic vs in the IO and outputting etc, but this takes it from frustating to tolerable for me, at least for now.
Configuration menu - View commit details
-
Copy full SHA for f2a0ce9 - Browse repository at this point
Copy the full SHA f2a0ce9View commit details -
Rollup merge of rust-lang#61146 - czipperz:SliceConcatExt-connect-def…
…ault-to-join, r=sfackler SliceConcatExt::connect defaults to calling join It makes sense to default a deprecated method to the new one. Precedence example is `Error::cause` defaults to calling `Error::source`.
Configuration menu - View commit details
-
Copy full SHA for 3a8536e - Browse repository at this point
Copy the full SHA 3a8536eView commit details -
Rollup merge of rust-lang#61181 - GuillaumeGomez:fix-theme-checker, r…
…=kinnison Fix theme-checker failure Fixes rust-lang#61145. I didn't find a way to check it without strongly depending on the output... Is there a way to check if a program fails without checking its output? r? @QuietMisdreavus
Configuration menu - View commit details
-
Copy full SHA for 18bb754 - Browse repository at this point
Copy the full SHA 18bb754View commit details -
Rollup merge of rust-lang#61267 - michaelwoerister:update-xlto-table,…
… r=alexcrichton rustc-book: Update the rustc/clang compatibility table for xLTO. Firefox is using these combinations successfully.
Configuration menu - View commit details
-
Copy full SHA for 653b44d - Browse repository at this point
Copy the full SHA 653b44dView commit details -
Rollup merge of rust-lang#61270 - michaelwoerister:remove-incr-comp-w…
…arning, r=oli-obk Remove warnings about incr. comp. generating less debugging output. This PR removes the > `-C save-temps` might not produce all requested temporary products when incremental compilation is enabled.` warning and others similar to it. I think these warnings have annoyed lots of people over the past ~3 years; while not helping a single one of them `:P` r? @oli-obk
Configuration menu - View commit details
-
Copy full SHA for c3c3a5e - Browse repository at this point
Copy the full SHA c3c3a5eView commit details -
Rollup merge of rust-lang#61681 - asfreitas:addSendTrait, r=estebank
Changed the error message to more clearly explain what is allowed This is in regard to rust-lang#61634. I changed the language to make it more clear what is allowed.
Configuration menu - View commit details
-
Copy full SHA for 9eb88f3 - Browse repository at this point
Copy the full SHA 9eb88f3View commit details -
Rollup merge of rust-lang#61984 - ljedrz:more_node_id_pruning, r=Zoxc
More NodeId pruning Just another round of the `HirId`ification initiative. r? @Zoxc
Configuration menu - View commit details
-
Copy full SHA for dc0ef82 - Browse repository at this point
Copy the full SHA dc0ef82View commit details -
Rollup merge of rust-lang#62016 - JohnTitor:add-test-for-issue-27697,…
… r=alexcrichton Add test for issue-27697 Closes rust-lang#27697
Configuration menu - View commit details
-
Copy full SHA for 595f55c - Browse repository at this point
Copy the full SHA 595f55cView commit details -
Rollup merge of rust-lang#62019 - jeremystucki:refactoring, r=estebank
Remove needless lifetimes
Configuration menu - View commit details
-
Copy full SHA for 64e5818 - Browse repository at this point
Copy the full SHA 64e5818View commit details