Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #62041

Merged
merged 37 commits into from
Jun 22, 2019
Merged

Rollup of 9 pull requests #62041

merged 37 commits into from
Jun 22, 2019

Commits on May 25, 2019

  1. Configuration menu
    Copy the full SHA
    3dd114e View commit details
    Browse the repository at this point in the history

Commits on May 28, 2019

  1. Configuration menu
    Copy the full SHA
    f65b6a8 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2019

  1. Configuration menu
    Copy the full SHA
    cf5df27 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4e9615d View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2019

  1. Configuration menu
    Copy the full SHA
    4410916 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b710e08 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f6eb392 View commit details
    Browse the repository at this point in the history
  4. remove hir::map::name

    ljedrz committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    468647c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    98cc18a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3ed7585 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    21e63dd View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2d1e223 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    fe044a8 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    ae72c91 View commit details
    Browse the repository at this point in the history
  11. remove hir::map::get

    ljedrz committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    a64456e View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    73cb9ab View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    cfd754d View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    165a95b View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    640bdbd View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2019

  1. Add test for issue-27697

    JohnTitor committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    b4c73a2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0a511cc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0d67510 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    004efa2 View commit details
    Browse the repository at this point in the history
  5. Add DocFS layer to rustdoc

    * Move fs::create_dir_all calls into DocFS to provide a clean
      extension point if async extension there is needed.
    * Convert callsites of create_dir_all to ensure_dir to reduce syscalls.
    * Convert fs::write usage to DocFS.write
      (which also removes a lot of try_err! usage for easier reading)
    * Convert File::create calls to use Vec buffers and then DocFS.write
      in order to consistently reduce syscalls as well, make
      deferring to threads cleaner and avoid leaving dangling content if
      writing to existing files....
    * Convert OpenOptions usage similarly - I could find no discussion on
      the use of create_new for that one output file vs all the other
      files render creates, if link redirection attacks are a concern
      DocFS will provide a good central point to introduce systematic
      create_new usage. (fs::write/File::create is vulnerable to link
      redirection attacks).
    * DocFS::write defers to rayon for IO on Windows producing a modest
      speedup: before this patch on my development workstation:
    
    $ time cargo +mystg1 doc -p winapi:0.3.7
     Documenting winapi v0.3.7
        Finished dev [unoptimized + debuginfo] target(s) in 6m 11s
    
    real    6m11.734s
    
    Afterwards:
    $ time cargo +mystg1 doc -p winapi:0.3.7
       Compiling winapi v0.3.7
     Documenting winapi v0.3.7
        Finished dev [unoptimized + debuginfo] target(s) in 49.53s
    
    real    0m49.643s
    
    I haven't measured how much time is in the compilation logic vs in the
    IO and outputting etc, but this takes it from frustating to tolerable
    for me, at least for now.
    rbtcollins authored and GuillaumeGomez committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    6392bc9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3eeb543 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    65f1295 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    54acbd9 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f4cd3c2 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#60971 - rbtcollins:docs-perf, r=rbtcollins,…

    …GuillaumeGomez
    
    Add DocFS layer to rustdoc
    
    * Move fs::create_dir_all calls into DocFS to provide a clean
      extension point if async extension there is needed.
    * Convert callsites of create_dir_all to ensure_dir to reduce syscalls.
    * Convert fs::write usage to DocFS.write
      (which also removes a lot of try_err! usage for easier reading)
    * Convert File::create calls to use Vec buffers and then DocFS.write
      in order to both consistently reduce syscalls as well as make
      deferring to threads cleaner.
    * Convert OpenOptions usage similarly - I could find no discussion on
      the use of create_new for that one output file vs all the other
      files render creates, if link redirection attacks are a concern
      DocFS will provide a good central point to introduce systematic
      create_new usage.
    * DocFS::write defers to rayon for IO on Windows producing a modest
      speedup: before this patch on my development workstation:
    
    $ time cargo +mystg1 doc -p winapi:0.3.7
     Documenting winapi v0.3.7
        Finished dev [unoptimized + debuginfo] target(s) in 6m 11s
    
    real    6m11.734s
    user    0m0.015s
    sys     0m0.000s
    
    Afterwards:
    $ time cargo +mystg1 doc -p winapi:0.3.7
       Compiling winapi v0.3.7
     Documenting winapi v0.3.7
        Finished dev [unoptimized + debuginfo] target(s) in 49.53s
    
    real    0m49.643s
    user    0m0.000s
    sys     0m0.015s
    
    I haven't measured how much time is in the compilation logic vs in the
    IO and outputting etc, but this takes it from frustating to tolerable
    for me, at least for now.
    Centril committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    f2a0ce9 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#61146 - czipperz:SliceConcatExt-connect-def…

    …ault-to-join, r=sfackler
    
    SliceConcatExt::connect defaults to calling join
    
    It makes sense to default a deprecated method to the new one.  Precedence example is `Error::cause` defaults to calling `Error::source`.
    Centril committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    3a8536e View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#61181 - GuillaumeGomez:fix-theme-checker, r…

    …=kinnison
    
    Fix theme-checker failure
    
    Fixes rust-lang#61145.
    
    I didn't find a way to check it without strongly depending on the output... Is there a way to check if a program fails without checking its output?
    
    r? @QuietMisdreavus
    Centril committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    18bb754 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#61267 - michaelwoerister:update-xlto-table,…

    … r=alexcrichton
    
    rustc-book: Update the rustc/clang compatibility table for xLTO.
    
    Firefox is using these combinations successfully.
    Centril committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    653b44d View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#61270 - michaelwoerister:remove-incr-comp-w…

    …arning, r=oli-obk
    
    Remove warnings about incr. comp. generating less debugging output.
    
    This PR removes the
    
    > `-C save-temps` might not produce all requested temporary products when incremental compilation is enabled.`
    
    warning and others similar to it.
    
    I think these warnings have annoyed lots of people over the past ~3 years; while not helping a single one of them `:P`
    
    r? @oli-obk
    Centril committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    c3c3a5e View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#61681 - asfreitas:addSendTrait, r=estebank

    Changed the error message to more clearly explain what is allowed
    
    This is in regard to rust-lang#61634. I changed the language to make it more clear what is allowed.
    Centril committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    9eb88f3 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#61984 - ljedrz:more_node_id_pruning, r=Zoxc

    More NodeId pruning
    
    Just another round of the `HirId`ification initiative.
    
    r? @Zoxc
    Centril committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    dc0ef82 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#62016 - JohnTitor:add-test-for-issue-27697,…

    … r=alexcrichton
    
    Add test for issue-27697
    
    Closes rust-lang#27697
    Centril committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    595f55c View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#62019 - jeremystucki:refactoring, r=estebank

    Remove needless lifetimes
    Centril committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    64e5818 View commit details
    Browse the repository at this point in the history