Extend the #[must_use] lint to boxed types #62228

varkor · 2019-06-29T12:54:34Z

This should have been included as part of #55663, but was overlooked.

rust-highfive · 2019-06-29T12:54:44Z

(rust_highfive has picked a reviewer for you, use r? to override)

Centril · 2019-06-29T13:22:21Z

r=me with some more tests for interactions with combinations, e.g tuples and whatnot. Testing Box<Box<dyn MustUse>> would also be good.

varkor · 2019-06-29T14:02:30Z

@bors r=Centril

bors · 2019-06-29T14:02:32Z

📌 Commit 238bf81 has been approved by Centril

@Nemo157

…tril Extend the #[must_use] lint to boxed types Fixes rust-lang#55506 (comment) (cc @Nemo157). This should have been included as part of rust-lang#55663, but was overlooked.

Centril · 2019-06-29T15:31:06Z

@bors r- due to failure.

Centril · 2019-06-29T15:53:34Z

r=me rollup again when CI is happy.

varkor · 2019-06-29T19:43:09Z

@bors r=Centril rollup

bors · 2019-06-29T19:43:10Z

📌 Commit 1424a6b has been approved by Centril

@Centril

…entril Extend the `#[must_use]` lint to arrays Based on top of rust-lang#62228. r? @Centril

After rust-lang/rust#62228, this will be linted against (and causes the test to fail).

Fix `unused_must_use` inside `Box` After rust-lang/rust#62228, this will be linted against (and causes the test to fail). (This blocks rust-lang/rust#62228.)

varkor · 2019-06-30T17:20:24Z

@bors r=Centril rollup

bors · 2019-06-30T17:20:25Z

📌 Commit 400fd60 has been approved by Centril

@Nemo157

…tril Extend the #[must_use] lint to boxed types Fixes rust-lang#55506 (comment) (cc @Nemo157). This should have been included as part of rust-lang#55663, but was overlooked.

@Centril

…entril Extend the `#[must_use]` lint to arrays Based on top of rust-lang#62228. r? @Centril

@ghost

Rollup of 8 pull requests Successful merges: - #62062 (Use a more efficient iteration order for forward dataflow) - #62063 (Use a more efficient iteration order for backward dataflow) - #62224 (rustdoc: remove unused derives and variants) - #62228 (Extend the #[must_use] lint to boxed types) - #62235 (Extend the `#[must_use]` lint to arrays) - #62239 (Fix a typo) - #62241 (Always parse 'async unsafe fn' + properly ban in 2015) - #62248 (before_exec actually will only get deprecated with 1.37) Failed merges: r? @ghost

Pkgsrc changes: * Add a patch to llvm to deal with const dli_saddr. * Adapt two other patches. * Cross-build currently fails, so i386, powerpc and sparc64 bootstrap kits for 1.37.0 are built natively. Missing aarch64 hardware, so that's not available yet. * Bump bootstrap requirements to 1.36.0 except for armv7-unknown-netbsd-eabihf which I've not managed to cross-build. Upstream changes: Version 1.37.0 (2019-08-15) ========================== Language -------- - `#[must_use]` will now warn if the type is contained in a [tuple][61100], [`Box`][62228], or an [array][62235] and unused. - [You can now use the `cfg` and `cfg_attr` attributes on generic parameters.][61547] - [You can now use enum variants through type alias.][61682] e.g. You can write the following: ```rust type MyOption = Option<u8>; fn increment_or_zero(x: MyOption) -> u8 { match x { MyOption::Some(y) => y + 1, MyOption::None => 0, } } ``` - [You can now use `_` as an identifier for consts.][61347] e.g. You can write `const _: u32 = 5;`. - [You can now use `#[repr(align(X)]` on enums.][61229] - [The `?`/_"Kleene"_ macro operator is now available in the 2015 edition.][60932] Compiler -------- - [You can now enable Profile-Guided Optimization with the `-C profile-generate` and `-C profile-use` flags.][61268] For more information on how to use profile guided optimization, please refer to the [rustc book][rustc-book-pgo]. - [The `rust-lldb` wrapper script should now work again.][61827] Libraries --------- - [`mem::MaybeUninit<T>` is now ABI-compatible with `T`.][61802] Stabilized APIs --------------- - [`BufReader::buffer`] - [`BufWriter::buffer`] - [`Cell::from_mut`] - [`Cell<[T]>::as_slice_of_cells`][`Cell<slice>::as_slice_of_cells`] - [`DoubleEndedIterator::nth_back`] - [`Option::xor`] - [`Wrapping::reverse_bits`] - [`i128::reverse_bits`] - [`i16::reverse_bits`] - [`i32::reverse_bits`] - [`i64::reverse_bits`] - [`i8::reverse_bits`] - [`isize::reverse_bits`] - [`slice::copy_within`] - [`u128::reverse_bits`] - [`u16::reverse_bits`] - [`u32::reverse_bits`] - [`u64::reverse_bits`] - [`u8::reverse_bits`] - [`usize::reverse_bits`] Cargo ----- - [`Cargo.lock` files are now included by default when publishing executable crates with executables.][cargo/7026] - [You can now specify `default-run="foo"` in `[package]` to specify the default executable to use for `cargo run`.][cargo/7056] Misc ---- Compatibility Notes ------------------- - [Using `...` for inclusive range patterns will now warn by default.][61342] Please transition your code to using the `..=` syntax for inclusive ranges instead. - [Using a trait object without the `dyn` will now warn by default.][61203] Please transition your code to use `dyn Trait` for trait objects instead. [62228]: rust-lang/rust#62228 [62235]: rust-lang/rust#62235 [61802]: rust-lang/rust#61802 [61827]: rust-lang/rust#61827 [61547]: rust-lang/rust#61547 [61682]: rust-lang/rust#61682 [61268]: rust-lang/rust#61268 [61342]: rust-lang/rust#61342 [61347]: rust-lang/rust#61347 [61100]: rust-lang/rust#61100 [61203]: rust-lang/rust#61203 [61229]: rust-lang/rust#61229 [60932]: rust-lang/rust#60932 [cargo/7026]: rust-lang/cargo#7026 [cargo/7056]: rust-lang/cargo#7056 [`BufReader::buffer`]: https://doc.rust-lang.org/std/io/struct.BufReader.html#method.buffer [`BufWriter::buffer`]: https://doc.rust-lang.org/std/io/struct.BufWriter.html#method.buffer [`Cell::from_mut`]: https://doc.rust-lang.org/std/cell/struct.Cell.html#method.from_mut [`Cell<slice>::as_slice_of_cells`]: https://doc.rust-lang.org/std/cell/struct.Cell.html#method.as_slice_of_cells [`DoubleEndedIterator::nth_back`]: https://doc.rust-lang.org/std/iter/trait.DoubleEndedIterator.html#method.nth_back [`Option::xor`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.xor [`RefCell::try_borrow_unguarded`]: https://doc.rust-lang.org/std/cell/struct.RefCell.html#method.try_borrow_unguarded [`Wrapping::reverse_bits`]: https://doc.rust-lang.org/std/num/struct.Wrapping.html#method.reverse_bits [`i128::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i128.html#method.reverse_bits [`i16::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i16.html#method.reverse_bits [`i32::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i32.html#method.reverse_bits [`i64::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i64.html#method.reverse_bits [`i8::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i8.html#method.reverse_bits [`isize::reverse_bits`]: https://doc.rust-lang.org/std/primitive.isize.html#method.reverse_bits [`slice::copy_within`]: https://doc.rust-lang.org/std/primitive.slice.html#method.copy_within [`u128::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u128.html#method.reverse_bits [`u16::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u16.html#method.reverse_bits [`u32::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u32.html#method.reverse_bits [`u64::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u64.html#method.reverse_bits [`u8::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u8.html#method.reverse_bits [`usize::reverse_bits`]: https://doc.rust-lang.org/std/primitive.usize.html#method.reverse_bits [rustc-book-pgo]: https://doc.rust-lang.org/rustc/profile-guided-optimization.html

rust-highfive assigned oli-obk Jun 29, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 29, 2019

rust-highfive assigned Centril and unassigned oli-obk Jun 29, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2019

Centril mentioned this pull request Jun 29, 2019

Rollup of 5 pull requests #62234

Closed

varkor mentioned this pull request Jun 29, 2019

Extend the #[must_use] lint to arrays #62235

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 29, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 29, 2019

Centril added a commit to Centril/rust that referenced this pull request Jun 29, 2019

Rollup merge of rust-lang#62235 - varkor:must_use-adt-components, r=C…

eedbfc0

…entril Extend the `#[must_use]` lint to arrays Based on top of rust-lang#62228. r? @Centril

varkor added a commit to varkor/miri that referenced this pull request Jun 30, 2019

Fix unused_must_use inside Box

5d4aae8

After rust-lang/rust#62228, this will be linted against (and causes the test to fail).

varkor mentioned this pull request Jun 30, 2019

Fix unused_must_use inside Box rust-lang/miri#806

Merged

varkor added 4 commits June 30, 2019 18:19

Extend the #[must_use] lint to boxed types

b613ef1

Improve error messages for boxed trait objects in tuples

d066f19

Fix run-pass tests

75f31e7

Update miri

400fd60

varkor force-pushed the must_use-trait-in-box branch from 1424a6b to 400fd60 Compare June 30, 2019 17:19

Centril added a commit to Centril/rust that referenced this pull request Jun 30, 2019

Rollup merge of rust-lang#62235 - varkor:must_use-adt-components, r=C…

2b313b1

…entril Extend the `#[must_use]` lint to arrays Based on top of rust-lang#62228. r? @Centril

Centril mentioned this pull request Jun 30, 2019

Rollup of 8 pull requests #62253

Merged

bors merged commit 400fd60 into rust-lang:master Jul 1, 2019

Centril added relnotes Marks issues that should be documented in the release notes of the next release. T-lang Relevant to the language team, which will review and decide on the PR/issue. labels Jul 1, 2019

Centril added this to the 1.37 milestone Jul 1, 2019

jebrosen mentioned this pull request Dec 18, 2019

(request) Extend #[must_use] to Pin #67387

Closed

varkor deleted the must_use-trait-in-box branch January 10, 2020 13:19

KarelPeeters mentioned this pull request Sep 24, 2022

#[must_use] on traits should apply to all types that implement the trait, not just for impl Trait placeholders #102238

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend the #[must_use] lint to boxed types #62228

Extend the #[must_use] lint to boxed types #62228

varkor commented Jun 29, 2019 •

edited

Loading

rust-highfive commented Jun 29, 2019

Centril commented Jun 29, 2019

varkor commented Jun 29, 2019

bors commented Jun 29, 2019

Centril commented Jun 29, 2019

Centril commented Jun 29, 2019

varkor commented Jun 29, 2019

bors commented Jun 29, 2019

varkor commented Jun 30, 2019

bors commented Jun 30, 2019

Extend the #[must_use] lint to boxed types #62228

Extend the #[must_use] lint to boxed types #62228

Conversation

varkor commented Jun 29, 2019 • edited Loading

rust-highfive commented Jun 29, 2019

Centril commented Jun 29, 2019

varkor commented Jun 29, 2019

bors commented Jun 29, 2019

Centril commented Jun 29, 2019

Centril commented Jun 29, 2019

varkor commented Jun 29, 2019

bors commented Jun 29, 2019

varkor commented Jun 30, 2019

bors commented Jun 30, 2019

varkor commented Jun 29, 2019 •

edited

Loading