-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move async-await tests from run-pass to ui #62270
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@bors r+ |
📌 Commit c1471bfb04e51b0295b355c9c59d5f514cbcc35b has been approved by |
☔ The latest upstream changes (presumably #62407) made this pull request unmergeable. Please resolve the merge conflicts. |
The auxiliary file arc_wake.rs is in run-pass/auxiliary and also ui/async-await/auxiliary. Remove the former one as their contents are same. Move run-pass/futures-api.rs to ui/async-await/futures-api.rs as it needs to use arc_wake.rs.
Thanks! @bors r+ rollup |
📌 Commit f115147 has been approved by |
Move async-await tests from run-pass to ui fix rust-lang#62236 r? @Centril
Rollup of 4 pull requests [2] Successful merges: - rust-lang#59800 (rustc: Remove `dylib` crate type from most rustc crates) - rust-lang#60081 (Refactor unicode.py script) - rust-lang#62270 (Move async-await tests from run-pass to ui) - rust-lang#62281 (Add support for pc-relative addressing on 64-bit RISC-V) Failed merges: r? @ghost
Move async-await tests from run-pass to ui fix rust-lang#62236 r? @Centril
Failed in #62448 (comment), @bors r- @tmandry Something fishy is going on tho..
|
@Centril Yeah I'm able to reproduce, trying to figure out how to debug wasm currently... |
FWIW I was able to reproduce as well, see some discussion/history on Zulip. This snippet makes the test run fine on wasm I believe, so we probably just want to ignore the test (it looks like the sizes for wasm are different, probably due to some underlying struct -- here is a diff of assert_eq!(1028, std::mem::size_of_val(&single()));
assert_eq!(1028, std::mem::size_of_val(&single_with_noop()));
assert_eq!(3080, std::mem::size_of_val(&joined()));
assert_eq!(3080, std::mem::size_of_val(&joined_with_noop())); |
r? @tmandry |
@agnxy The tests should pass with my suggestion applied. |
The sizes for wasm are different. Co-Authored-By: Tyler Mandry <tmandry@gmail.com>
Thanks a lot @tmandry and @Mark-Simulacrum I'm reading the zulip topic to learn about wasm. |
@bors r=Centril,tmandry |
📌 Commit 128143c has been approved by |
…andry Move async-await tests from run-pass to ui fix rust-lang#62236 r? @Centril
Rollup of 7 pull requests Successful merges: - #61665 (core: check for pointer equality when comparing Eq slices) - #61923 (Prerequisites from dep graph refactoring #2) - #62270 (Move async-await tests from run-pass to ui) - #62425 (filedesc: don't use ioctl(FIOCLEX) on Linux) - #62476 (Continue refactoring macro expansion and resolution) - #62519 (Regression test for HRTB bug (issue 30786).) - #62557 (Fix typo in libcore/intrinsics.rs) Failed merges: r? @ghost
fix #62236
r? @Centril