Rollup of 14 pull requests #62704
Merged
Rollup of 14 pull requests #62704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the explicitly given type of a `self` parameter fails to parse correctly, we need to propagate the error rather than dropping it and causing an ICE. Fixes rust-lang#62660.
Previously, this callback was never actually called.
poiner -> pointer
Add debug assertions to write_bytes and copy* Looks like @nitnelave went MIA in rust-lang#58783, so I am re-submitting their PR, tweaked just a bit. I took care to preserve commit authorship. Cc rust-lang#53871
Remove never_type feature requirement for exhaustive patterns I **think** this resolves rust-lang#51221 At least for me, it doesn't ICE anymore and all tests are still passing, so LGTM
…ion, r=QuietMisdreavus Fix Pin urls in Option documentation Fixes the following situation:  r? @QuietMisdreavus
…eallocInPlace, r=QuietMisdreavus Add missing links for CannotReallocInPlace type r? @QuietMisdreavus
Less unsafe in the array example of MaybeUninit docs I believe this is an acceptable way to initialize elements of `[MaybeUninit<T>; _]` arrays. Miri agrees. Conceptually, we are working at the array level, above the `MaybeUninit`, and as we are replacing it wholesale, this should pose no problem to soundness. And the code is easier to read. r? @RalfJung
Make VaListImpl<'f> invariant over the 'f lifetime After doing some research on variance and going back to look at `VaList` and `VaListImpl`, I realized that `VaList<'a, 'f>` is invariant over the `'f` lifetime (and covariant over `'a`), but `VaListImpl<'f>` isn't invariant but probably should be. This patch makes `VaListImpl<'f>` invariant over `'f`. r? @eddyb cc @dlrobertson
Tweak wording in feature gate errors
add spaces in front of trait requirements in libcore/cell.rs Adds spaces before trait requirements in `libcore/cell.rs`.
Fix rust-lang#62660 If the explicitly given type of a `self` parameter fails to parse correctly, we need to propagate the error rather than dropping it and causing an ICE. Fixes rust-lang#62660.
miri validation: better error messages for dangling references Cc @oli-obk
…-consumer, r=matthewjasper Actually call `visit_block_entry` in `DataflowResultsConsumer` This fixes a trivial bug in `DataflowResultsConsumer`: `visit_block_entry` is never called when visiting dataflow results. A previous version of rust-lang#62547 used this API and included this fix, but it has since switched to `DataflowResultsCursor` making this commit irrelevant.
…tebank Add info about undefined behavior to as_ref suggestions Fixes rust-lang#61786. A very small fix, but suggestions on wording/content are welcomed.
Fix typo in RawWaker::new documentation poiner -> pointer
…crichton SGX target: don't pretend to be GNU/Linux to LLVM See rust-lang#62592 & rust-lang/compiler-builtins#303 r? @alexcrichton
|
@bors r+ p=1 |
|
📌 Commit da0c8fe has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 16, 2019
Rollup of 14 pull requests Successful merges: - #62103 (Add debug assertions to write_bytes and copy*) - #62405 (Remove never_type feature requirement for exhaustive patterns) - #62491 (Fix Pin urls in Option documentation) - #62533 (Add missing links for CannotReallocInPlace type) - #62634 (Less unsafe in the array example of MaybeUninit docs) - #62639 (Make VaListImpl<'f> invariant over the 'f lifetime) - #62646 (Tweak wording in feature gate errors) - #62662 (add spaces in front of trait requirements in libcore/cell.rs) - #62668 (Fix #62660) - #62673 (miri validation: better error messages for dangling references) - #62680 (Actually call `visit_block_entry` in `DataflowResultsConsumer`) - #62685 (Add info about undefined behavior to as_ref suggestions) - #62689 (Fix typo in RawWaker::new documentation) - #62698 (SGX target: don't pretend to be GNU/Linux to LLVM) Failed merges: r? @ghost
|
☀️ Test successful - checks-azure |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jul 16, 2019
Tested on commit rust-lang/rust@02785da. Direct link to PR: <rust-lang/rust#62704> 💔 miri on windows: test-pass → test-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra). 💔 miri on linux: test-pass → test-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
This was referenced Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
visit_block_entryinDataflowResultsConsumer#62680 (Actually callvisit_block_entryinDataflowResultsConsumer)Failed merges:
r? @ghost