Rollup of 15 pull requests #62782

Mark-Simulacrum · 2019-07-18T15:30:00Z

Successful merges:

Fix hyperlinks in From impls between Vec and VecDeque #61926 (Fix hyperlinks in From impls between Vec and VecDeque)
Only error about MSVC + PGO + unwind if we're generating code #62615 ( Only error about MSVC + PGO + unwind if we're generating code)
Check that trait is exported or public before adding hint #62696 (Check that trait is exported or public before adding hint)
Update the help message on error for self type #62712 (Update the help message on error for self type)
Fix repeated wording in slice documentation #62728 (Fix repeated wording in slice documentation)
Consolidate hygiene tests #62730 (Consolidate hygiene tests)
Remove last use of mem::uninitialized from std::io::util #62732 (Remove last use of mem::uninitialized from std::io::util)
Add missing link to Infallible in TryFrom doc #62740 (Add missing link to Infallible in TryFrom doc)
update data_layout and features for armv7-wrs-vxworks #62745 (update data_layout and features for armv7-wrs-vxworks)
Document link_section arbitrary bytes #62749 (Document link_section arbitrary bytes)
Disable Z3 in LLVM build #62752 (Disable Z3 in LLVM build)
normalize use of backticks in compiler messages for librustc/lint #62764 (normalize use of backticks in compiler messages for librustc/lint)
Disable simd_select_bitmask test on big endian #62774 (Disable simd_select_bitmask test on big endian)
Self-referencial type now called a recursive type #62777 (Self-referencial type now called a recursive type)
Emit artifact notifications for dependency files #62778 (Emit artifact notifications for dependency files)

Failed merges:

do not use assume_init in std::io #62746 ( do not use mem::uninitialized in std::io)

Ok, I can't use `std` in doc-links, only in doc-tests. Try 7...

…ding on Windows." This reverts commit 74a39a3.

When `rustc` is invoked with the `--print` argument, we don't actually generate any code (unless it's the `native-static-libs` option). So we don't need to error our in this case since there's no risk of generating either LLVM assertions or corrupted binaries.

…uity hint

Change some tests to `check-pass` that are only testing name resolution.

`normalize-stdout-test` removes the need for Make, and it can be updated with `--bless` this way

rust-lang#60532

Per rust-lang#59356 it is expected that the interpretation of the bitmask depends on target endianness. Closes rust-lang#59356

…acrum Fix hyperlinks in From impls between Vec and VecDeque I'd been trying to link them, but apparently actually just added brackets: <https://doc.rust-lang.org/nightly/std/collections/struct.VecDeque.html#impl-From%3CVec%3CT%3E%3E> ~~This reverts commit 5168f5d.~~ ~~(I'd previously tried to make relative links, but those failed linkcheck because the types are exported at different levels. So just skip the links -- they're already linked in the function signature anyway.)~~ This makes the links now work.

@EricRahm

Only error about MSVC + PGO + unwind if we're generating code In rust-lang#61853, we changed the error when using PGO & MSVC toolchain & panic=unwind into a warning. However, in the compiler team meeting on 2019-07-11, we found that not everybody was in favor of that change because of the possibility of broken binaries. This PR reverts that change so this is again an error. However, to work around an [issue the Firefox team is having](rust-lang#61002 (comment)), we will only emit the error if we're actually supposed to generate a binary. If the `rustc` is invoked with `--print` arguments (which means that no binary will actually be emitted), then we won't emit the error because there is not a possibility of the issue occurring. cc @EricRahm @nikomatsakis @pnkfelix @Centril

Check that trait is exported or public before adding hint Closes rust-lang#62194. This PR checks the `AccessLevels` of a trait to check whether adding the intercrate ambiguity hint is valid or not. I am unsure of both the use of `.unwrap()` as well as removing hints for [downstream *and* [upstream](https://github.com/rust-lang/rust/blob/92b0f52584c9375505ecdefdd7855b93a5919d51/src/librustc/traits/select.rs#L112-L142).

Update the help message on error for self type Fix rust-lang#62609

…nas-schievink Fix repeated wording in slice documentation Changes `of the slice of the slice` to `of the slice` in the chunk- and friends documentation of slices

…ochenkov Consolidate hygiene tests Some general clean-up extracted out from another PR

Remove last use of mem::uninitialized from std::io::util Addresses rust-lang#62397 for std::io::util

Add missing link to Infallible in TryFrom doc

update data_layout and features for armv7-wrs-vxworks

Document link_section arbitrary bytes Closes rust-lang#60633.

@alexcrichton

Disable Z3 in LLVM build Avoid building LLVM with Z3 if it happens to be installed. Fixes rust-lang#62750. r? @alexcrichton

…_compiler_messages_p7, r=alexreg normalize use of backticks in compiler messages for librustc/lint rust-lang#60532

Disable simd_select_bitmask test on big endian Per rust-lang#59356 it is expected that the interpretation of the bitmask depends on target endianness. Closes rust-lang#59356

…sion, r=eddyb Self-referencial type now called a recursive type As per Boat's suggestion - rust-lang#62539, this makes the error message clearer.

Emit artifact notifications for dependency files Emit `dep-info` artifact notifications for `.d` files.

Mark-Simulacrum · 2019-07-18T15:30:14Z

@bors r+ p=1

bors · 2019-07-18T15:30:16Z

📌 Commit 396903b has been approved by Mark-Simulacrum

Mark-Simulacrum · 2019-07-18T15:30:34Z

@bors p=10

bors · 2019-07-18T17:03:44Z

⌛ Testing commit 396903b with merge 311376d...

@ghost

Rollup of 15 pull requests Successful merges: - #61926 (Fix hyperlinks in From impls between Vec and VecDeque) - #62615 ( Only error about MSVC + PGO + unwind if we're generating code) - #62696 (Check that trait is exported or public before adding hint) - #62712 (Update the help message on error for self type) - #62728 (Fix repeated wording in slice documentation) - #62730 (Consolidate hygiene tests) - #62732 (Remove last use of mem::uninitialized from std::io::util) - #62740 (Add missing link to Infallible in TryFrom doc) - #62745 (update data_layout and features for armv7-wrs-vxworks) - #62749 (Document link_section arbitrary bytes) - #62752 (Disable Z3 in LLVM build) - #62764 (normalize use of backticks in compiler messages for librustc/lint) - #62774 (Disable simd_select_bitmask test on big endian) - #62777 (Self-referencial type now called a recursive type) - #62778 (Emit artifact notifications for dependency files) Failed merges: - #62746 ( do not use mem::uninitialized in std::io) r? @ghost

bors · 2019-07-18T20:41:33Z

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 311376d to master...

rust-highfive · 2019-07-18T20:43:55Z

📣 Toolstate changed by #62782!

Tested on commit 311376d.
Direct link to PR: #62782

💔 clippy-driver on windows: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).

@Manishearth

Tested on commit rust-lang/rust@311376d. Direct link to PR: <rust-lang/rust#62782> 💔 clippy-driver on windows: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).

(was merged as part of rust-lang/rust#62782 )

rustup rust-lang/rust#62764 (was merged as part of rust-lang/rust#62782 ) changelog: none

scottmcm and others added 30 commits July 3, 2019 00:05

Fix the links in Vec(Deque)-from-Vec(Deque)

38d4c1b

Ok, I can't use `std` in doc-links, only in doc-tests. Try 7...

Revert "Emit warning when trying to use PGO in conjunction with unwin…

374daa7

…ding on Windows." This reverts commit 74a39a3.

Update the help message on error for self type

b7cbd4e

Check that trait is exported or public before adding intercrate ambig…

2ced474

…uity hint

Suggested change

3c11944

fix double wording

4785311

found more repeated wording

9341e90

Change all run-pass hygiene tests to ui tests

03178f3

Change some tests to `check-pass` that are only testing name resolution.

Make pretty-expanded-hygiene a ui test

a4a7bb9

`normalize-stdout-test` removes the need for Make, and it can be updated with `--bless` this way

Remove last use of mem::uninitialized from std::io::util

04f0d30

Add missing link to Infallible in TryFrom doc

6471bd5

update data_layout and features

b793917

Document link_section arbitrary bytes

8c589bc

Disable Z3 in LLVM build

f8eb2a6

Requested change

14a1f72

Test case for rust-lang#62506.

387b6c3

normalize use of backticks in compiler messages for librustc/lint

e5e1397

rust-lang#60532

Disable simd_select_bitmask test on big endian

60529a7

Per rust-lang#59356 it is expected that the interpretation of the bitmask depends on target endianness. Closes rust-lang#59356

Self-referencial type renamed to recursive type.

c56c5a8

Emit artifact notifications for dependency files

f7d53a9

Rollup merge of rust-lang#62712 - limira:self-type-help, r=estebank

988a4ba

Update the help message on error for self type Fix rust-lang#62609

Rollup merge of rust-lang#62728 - DutchGhost:fix-double-wording, r=jo…

831d33b

…nas-schievink Fix repeated wording in slice documentation Changes `of the slice of the slice` to `of the slice` in the chunk- and friends documentation of slices

Rollup merge of rust-lang#62730 - matthewjasper:hygiene-tests, r=petr…

aa31ca7

…ochenkov Consolidate hygiene tests Some general clean-up extracted out from another PR

Rollup merge of rust-lang#62732 - nathanwhit:fix_mem_uninit, r=Amanieu

5d4681f

Remove last use of mem::uninitialized from std::io::util Addresses rust-lang#62397 for std::io::util

Rollup merge of rust-lang#62740 - lzutao:patch-2, r=alexcrichton

d961eb6

Add missing link to Infallible in TryFrom doc

Rollup merge of rust-lang#62745 - BaoshanPang:master, r=nikic

ee9d4e3

update data_layout and features for armv7-wrs-vxworks

Mark-Simulacrum added 6 commits July 18, 2019 11:29

Rollup merge of rust-lang#62749 - chocol4te:fix_60633, r=estebank

9c08b2b

Document link_section arbitrary bytes Closes rust-lang#60633.

Rollup merge of rust-lang#62752 - nikic:llvm-disable-z3, r=alexcrichton

c4977ef

Disable Z3 in LLVM build Avoid building LLVM with Z3 if it happens to be installed. Fixes rust-lang#62750. r? @alexcrichton

Rollup merge of rust-lang#62764 - fakenine:normalize_use_of_backticks…

0ae9048

…_compiler_messages_p7, r=alexreg normalize use of backticks in compiler messages for librustc/lint rust-lang#60532

Rollup merge of rust-lang#62774 - smaeul:pr/simd-tests, r=petrochenkov

ed83734

Disable simd_select_bitmask test on big endian Per rust-lang#59356 it is expected that the interpretation of the bitmask depends on target endianness. Closes rust-lang#59356

Rollup merge of rust-lang#62777 - gilescope:self-referencial-to-recur…

4544b4d

…sion, r=eddyb Self-referencial type now called a recursive type As per Boat's suggestion - rust-lang#62539, this makes the error message clearer.

Rollup merge of rust-lang#62778 - jsgf:notify-dep-info, r=petrochenkov

396903b

Emit artifact notifications for dependency files Emit `dep-info` artifact notifications for `.d` files.

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 18, 2019

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 18, 2019

bors merged commit 396903b into rust-lang:master Jul 18, 2019

bors mentioned this pull request Jul 18, 2019

do not use assume_init in std::io #62746

Merged

matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this pull request Jul 18, 2019

rustup rust-lang/rust#62764

deb586a

(was merged as part of rust-lang/rust#62782 )

matthiaskrgr mentioned this pull request Jul 18, 2019

rustup https://github.com/rust-lang/rust/pull/62764 rust-lang/rust-clippy#4285

Merged

bors added a commit to rust-lang/rust-clippy that referenced this pull request Jul 19, 2019

Auto merge of #4285 - matthiaskrgr:rustup_backticks, r=phansch

e5f2330

rustup rust-lang/rust#62764 (was merged as part of rust-lang/rust#62782 ) changelog: none

Mark-Simulacrum mentioned this pull request Jul 20, 2019

Spuriously merged PR rust-lang/homu#56

Closed

Centril added the rollup A PR which is a rollup label Oct 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 15 pull requests #62782

Rollup of 15 pull requests #62782

Mark-Simulacrum commented Jul 18, 2019

Mark-Simulacrum commented Jul 18, 2019

bors commented Jul 18, 2019

Mark-Simulacrum commented Jul 18, 2019

bors commented Jul 18, 2019

bors commented Jul 18, 2019

rust-highfive commented Jul 18, 2019

Rollup of 15 pull requests #62782

Rollup of 15 pull requests #62782

Conversation

Mark-Simulacrum commented Jul 18, 2019

Mark-Simulacrum commented Jul 18, 2019

bors commented Jul 18, 2019

Mark-Simulacrum commented Jul 18, 2019

bors commented Jul 18, 2019

bors commented Jul 18, 2019

rust-highfive commented Jul 18, 2019