Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normalize use of backticks in compiler messages for librustc_incremental #62832

Merged
merged 1 commit into from
Jul 22, 2019
Merged

normalize use of backticks in compiler messages for librustc_incremental #62832

merged 1 commit into from
Jul 22, 2019

Conversation

fakenine
Copy link
Contributor

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2019
@fakenine
Copy link
Contributor Author

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned estebank Jul 20, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-07-20T17:25:14.2713379Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-20T17:25:14.2914529Z ##[command]git config gc.auto 0
2019-07-20T17:25:14.2974817Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-20T17:25:14.3029741Z ##[command]git config --get-all http.proxy
2019-07-20T17:25:15.0827035Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62832/merge:refs/remotes/pull/62832/merge
---
2019-07-20T17:25:45.7400716Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-20T17:25:45.7400757Z 
2019-07-20T17:25:45.7401017Z   git checkout -b <new-branch-name>
2019-07-20T17:25:45.7401052Z 
2019-07-20T17:25:45.7401147Z HEAD is now at 3ee8f85f9 Merge 59977ec21f1fce1ce0efe3c340e67a0a5fae5e20 into 95b1fe560d2bd8472f250fb8cfd2168520a58405
2019-07-20T17:25:45.7543428Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-20T17:25:45.7546092Z ==============================================================================
2019-07-20T17:25:45.7546142Z Task         : Bash
2019-07-20T17:25:45.7546180Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-20T18:26:45.0121843Z .................................................................................................... 200/5839
2019-07-20T18:26:49.2650636Z .................................................................................................... 300/5839
2019-07-20T18:26:53.0468158Z .................................................................................................... 400/5839
2019-07-20T18:26:56.9081644Z .................................................................................................... 500/5839
2019-07-20T18:27:00.7795406Z ........................................................................i........................... 600/5839
2019-07-20T18:27:09.9580890Z .................................................................................................... 800/5839
2019-07-20T18:27:15.6973334Z .................................................................................................... 900/5839
2019-07-20T18:27:20.8188892Z ...................................................................................................i 1000/5839
2019-07-20T18:27:20.8188892Z ...................................................................................................i 1000/5839
2019-07-20T18:27:26.5112707Z ...........i........................................................................................ 1100/5839
2019-07-20T18:27:30.5697439Z .............................iiiii.................................................................. 1200/5839
2019-07-20T18:27:36.7682284Z .................................................................................................... 1400/5839
2019-07-20T18:27:39.5815212Z .................................................................................................... 1500/5839
2019-07-20T18:27:43.4463456Z .................................................................................................... 1600/5839
2019-07-20T18:27:46.1063055Z .................................................................................................... 1700/5839
2019-07-20T18:27:46.1063055Z .................................................................................................... 1700/5839
2019-07-20T18:27:49.6597561Z ...................................................................i................................ 1800/5839
2019-07-20T18:27:58.3252859Z .................................................................................................... 2000/5839
2019-07-20T18:28:02.7953122Z .................................................................................................... 2100/5839
2019-07-20T18:28:06.6946598Z .................................................................................................... 2200/5839
2019-07-20T18:28:06.6946598Z .................................................................................................... 2200/5839
2019-07-20T18:28:10.5944524Z ..................................................i................................................. 2300/5839
2019-07-20T18:28:20.5972469Z .................................................................................................... 2500/5839
2019-07-20T18:28:24.8654817Z .................................................................................................... 2600/5839
2019-07-20T18:28:30.0965316Z .................................................................................................... 2700/5839
2019-07-20T18:28:34.1745619Z .................................................................................................... 2800/5839
2019-07-20T18:28:34.1745619Z .................................................................................................... 2800/5839
2019-07-20T18:28:38.6418876Z .................................................................................................... 2900/5839
2019-07-20T18:28:44.0275501Z .................................................................................................... 3000/5839
2019-07-20T18:28:48.6134252Z .................................................................................................... 3100/5839
2019-07-20T18:28:54.0285086Z .................................................................................................... 3200/5839
2019-07-20T18:28:57.6232218Z .................................................................................................... 3300/5839
2019-07-20T18:29:01.4188766Z .................................................................................................... 3400/5839
2019-07-20T18:29:06.6208717Z .................................................................................................... 3500/5839
2019-07-20T18:29:10.5504447Z ................i................................................................................... 3600/5839
2019-07-20T18:29:14.7874221Z ..........................................................................................ii...i..ii 3700/5839
2019-07-20T18:29:24.0560011Z .................................................................................................... 3900/5839
2019-07-20T18:29:28.1835085Z .................................................................................................... 4000/5839
2019-07-20T18:29:28.1835085Z .................................................................................................... 4000/5839
2019-07-20T18:29:32.0705139Z ....ii.............................................................................................. 4100/5839
2019-07-20T18:29:34.2002597Z .........................i.......................................................................... 4200/5839
2019-07-20T18:29:36.3209810Z ...........................................................................................i........ 4300/5839
2019-07-20T18:29:44.0929920Z .................................................................................................... 4500/5839
2019-07-20T18:30:01.6292099Z .................................................................................................... 4600/5839
2019-07-20T18:30:05.1612356Z .................................................................................................... 4700/5839
2019-07-20T18:30:09.0869983Z .................................................................................................... 4800/5839
---
2019-07-20T18:30:43.7270566Z .................................................................................................... 5400/5839
2019-07-20T18:30:47.7277549Z .................................................................................................... 5500/5839
2019-07-20T18:30:51.9739367Z .................................................................................................... 5600/5839
2019-07-20T18:30:55.1960869Z .................................................................................................... 5700/5839
2019-07-20T18:30:58.2412358Z ...............................................................................i.................... 5800/5839
2019-07-20T18:30:59.7186896Z test result: ok. 5818 passed; 0 failed; 21 ignored; 0 measured; 0 filtered out
2019-07-20T18:30:59.7186946Z 
2019-07-20T18:30:59.7258736Z  finished in 271.001
2019-07-20T18:30:59.7430125Z Check compiletest suite=run-pass mode=run-pass (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-20T18:30:59.7430125Z Check compiletest suite=run-pass mode=run-pass (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-20T18:30:59.9767306Z 
2019-07-20T18:30:59.9767659Z running 2906 tests
2019-07-20T18:31:15.4839494Z .................................................................................................... 100/2906
2019-07-20T18:31:31.3852353Z ............................................................................i....................... 200/2906
2019-07-20T18:31:57.1981318Z .................................................................................................... 400/2906
2019-07-20T18:32:09.4213207Z .................................................................................................... 500/2906
2019-07-20T18:32:24.4845065Z .................................................................................................... 600/2906
2019-07-20T18:32:47.1312193Z .................................................................................................... 700/2906
2019-07-20T18:32:47.1312193Z .................................................................................................... 700/2906
2019-07-20T18:33:01.7480197Z .................................................................................................... 800/2906
2019-07-20T18:33:14.2200798Z .................................................................................................... 900/2906
2019-07-20T18:33:32.1491360Z .................................................................................................... 1000/2906
2019-07-20T18:33:46.8531164Z .................................................................................................... 1100/2906
2019-07-20T18:33:58.5601369Z .................................................................................................... 1200/2906
2019-07-20T18:34:11.6328616Z .................................................................................................... 1300/2906
2019-07-20T18:34:28.6269392Z ........ii.......................................................................................... 1400/2906
2019-07-20T18:34:41.6302548Z .................................................................................................... 1500/2906
2019-07-20T18:34:54.5859021Z ............................................................i.......i............................... 1600/2906
2019-07-20T18:35:28.5555764Z .................................................................................................... 1800/2906
2019-07-20T18:35:28.5555764Z .................................................................................................... 1800/2906
2019-07-20T18:35:44.2849691Z ............................................................................................i....... 1900/2906
2019-07-20T18:36:04.2158816Z ................................................................i................................... 2000/2906
2019-07-20T18:36:49.3526537Z .................................................................................................... 2200/2906
2019-07-20T18:37:04.2627394Z ...................................................................................................i 2300/2906
2019-07-20T18:37:24.2977197Z i................................................................................................... 2400/2906
2019-07-20T18:37:38.7463727Z .................................................................................................... 2500/2906
---
2019-07-20T18:40:02.1212250Z  finished in 32.827
2019-07-20T18:40:02.1388098Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-20T18:40:02.3008053Z 
2019-07-20T18:40:02.3009368Z running 146 tests
2019-07-20T18:40:05.5711244Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-07-20T18:40:07.5278593Z iii..............i.........iii.i......ii......
2019-07-20T18:40:07.5279480Z 
2019-07-20T18:40:07.5281525Z  finished in 5.389
2019-07-20T18:40:07.5456289Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-20T18:40:07.7084567Z 
2019-07-20T18:40:07.7084567Z 
2019-07-20T18:40:07.7085839Z running 39 tests
2019-07-20T18:40:09.9540050Z i.........i......................i.....
2019-07-20T18:40:09.9542458Z 
2019-07-20T18:40:09.9547324Z  finished in 2.408
2019-07-20T18:40:09.9736347Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-20T18:40:10.1312305Z 
2019-07-20T18:40:10.1312305Z 
2019-07-20T18:40:10.1312409Z running 9 tests
2019-07-20T18:40:10.1313110Z iiiiiiiii
2019-07-20T18:40:10.1313438Z 
2019-07-20T18:40:10.1313498Z  finished in 0.157
2019-07-20T18:40:10.1487201Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-20T18:40:10.3165484Z 
2019-07-20T18:40:10.3165484Z 
2019-07-20T18:40:10.3165744Z running 104 tests
2019-07-20T18:40:28.3295114Z .................................................................................................... 100/104
2019-07-20T18:40:29.0625306Z .F..
2019-07-20T18:40:29.0625530Z failures:
2019-07-20T18:40:29.0625564Z 
2019-07-20T18:40:29.0626792Z ---- [incremental] incremental/unchecked_dirty_clean.rs stdout ----
2019-07-20T18:40:29.0626835Z 
2019-07-20T18:40:29.0627187Z error in revision `cfail2`: /checkout/src/test/incremental/unchecked_dirty_clean.rs:13: unexpected error: '13:5: 13:46: found unchecked `#[rustc_dirty]` / `#[rustc_clean]` attribute'
2019-07-20T18:40:29.0627256Z 
2019-07-20T18:40:29.0629209Z error in revision `cfail2`: /checkout/src/test/incremental/unchecked_dirty_clean.rs:19: unexpected error: '19:5: 19:46: found unchecked `#[rustc_dirty]` / `#[rustc_clean]` attribute'
2019-07-20T18:40:29.0629263Z 
2019-07-20T18:40:29.0629689Z error in revision `cfail2`: /checkout/src/test/incremental/unchecked_dirty_clean.rs:27: unexpected error: '27:5: 27:46: found unchecked `#[rustc_dirty]` / `#[rustc_clean]` attribute'
2019-07-20T18:40:29.0629758Z 
2019-07-20T18:40:29.0630511Z error in revision `cfail2`: /checkout/src/test/incremental/unchecked_dirty_clean.rs:31: unexpected error: '31:5: 31:46: found unchecked `#[rustc_dirty]` / `#[rustc_clean]` attribute'
2019-07-20T18:40:29.0630572Z 
2019-07-20T18:40:29.0630663Z error in revision `cfail2`: /checkout/src/test/incremental/unchecked_dirty_clean.rs:13: expected error not found: found unchecked #[rustc_dirty]/#[rustc_clean] attribute
2019-07-20T18:40:29.0630715Z 
2019-07-20T18:40:29.0630777Z error in revision `cfail2`: /checkout/src/test/incremental/unchecked_dirty_clean.rs:19: expected error not found: found unchecked #[rustc_dirty]/#[rustc_clean] attribute
2019-07-20T18:40:29.0630817Z 
2019-07-20T18:40:29.0630902Z error in revision `cfail2`: /checkout/src/test/incremental/unchecked_dirty_clean.rs:27: expected error not found: found unchecked #[rustc_dirty]/#[rustc_clean] attribute
2019-07-20T18:40:29.0630943Z 
2019-07-20T18:40:29.0631011Z error in revision `cfail2`: /checkout/src/test/incremental/unchecked_dirty_clean.rs:31: expected error not found: found unchecked #[rustc_dirty]/#[rustc_clean] attribute
2019-07-20T18:40:29.0631070Z 
2019-07-20T18:40:29.0631123Z error in revision `cfail2`: 4 unexpected errors found, 4 expected errors not found
2019-07-20T18:40:29.0631175Z status: exit code: 1
2019-07-20T18:40:29.0632217Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/unchecked_dirty_clean.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "cfail2" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/unchecked_dirty_clean/unchecked_dirty_clean.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/unchecked_dirty_clean" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/unchecked_dirty_clean/auxiliary"
2019-07-20T18:40:29.0632498Z unexpected errors (from JSON output): [
2019-07-20T18:40:29.0632799Z     Error {
2019-07-20T18:40:29.0632844Z         line_num: 13,
2019-07-20T18:40:29.0632883Z         kind: Some(
2019-07-20T18:40:29.0632978Z         ),
2019-07-20T18:40:29.0632978Z         ),
2019-07-20T18:40:29.0633451Z         msg: "13:5: 13:46: found unchecked `#[rustc_dirty]` / `#[rustc_clean]` attribute",
2019-07-20T18:40:29.0633783Z     Error {
2019-07-20T18:40:29.0634066Z         line_num: 19,
2019-07-20T18:40:29.0634125Z         kind: Some(
2019-07-20T18:40:29.0634167Z             Error,
2019-07-20T18:40:29.0634167Z             Error,
2019-07-20T18:40:29.0634206Z         ),
2019-07-20T18:40:29.0634254Z         msg: "19:5: 19:46: found unchecked `#[rustc_dirty]` / `#[rustc_clean]` attribute",
2019-07-20T18:40:29.0634360Z     Error {
2019-07-20T18:40:29.0634646Z         line_num: 27,
2019-07-20T18:40:29.0634700Z         kind: Some(
2019-07-20T18:40:29.0634975Z             Error,
2019-07-20T18:40:29.0634975Z             Error,
2019-07-20T18:40:29.0635018Z         ),
2019-07-20T18:40:29.0635090Z         msg: "27:5: 27:46: found unchecked `#[rustc_dirty]` / `#[rustc_clean]` attribute",
2019-07-20T18:40:29.0635181Z     Error {
2019-07-20T18:40:29.0635244Z         line_num: 31,
2019-07-20T18:40:29.0635296Z         kind: Some(
2019-07-20T18:40:29.0635341Z             Error,
2019-07-20T18:40:29.0635341Z             Error,
2019-07-20T18:40:29.0635403Z         ),
2019-07-20T18:40:29.0635456Z         msg: "31:5: 31:46: found unchecked `#[rustc_dirty]` / `#[rustc_clean]` attribute",
2019-07-20T18:40:29.0635547Z ]
2019-07-20T18:40:29.0635594Z 
2019-07-20T18:40:29.0635640Z not found errors (from test file): [
2019-07-20T18:40:29.0635687Z     Error {
2019-07-20T18:40:29.0635687Z     Error {
2019-07-20T18:40:29.0635732Z         line_num: 13,
2019-07-20T18:40:29.0635795Z         kind: Some(
2019-07-20T18:40:29.0635841Z             Error,
2019-07-20T18:40:29.0635884Z         ),
2019-07-20T18:40:29.0636022Z         msg: "found unchecked #[rustc_dirty]/#[rustc_clean] attribute",
2019-07-20T18:40:29.0636124Z     Error {
2019-07-20T18:40:29.0636185Z         line_num: 19,
2019-07-20T18:40:29.0636230Z         kind: Some(
2019-07-20T18:40:29.0636274Z             Error,
2019-07-20T18:40:29.0636274Z             Error,
2019-07-20T18:40:29.0636317Z         ),
2019-07-20T18:40:29.0636395Z         msg: "found unchecked #[rustc_dirty]/#[rustc_clean] attribute",
2019-07-20T18:40:29.0636492Z     Error {
2019-07-20T18:40:29.0636557Z         line_num: 27,
2019-07-20T18:40:29.0636606Z         kind: Some(
2019-07-20T18:40:29.0636653Z             Error,
2019-07-20T18:40:29.0636653Z             Error,
2019-07-20T18:40:29.0636700Z         ),
2019-07-20T18:40:29.0636771Z         msg: "found unchecked #[rustc_dirty]/#[rustc_clean] attribute",
2019-07-20T18:40:29.0636867Z     Error {
2019-07-20T18:40:29.0636932Z         line_num: 31,
2019-07-20T18:40:29.0636980Z         kind: Some(
2019-07-20T18:40:29.0637035Z             Error,
2019-07-20T18:40:29.0637035Z             Error,
2019-07-20T18:40:29.0637099Z         ),
2019-07-20T18:40:29.0637152Z         msg: "found unchecked #[rustc_dirty]/#[rustc_clean] attribute",
2019-07-20T18:40:29.0637245Z ]
2019-07-20T18:40:29.0637294Z 
2019-07-20T18:40:29.0637723Z thread '[incremental] incremental/unchecked_dirty_clean.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:1503:13
2019-07-20T18:40:29.0637806Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
---
2019-07-20T18:40:29.0638706Z test result: FAILED. 103 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
2019-07-20T18:40:29.0638746Z 
2019-07-20T18:40:29.0643257Z 
2019-07-20T18:40:29.0644058Z 
2019-07-20T18:40:29.0646861Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/incremental" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "incremental" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-07-20T18:40:29.0647550Z 
2019-07-20T18:40:29.0647593Z 
2019-07-20T18:40:29.0648144Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:535:22
2019-07-20T18:40:29.0656218Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-20T18:40:29.0656218Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-20T18:40:29.0656295Z Build completed unsuccessfully in 1:08:12
2019-07-20T18:40:32.7462981Z ##[error]Bash exited with code '1'.
2019-07-20T18:40:32.7505686Z ##[section]Starting: Checkout
2019-07-20T18:40:32.7507104Z ==============================================================================
2019-07-20T18:40:32.7507163Z Task         : Get sources
2019-07-20T18:40:32.7507200Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@fakenine fakenine force-pushed the normalize_use_of_backticks_compiler_messages_p12 branch from 59977ec to 60ca55c Compare July 20, 2019 18:58
@Centril
Copy link
Contributor

Centril commented Jul 20, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 20, 2019

📌 Commit 60ca55c has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 21, 2019
@Centril
Rollup merge of rust-lang#62832 - fakenine:normalize_use_of_backticks…
6558b98 
…_compiler_messages_p12, r=Centril

normalize use of backticks in compiler messages for librustc_incremental

rust-lang#60532
@Centril Centril mentioned this pull request Jul 21, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jul 22, 2019
@Centril
Rollup merge of rust-lang#62832 - fakenine:normalize_use_of_backticks…
1289677 
…_compiler_messages_p12, r=Centril

normalize use of backticks in compiler messages for librustc_incremental

rust-lang#60532
@Centril Centril mentioned this pull request Jul 22, 2019
Merged
bors added a commit that referenced this pull request Jul 22, 2019
@bors
Auto merge of #62873 - Centril:rollup-ncnuelj, r=Centril
e649e90 
Rollup of 14 pull requests

Successful merges:

 - #62709 (Test that maplike FromIter satisfies uniqueness)
 - #62713 (Stabilize <*mut _>::cast and <*const _>::cast)
 - #62746 ( do not use assume_init in std::io)
 - #62787 (Fix typo in src/libstd/net/udp.rs doc comment)
 - #62788 (normalize use of backticks in compiler messages for libcore/ptr)
 - #62799 (use const array repeat expressions for uninit_array)
 - #62810 (normalize use of backticks in compiler messages for librustc_lint)
 - #62812 (normalize use of backticks in compiler messages for librustc_metadata)
 - #62832 (normalize use of backticks in compiler messages for librustc_incremental)
 - #62845 (read: fix doc comment)
 - #62853 (normalize use of backticks in compiler messages for librustc/hir)
 - #62854 (Fix typo in Unicode character name)
 - #62858 (Change wrong variable name.)
 - #62870 (fix lexing of comments with many \r)

Failed merges:

r? @ghost
@bors bors merged commit 60ca55c into rust-lang:master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fakenine @rust-highfive @Centril @bors @estebank