Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize use of backticks for compiler messages in remaining modules #62908

Conversation

fakenine
Copy link
Contributor

@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 23, 2019
@fakenine
Copy link
Contributor Author

r? @alexreg

Copy link
Contributor

@alexreg alexreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few tiny nits, otherwise looks good!

src/librustc_driver/pretty.rs Outdated Show resolved Hide resolved
src/librustc_passes/rvalue_promotion.rs Outdated Show resolved Hide resolved
src/librustc_passes/rvalue_promotion.rs Show resolved Hide resolved
@fakenine fakenine force-pushed the normalize_use_of_backticks_compiler_messages_p17 branch from afe79f9 to 66815c6 Compare July 23, 2019 21:10
@alexreg
Copy link
Contributor

alexreg commented Jul 23, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Jul 23, 2019

📌 Commit 66815c6 has been approved by alexreg

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2019
@alexreg
Copy link
Contributor

alexreg commented Jul 23, 2019

@bors p=2

@bors
Copy link
Contributor

bors commented Jul 23, 2019

⌛ Testing commit 66815c6 with merge 5d4c5be...

bors added a commit that referenced this pull request Jul 23, 2019
…essages_p17, r=alexreg

normalize use of backticks for compiler messages in remaining modules

#60532
Centril added a commit to Centril/rust that referenced this pull request Jul 23, 2019
…_compiler_messages_p17, r=alexreg

normalize use of backticks for compiler messages in remaining modules

rust-lang#60532
@Centril
Copy link
Contributor

Centril commented Jul 23, 2019

@bors retry

@bors
Copy link
Contributor

bors commented Jul 24, 2019

⌛ Testing commit 66815c6 with merge 4f10af26bf87ec72624cf10a32ef157993ca4ea1...

Centril added a commit to Centril/rust that referenced this pull request Jul 24, 2019
…_compiler_messages_p17, r=alexreg

normalize use of backticks for compiler messages in remaining modules

rust-lang#60532
@Centril
Copy link
Contributor

Centril commented Jul 24, 2019

@bors retry

bors added a commit that referenced this pull request Jul 24, 2019
Rollup of 11 pull requests

Successful merges:

 - #62261 (Take substs into account in `conservative_is_privately_uninhabited`)
 - #62528 (Add joining slices of slices with a slice separator, not just a single item)
 - #62738 (Remove uses of mem::uninitialized from std::sys::cloudabi)
 - #62784 (Add riscv32i-unknown-none-elf target)
 - #62808 (Revert "Disable stack probing for gnux32.")
 - #62814 (add support for hexagon-unknown-linux-musl)
 - #62822 (Improve some pointer-related documentation)
 - #62890 (Normalize use of backticks in compiler messages for libsyntax/*)
 - #62901 (cleanup: Remove `extern crate serialize as rustc_serialize`s)
 - #62905 (Normalize use of backticks in compiler messages for doc)
 - #62908 (normalize use of backticks for compiler messages in remaining modules)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Jul 24, 2019

⌛ Testing commit 66815c6 with merge 27a6a30...

bors added a commit that referenced this pull request Jul 24, 2019
…essages_p17, r=alexreg

normalize use of backticks for compiler messages in remaining modules

#60532
@bors
Copy link
Contributor

bors commented Jul 24, 2019

☀️ Test successful - checks-azure
Approved by: alexreg
Pushing 27a6a30 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 24, 2019
@bors bors merged commit 66815c6 into rust-lang:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants