Various alterations and additions to numeric methods #6301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y base logarithms
Both expm1 and ln1p have been renamed to exp_m1 and ln_1p in order to be consistent with the underscore usage elsewhere. The exp_m1 method is used for increased accuracy when doing floating point calculations, so this has been moved from the more general 'Exponential' trait into 'Float'.
| } | ||
|
|
||
| /// Returns the floating point category of the number. If only one property is going to | ||
| /// be tested, it is generally faster to use the specific predicate instead. |
There was a problem hiding this comment.
Are you sure that's true? At least if this method is inlined, I imagine the LLVM optimizer will be able to handle it well.
There was a problem hiding this comment.
Yeah you're probably right. I'll remove this in a future commit.
bors
added a commit
that referenced
this pull request
May 7, 2013
This is part of the redesign of the numeric traits tracked in issue #4819. Renamed: - `Exponential::expm1` -> `Float::exp_m1` - for consistency with underscore usage elsewhere - `Exponential::log` -> `Exponential::ln` - a less ambiguous name for the natural logarithm - `{float, f64, f32}::logarithm` -> `Exponential::log` - for arbitrary base logarithms - `Real::log_2` -> `Real::ln_2` - for consistency with `ln` - `Real::log_10` -> `Real::ln_10` - for consistency with `ln` Added: - `Signed::abs_sub` - wraps libm's `fdim` function - `Float::is_normal` - returns `true` if the number is neither zero, infinite, subnormal or NaN - `Float::classify` - returns the floating point category of the number - `Float::ln_1p` - returns the natural logarithm of the number plus one
2 tasks
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 20, 2020
do not trigger map_clone in the case of &mut fixes rust-lang#6299 changelog: do not trigger map_clone in the case of &mut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the redesign of the numeric traits tracked in issue #4819.
Renamed:
Exponential::expm1->Float::exp_m1- for consistency with underscore usage elsewhereExponential::log->Exponential::ln- a less ambiguous name for the natural logarithm{float, f64, f32}::logarithm->Exponential::log- for arbitrary base logarithmsReal::log_2->Real::ln_2- for consistency withlnReal::log_10->Real::ln_10- for consistency withlnAdded:
Signed::abs_sub- wraps libm'sfdimfunctionFloat::is_normal- returnstrueif the number is neither zero, infinite, subnormal or NaNFloat::classify- returns the floating point category of the numberFloat::ln_1p- returns the natural logarithm of the number plus one