Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo on Windows path separators #63103

Closed
wants to merge 1 commit into from
Closed

Fix typo on Windows path separators #63103

wants to merge 1 commit into from

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jul 29, 2019

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 29, 2019
@jonas-schievink
Copy link
Contributor

Huh, I didn't know you need to escape \ in code blocks. You don't have to do that on GitHub.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 29, 2019

📌 Commit 539ae1c has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2019
@ehuss
Copy link
Contributor

ehuss commented Jul 29, 2019

This is a known bug (see pulldown-cmark/pulldown-cmark#356 (comment)). If this is added, it will need to be reverted when it is fixed. The bad escapes show up in other places, too, so it seems odd to only fix it in one spot.

@jonas-schievink
Copy link
Contributor

@bors r-

Let's rather wait for a proper fix then.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 29, 2019
@ehuss
Copy link
Contributor

ehuss commented Jul 29, 2019

It may be reasonable to fix it now, and then revert it whenever pulldown-cmark is fixed. I'll ping the issue and see what the status is.

@ehuss
Copy link
Contributor

ehuss commented Jul 29, 2019

Oh, so I'm completely blind. This has already been fixed in 0.5.3, and is already on nightly via #62789.

@jonas-schievink
Copy link
Contributor

Oh, that's great. Might as well close this PR then and wait for the update to move to beta/stable.

@tesuji tesuji deleted the path-typo branch July 30, 2019 01:29
@Xanewok Xanewok mentioned this pull request Aug 4, 2019
Closed
@jonas-schievink jonas-schievink mentioned this pull request Aug 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jonas-schievink jonas-schievink

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tesuji @jonas-schievink @bors @ehuss @rust-highfive