Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 3 pull requests #63200

Closed
wants to merge 25 commits into from
Closed

Rollup of 3 pull requests #63200

wants to merge 25 commits into from

Commits on Jul 31, 2019

  1. Remove redundant method with const variable resolution

    @varkor
    varkor committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    87e73c1 View commit details
    Browse the repository at this point in the history

  2. Unify spanned and non-spanned Attribute ctors 

    There is no difference in the code/arguments, so go with the shorter
name throughout the code.
    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    804f0f3 View commit details
    Browse the repository at this point in the history

  3. Remove AttrId from Attribute constructors

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    0a42bad View commit details
    Browse the repository at this point in the history

  4. Remove Span argument from ExtCtxt::attribute 

    MetaItem.span was always equivalent
    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    b2c5065 View commit details
    Browse the repository at this point in the history

  5. Remove span argument from mk_attr_{inner,outer} 

    Always the same as the passed MetaItem
    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    f78bf50 View commit details
    Browse the repository at this point in the history

  6. Replace a few Attribute constructors with mk_attr

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    c9bd4a0 View commit details
    Browse the repository at this point in the history

  7. Replace AstBuilder with inherent methods

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    0f98581 View commit details
    Browse the repository at this point in the history

  8. Use Ident::new over setting span position via builder

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    d4227f6 View commit details
    Browse the repository at this point in the history

  9. Decode AttrId via mk_attr_id

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    c146344 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2019

  1. cast: no need to catch errors any more, force_bits should succeed

    @RalfJung
    RalfJung committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    c34466c View commit details
    Browse the repository at this point in the history

  2. operator: implement binary_op strictly by first checking the type, th… 

    …en dispatching further; call ptr_op machine hook only for pointer types
    @RalfJung
    RalfJung committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    4a55c46 View commit details
    Browse the repository at this point in the history

  3. turn cast_immediate into its own function

    @RalfJung
    RalfJung committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    ecc0f4c View commit details
    Browse the repository at this point in the history

  4. refactor cast_immediate to dispatch on the type first, and on the val… 

    …ue second
    @RalfJung
    RalfJung committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    479200b View commit details
    Browse the repository at this point in the history

  5. use From to convert scalars to immediates

    @RalfJung
    RalfJung committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    c79f222 View commit details
    Browse the repository at this point in the history

  6. fix casts from fat pointers

    @RalfJung
    RalfJung committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    f5f0ce9 View commit details
    Browse the repository at this point in the history

  7. improve error when CTFE does ptr-int-cast; update tests

    @RalfJung
    RalfJung committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    9cfda48 View commit details
    Browse the repository at this point in the history

  8. get rid of some remaining type-based dispatching in cast code

    @RalfJung
    RalfJung committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    b0b2a2f View commit details
    Browse the repository at this point in the history

  9. add is_any_ptr type test; this also helps pacify tidy

    @RalfJung
    RalfJung committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    3bf7377 View commit details
    Browse the repository at this point in the history

  10. trailing full stops 

    Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
    @RalfJung @Centril
    RalfJung and Centril committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    b4372e4 View commit details
    Browse the repository at this point in the history

  11. bless all the things

    @RalfJung
    RalfJung committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    c05155e View commit details
    Browse the repository at this point in the history

  12. const_prop no longer does ptr-to-int casts

    @RalfJung
    RalfJung committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    42aedec View commit details
    Browse the repository at this point in the history

  13. fix rebase fallout

    @RalfJung
    RalfJung committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    12a29d9 View commit details
    Browse the repository at this point in the history

  14. Rollup merge of rust-lang#62946 - RalfJung:miri_type_dispatch_first, … 

    …r=oli-obk

Miri: dispatch first on the type

Based on the fact that Miri now always has intptrcast available, we can change binops and casts to first check the type of the source operand and then decide based on that what to do, instead of considering the value (pointer vs bits) first.
    @Centril
    Centril committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    47f6b0d View commit details
    Browse the repository at this point in the history

  15. Rollup merge of rust-lang#63146 - Mark-Simulacrum:clean-attr, r=petro… 

    …chenkov

Cleanup syntax::attr

Mostly removing needless arguments to constructors

r? @petrochenkov
    @Centril
    Centril committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    53d5464 View commit details
    Browse the repository at this point in the history

  16. Rollup merge of rust-lang#63153 - varkor:remove-resolve_const_var, r=… 

    …cramertj

Remove redundant method with const variable resolution

I've also removed a `bug!()` in const value relation code and replaced it with a `FIXME`. Now `ConstValue::Slice` and `ConstValue::ByRef` will simply fail to unify rather than ICEing, which seems more user-friendly for testers.
    @Centril
    Centril committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    3faef22 View commit details
    Browse the repository at this point in the history