-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate urls for default trait items as well #63451
Generate urls for default trait items as well #63451
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Just like expected. :3 |
Ping from triage, @QuietMisdreavus can you please review this? @GuillaumeGomez thanks for the PR. Some checks are failing, please fix them. Thanks. |
e4c5ab0
to
0e69b3c
Compare
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
☔ The latest upstream changes (presumably #63639) made this pull request unmergeable. Please resolve the merge conflicts. |
For the record: I tried a few things and it seems that the only one which may work would be to keep the |
Ping from triage. @GuillaumeGomez can you please resolve the merge conflicts? I'm not sure what else needs to happen for this PR. Thanks |
To actually make it work? I wrote a small resume of what remained to be done in my previous comment. |
Ping from triage. @GuillaumeGomez @QuietMisdreavus Just letting you know, this has sat idle for 12 days |
Ping from Triage: Closing due to inactivity. Please re-open when/if there are updates. Thanks @GuillaumeGomez |
Fixes #62741
cc @rust-lang/rustdoc
I expect this PR to fail since a lot(?) of new URLs will be generated. I used the same model as for short doc on items in module view.