Remove some duplication when resolving constants #63766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 7dbc4b9 has been approved by |
bors
added
S-waiting-on-bors
Centril
reviewed
Aug 21, 2019
| } | ||
|
|
||
| #[inline] | ||
| pub fn eval( |
There was a problem hiding this comment.
Suggested change
| pub fn eval( | |
| pub fn interp( |
(in a follow up)
There was a problem hiding this comment.
I'm not sure if that is an improvement. We could call it normalize?
There was a problem hiding this comment.
My point was that we use "interp" in other contexts (just look at the module imports 😄) and we have moved away from "eval" so we should be consistent. normalize does seem more specific in this context however so that's better than both interp and eval.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 21, 2019
Remove some duplication when resolving constants
bors
added a commit
that referenced
this pull request
Aug 21, 2019
Rollup of 7 pull requests Successful merges: - #63721 (Do not emit JSON dumps of diagnostic codes) - #63753 (Bump toml dependency.) - #63755 (Use dedicated type for spans in pre-expansion gating.) - #63759 (Allow 'default async fn' to parse.) - #63760 (Update books) - #63762 (`async_await` was stabilized in 1.39.0, not 1.38.0.) - #63766 (Remove some duplication when resolving constants) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.