Refactor feature gates #63855
Merged
Refactor feature gates #63855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 24, 2019 17:45
Feature gate definitions were split into multiple files in rust-lang#63824 but tidy kept reporting the hard-coded path. Now, it shows the full path to the correct file.
This is just in preparation for future usage of these texts.
rust-highfive
added
the
S-waiting-on-review
Centril
suggested changes
Aug 24, 2019
|
Thanks for the review, @Centril! I've changed most of the loops you mentioned, so it'd be good to have a second look before I blindly r+ this :) |
killercup
force-pushed
the
refactor/feature-gates
branch
from
6b76fd2
to
6ffc834
Compare
Centril
approved these changes
Aug 24, 2019
|
@bors r+ |
|
📌 Commit 6ffc834 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 24, 2019
…=Centril Refactor feature gates After rust-lang#63824, this goes a few steps further by - parsing doc comments in the macros to extract descriptions for feature gates, and - introducing a common `Feature` type to replace the tuples used previously to improve readability. The descriptions are not yet used, but I felt like this PR is a useful enough refactoring on its own. r? @Centril
This comment has been minimized.
This comment has been minimized.
|
That's odd; I don't see anything that would cause this... @bors r- |
bors
added
S-waiting-on-author
This replaces the ad-hoc tuples used in the different feature gate files and unifies their content into a common type, leading to more readable matches and other good stuff that comes from having named fields. It also contains the description of each feature as extracted from the doc comment.
killercup
force-pushed
the
refactor/feature-gates
branch
from
6ffc834
to
1e6d3e2
Compare
|
Let's try this again! Tests pass locally but I'll wait for CI before sending it off to bors. |
This comment has been minimized.
This comment has been minimized.
Tries to clarify the filtering of active features and make the code more expressive.
killercup
force-pushed
the
refactor/feature-gates
branch
from
1e6d3e2
to
94e8ff4
Compare
|
@bors r=Centril rollup |
|
📌 Commit 94e8ff4 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 26, 2019
…=Centril Refactor feature gates After rust-lang#63824, this goes a few steps further by - parsing doc comments in the macros to extract descriptions for feature gates, and - introducing a common `Feature` type to replace the tuples used previously to improve readability. The descriptions are not yet used, but I felt like this PR is a useful enough refactoring on its own. r? @Centril
bors
added a commit
that referenced
this pull request
Aug 27, 2019
Rollup of 6 pull requests Successful merges: - #63317 (Do not complain about unused code when used in `impl` `Self` type) - #63693 (Fully implement or-pattern parsing) - #63836 (VxWorks does not provide a way to set the task name except at creation time) - #63845 (Removed a confusing FnOnce example) - #63855 (Refactor feature gates) - #63921 (add link to FileCheck docs) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #63824, this goes a few steps further by
Featuretype to replace the tuples used previously to improve readability.The descriptions are not yet used, but I felt like this PR is a useful enough refactoring on its own.
r? @Centril