Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustdoc: formatting to buffers #64044

Merged
merged 17 commits into from
Sep 8, 2019
Merged

Rustdoc: formatting to buffers #64044

merged 17 commits into from
Sep 8, 2019

Commits on Sep 7, 2019

  1. Add buffer abstraction

    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    f35eae9 View commit details
    Browse the repository at this point in the history

  2. Migrate top-level rendering to Buffer

    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    eebd026 View commit details
    Browse the repository at this point in the history

  3. Create buffers in top-level rendering 

    This avoids needlessly creating and threading the buffers through when
we only use them once.
    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    9e52ba9 View commit details
    Browse the repository at this point in the history

  4. Remove needless clone of layout

    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    3657bfc View commit details
    Browse the repository at this point in the history

  5. Move constant parameters to render to Layout struct

    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    57243b7 View commit details
    Browse the repository at this point in the history

  6. Replace writeln!/write! with push_str

    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    75528f2 View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary Buffer in layout::render

    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    04dc72e View commit details
    Browse the repository at this point in the history

  8. Move sidebar to Buffer-printing

    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    f8bccb1 View commit details
    Browse the repository at this point in the history

  9. Implement Print for FnOnce(&mut Buffer) 

    This means that callers can pass in a closure like
`|buf| some_function(..., &mut buf)` and pass in arbitrary arguments to
that function without complicating the trait definition. We also keep
the impl for str and String, since it's useful to be able to just pass
in "" or format!("{}"...) results in some cases.

This changes Print's definition to take self, instead of &self, because
otherwise FnOnce cannot be called directly. We could instead take FnMut
or even Fn, but that seems like it'd merely complicate matters -- most
of the time, the FnOnce does not constrain us at all anyway. If it does,
a custom Print impl for &'_ SomeStruct is not all that painful.
    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    f4a15ae View commit details
    Browse the repository at this point in the history

  10. Delete Sidebar struct in favor of FnOnce impl

    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    eefaee1 View commit details
    Browse the repository at this point in the history

  11. De-indent all fmt::Display impls for later replacement to functions

    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    d5f1470 View commit details
    Browse the repository at this point in the history

  12. layout::render takes Print instead of fmt::Display

    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    3f0e77f View commit details
    Browse the repository at this point in the history

  13. Move Source to Buffer

    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    bb40d5f View commit details
    Browse the repository at this point in the history

  14. Settings to function

    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    17bef30 View commit details
    Browse the repository at this point in the history

  15. AllTypes to function

    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    a502e85 View commit details
    Browse the repository at this point in the history

  16. Item to function

    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    c1c1e86 View commit details
    Browse the repository at this point in the history

  17. Move to buffers throughout print_item

    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    02c5c5c View commit details
    Browse the repository at this point in the history