Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop emitting impls for PartialEq::ne and PartialOrd::{lt, le, gt, ge} #64065

Closed
wants to merge 1 commit into from
Closed

Stop emitting impls for PartialEq::ne and PartialOrd::{lt, le, gt, ge} #64065

wants to merge 1 commit into from

Conversation

Mark-Simulacrum
Copy link
Member

These are never better optimized than calling the main method (eq,
partial_cmp) in the derived case. This makes us generate far less code,
which is a compile time win.

r? @ghost

Mostly opening this so that I can run perf on it to get a loose sense of whether this is worth it or not.

@Mark-Simulacrum
Copy link
Member Author

@bors try

cc #31972

@bors
Copy link
Contributor

bors commented Sep 1, 2019

⌛ Trying commit d3ae62aef6f483809d380ac31a92aa9705d1cb00 with merge b2d4196c0b1d453ff12c354918674dea88f8272b...

@rust-highfive
Copy link
Collaborator

The job mingw-check of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-09-01T13:28:52.5147112Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-01T13:28:52.5326902Z ##[command]git config gc.auto 0
2019-09-01T13:28:53.1298171Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-01T13:28:53.1305468Z ##[command]git config --get-all http.proxy
2019-09-01T13:28:53.1309426Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64065/merge:refs/remotes/pull/64065/merge
---
2019-09-01T13:37:22.7703688Z     Checking syntax_ext v0.0.0 (/checkout/src/libsyntax_ext)
2019-09-01T13:37:23.0216388Z error: unused import: `path_local`
2019-09-01T13:37:23.0239480Z  --> src/libsyntax_ext/deriving/cmp/partial_ord.rs:3:23
2019-09-01T13:37:23.0240258Z   |
2019-09-01T13:37:23.0241360Z 3 | use crate::deriving::{path_local, pathvec_std, path_std};
2019-09-01T13:37:23.0242030Z   |
2019-09-01T13:37:23.0242364Z   = note: `-D unused-imports` implied by `-D warnings`
2019-09-01T13:37:23.0242548Z 
2019-09-01T13:37:23.7561441Z error: aborting due to previous error
---
2019-09-01T13:38:12.6936507Z == clock drift check ==
2019-09-01T13:38:12.6951207Z   local time: Sun Sep  1 13:38:12 UTC 2019
2019-09-01T13:38:12.8458745Z   network time: Sun, 01 Sep 2019 13:38:12 GMT
2019-09-01T13:38:12.8459170Z == end clock drift check ==
2019-09-01T13:38:13.8130219Z ##[error]Bash exited with code '1'.
2019-09-01T13:38:13.8167220Z ##[section]Starting: Checkout
2019-09-01T13:38:13.8168828Z ==============================================================================
2019-09-01T13:38:13.8169003Z Task         : Get sources
2019-09-01T13:38:13.8169069Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job dist-x86_64-linux of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-09-01T13:51:24.6886501Z    Compiling syntax_ext v0.0.0 (/checkout/src/libsyntax_ext)
2019-09-01T13:51:24.9660434Z error: unused import: `path_local`
2019-09-01T13:51:24.9661309Z  --> src/libsyntax_ext/deriving/cmp/partial_ord.rs:3:23
2019-09-01T13:51:24.9661588Z   |
2019-09-01T13:51:24.9661887Z 3 | use crate::deriving::{path_local, pathvec_std, path_std};
2019-09-01T13:51:24.9662521Z   |
2019-09-01T13:51:24.9662827Z   = note: `-D unused-imports` implied by `-D warnings`
2019-09-01T13:51:24.9683002Z 
2019-09-01T13:51:25.7879312Z error: aborting due to previous error
---
2019-09-01T13:56:09.5310231Z == clock drift check ==
2019-09-01T13:56:09.5326473Z   local time: Sun Sep  1 13:56:09 UTC 2019
2019-09-01T13:56:10.0179824Z   network time: Sun, 01 Sep 2019 13:56:10 GMT
2019-09-01T13:56:10.0182178Z == end clock drift check ==
2019-09-01T13:56:12.6684545Z ##[error]Bash exited with code '1'.
2019-09-01T13:56:12.6717436Z ##[section]Starting: Upload CPU usage statistics
2019-09-01T13:56:12.6720861Z ==============================================================================
2019-09-01T13:56:12.6720930Z Task         : Bash
2019-09-01T13:56:12.6720997Z Description  : Run a Bash script on macOS, Linux, or Windows

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Sep 1, 2019

💔 Test failed - checks-azure

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 1, 2019
@rust-highfive
Copy link
Collaborator

The job mingw-check of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-09-01T14:02:46.5694179Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-01T14:02:46.5890952Z ##[command]git config gc.auto 0
2019-09-01T14:02:46.5971216Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-01T14:02:46.6030302Z ##[command]git config --get-all http.proxy
2019-09-01T14:02:46.6189314Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64065/merge:refs/remotes/pull/64065/merge
---
2019-09-01T14:10:48.7322052Z     Checking syntax_pos v0.0.0 (/checkout/src/libsyntax_pos)
2019-09-01T14:10:50.1474439Z     Checking rustc_errors v0.0.0 (/checkout/src/librustc_errors)
2019-09-01T14:10:51.4117900Z     Checking fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2019-09-01T14:11:04.5473529Z     Checking syntax_ext v0.0.0 (/checkout/src/libsyntax_ext)
2019-09-01T14:11:06.2706463Z error: variant is never constructed: `LtOp`
2019-09-01T14:11:06.2706949Z   --> src/libsyntax_ext/deriving/cmp/partial_ord.rs:60:5
2019-09-01T14:11:06.2708453Z 60 |     LtOp,
2019-09-01T14:11:06.2708776Z    |     ^^^^
2019-09-01T14:11:06.2709025Z    |
2019-09-01T14:11:06.2709330Z    = note: `-D dead-code` implied by `-D warnings`
2019-09-01T14:11:06.2709330Z    = note: `-D dead-code` implied by `-D warnings`
2019-09-01T14:11:06.2709374Z 
2019-09-01T14:11:06.2739030Z error: variant is never constructed: `LeOp`
2019-09-01T14:11:06.2739411Z   --> src/libsyntax_ext/deriving/cmp/partial_ord.rs:61:5
2019-09-01T14:11:06.2739985Z 61 |     LeOp,
2019-09-01T14:11:06.2740281Z    |     ^^^^
2019-09-01T14:11:06.2740323Z 
2019-09-01T14:11:06.2740323Z 
2019-09-01T14:11:06.2766543Z error: variant is never constructed: `GtOp`
2019-09-01T14:11:06.2767204Z   --> src/libsyntax_ext/deriving/cmp/partial_ord.rs:62:5
2019-09-01T14:11:06.2767769Z 62 |     GtOp,
2019-09-01T14:11:06.2768051Z    |     ^^^^
2019-09-01T14:11:06.2768093Z 
2019-09-01T14:11:06.2768093Z 
2019-09-01T14:11:06.2803371Z error: variant is never constructed: `GeOp`
2019-09-01T14:11:06.2804207Z   --> src/libsyntax_ext/deriving/cmp/partial_ord.rs:63:5
2019-09-01T14:11:06.2804787Z 63 |     GeOp,
2019-09-01T14:11:06.2805086Z    |     ^^^^
2019-09-01T14:11:06.2805130Z 
2019-09-01T14:11:06.2805130Z 
2019-09-01T14:11:06.2897866Z error: function is never used: `cs_op`
2019-09-01T14:11:06.2898226Z    --> src/libsyntax_ext/deriving/cmp/partial_ord.rs:154:1
2019-09-01T14:11:06.2898501Z     |
2019-09-01T14:11:06.2898837Z 154 | / fn cs_op(less: bool,
2019-09-01T14:11:06.2899174Z 155 | |          inclusive: bool,
2019-09-01T14:11:06.2899540Z 156 | |          cx: &mut ExtCtxt<'_>,
2019-09-01T14:11:06.2899882Z 157 | |          span: Span,
2019-09-01T14:11:06.2900779Z 269 | |     }
2019-09-01T14:11:06.2901104Z 270 | | }
2019-09-01T14:11:06.2901374Z     | |_^
2019-09-01T14:11:06.2901435Z 
---
2019-09-01T14:11:55.5453531Z == clock drift check ==
2019-09-01T14:11:55.5466908Z   local time: Sun Sep  1 14:11:55 UTC 2019
2019-09-01T14:11:55.6992329Z   network time: Sun, 01 Sep 2019 14:11:55 GMT
2019-09-01T14:11:55.6992924Z == end clock drift check ==
2019-09-01T14:11:56.6279582Z ##[error]Bash exited with code '1'.
2019-09-01T14:11:56.6321583Z ##[section]Starting: Checkout
2019-09-01T14:11:56.6323495Z ==============================================================================
2019-09-01T14:11:56.6323558Z Task         : Get sources
2019-09-01T14:11:56.6323611Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Mark-Simulacrum
Stop emitting impls for PartialEq::ne and PartialOrd::{lt, le, gt, ge}
23f30da 
These are never better optimized than calling the main method (eq,
partial_cmp) in the derived case. This makes us generate far less code,
which is a compile time win.
@Mark-Simulacrum
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Sep 1, 2019

⌛ Trying commit 23f30da with merge 44bcb9c...

bors added a commit that referenced this pull request Sep 1, 2019
@bors
Auto merge of #64065 - Mark-Simulacrum:no-useless-methods, r=<try>
44bcb9c 
Stop emitting impls for PartialEq::ne and PartialOrd::{lt, le, gt, ge}

These are never better optimized than calling the main method (eq,
partial_cmp) in the derived case. This makes us generate far less code,
which is a compile time win.

r? @ghost

Mostly opening this so that I can run perf on it to get a loose sense of whether this is worth it or not.
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-09-01T14:29:00.0939677Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-01T14:29:00.1144721Z ##[command]git config gc.auto 0
2019-09-01T14:29:00.1216140Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-01T14:29:00.1290607Z ##[command]git config --get-all http.proxy
2019-09-01T14:29:00.1448972Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64065/merge:refs/remotes/pull/64065/merge
---
2019-09-01T15:30:04.0144583Z .................................................................................................... 1400/8984
2019-09-01T15:30:10.5815867Z .................................................................................................... 1500/8984
2019-09-01T15:30:16.1723757Z .................................................................................................... 1600/8984
2019-09-01T15:30:29.0162626Z .................................................i...............i.................................. 1700/8984
2019-09-01T15:30:37.1611855Z ..............................................FFFF........F......................................... 1800/8984
2019-09-01T15:30:51.3685788Z ........................................iiiii....................................................... 1900/8984
2019-09-01T15:31:02.3354837Z .................................................................................................... 2100/8984
2019-09-01T15:31:04.8829894Z .................................................................................................... 2200/8984
2019-09-01T15:31:08.9934646Z .................................................................................................... 2300/8984
2019-09-01T15:31:16.5315940Z .................................................................................................... 2400/8984
---
2019-09-01T15:34:14.5066425Z ...........................i...............i........................................................ 4700/8984
2019-09-01T15:34:26.5046393Z .................................................................................................... 4800/8984
2019-09-01T15:34:32.8021730Z .................................................................................................... 4900/8984
2019-09-01T15:34:43.7032944Z .................................................................................................... 5000/8984
2019-09-01T15:34:49.3797966Z ........ii.ii....................................................................................... 5100/8984
2019-09-01T15:35:02.3460097Z .................................................................................................... 5300/8984
2019-09-01T15:35:10.4841907Z .......................................................................i............................ 5400/8984
2019-09-01T15:35:17.5798154Z .................................................................................................... 5500/8984
2019-09-01T15:35:24.2141498Z .................................................................................................... 5600/8984
2019-09-01T15:35:24.2141498Z .................................................................................................... 5600/8984
2019-09-01T15:35:34.6302213Z .................................................................ii...i..ii...........i............. 5700/8984
2019-09-01T15:35:59.7233814Z .................................................................................................... 5900/8984
2019-09-01T15:36:09.2186660Z .................................................................................................... 6000/8984
2019-09-01T15:36:09.2186660Z .................................................................................................... 6000/8984
2019-09-01T15:36:15.9662542Z ...................................................................i..ii............................ 6100/8984
2019-09-01T15:36:44.2739481Z .................................................................................................... 6300/8984
2019-09-01T15:36:46.2900479Z ......................i............................................................................. 6400/8984
2019-09-01T15:36:48.4275434Z ..............................................................................................i..... 6500/8984
2019-09-01T15:36:50.9994259Z .................................................................................................... 6600/8984
---
2019-09-01T15:40:43.6598310Z ---- [ui] ui/derives/derives-span-PartialEq-enum.rs stdout ----
2019-09-01T15:40:43.6598524Z diff of stderr:
2019-09-01T15:40:43.6598561Z 
2019-09-01T15:40:43.6598604Z 6    |
2019-09-01T15:40:43.6598655Z 7    = note: an implementation of `std::cmp::PartialEq` might be missing for `Error`
2019-09-01T15:40:43.6598725Z 8 
2019-09-01T15:40:43.6599194Z - error[E0369]: binary operation `!=` cannot be applied to type `Error`
2019-09-01T15:40:43.6600017Z -    |
2019-09-01T15:40:43.6600186Z - LL |      Error
2019-09-01T15:40:43.6600354Z -    |      ^^^^^
2019-09-01T15:40:43.6600529Z -    |
2019-09-01T15:40:43.6600529Z -    |
2019-09-01T15:40:43.6600749Z -    = note: an implementation of `std::cmp::PartialEq` might be missing for `Error`
2019-09-01T15:40:43.6601118Z - error: aborting due to 2 previous errors
2019-09-01T15:40:43.6601161Z + error: aborting due to previous error
2019-09-01T15:40:43.6601194Z 18 
2019-09-01T15:40:43.6601406Z 19 For more information about this error, try `rustc --explain E0369`.
2019-09-01T15:40:43.6601406Z 19 For more information about this error, try `rustc --explain E0369`.
2019-09-01T15:40:43.6601582Z 20 
2019-09-01T15:40:43.6601613Z 
2019-09-01T15:40:43.6601634Z 
2019-09-01T15:40:43.6601671Z The actual stderr differed from the expected stderr.
2019-09-01T15:40:43.6602001Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/derives/derives-span-PartialEq-enum/derives-span-PartialEq-enum.stderr
2019-09-01T15:40:43.6602222Z To update references, rerun the tests and pass the `--bless` flag
2019-09-01T15:40:43.6602487Z To only update this specific test, also pass `--test-args derives/derives-span-PartialEq-enum.rs`
2019-09-01T15:40:43.6602553Z error: 1 errors occurred comparing output.
2019-09-01T15:40:43.6602589Z status: exit code: 1
2019-09-01T15:40:43.6602589Z status: exit code: 1
2019-09-01T15:40:43.6603235Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/derives/derives-span-PartialEq-enum.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/derives/derives-span-PartialEq-enum" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/derives/derives-span-PartialEq-enum/auxiliary" "-A" "unused"
2019-09-01T15:40:43.6603518Z ------------------------------------------
2019-09-01T15:40:43.6603554Z 
2019-09-01T15:40:43.6603744Z ------------------------------------------
2019-09-01T15:40:43.6603797Z stderr:
2019-09-01T15:40:43.6603797Z stderr:
2019-09-01T15:40:43.6603980Z ------------------------------------------
2019-09-01T15:40:43.6604023Z error[E0369]: binary operation `==` cannot be applied to type `Error`
2019-09-01T15:40:43.6604478Z    |
2019-09-01T15:40:43.6604512Z LL |      Error //~ ERROR
2019-09-01T15:40:43.6604565Z    |      ^^^^^
2019-09-01T15:40:43.6604600Z    |
2019-09-01T15:40:43.6604600Z    |
2019-09-01T15:40:43.6604648Z    = note: an implementation of `std::cmp::PartialEq` might be missing for `Error`
2019-09-01T15:40:43.6604727Z error: aborting due to previous error
2019-09-01T15:40:43.6604751Z 
2019-09-01T15:40:43.6605136Z For more information about this error, try `rustc --explain E0369`.
2019-09-01T15:40:43.6605164Z 
2019-09-01T15:40:43.6605164Z 
2019-09-01T15:40:43.6605365Z ------------------------------------------
2019-09-01T15:40:43.6605398Z 
2019-09-01T15:40:43.6605419Z 
2019-09-01T15:40:43.6606114Z ---- [ui] ui/derives/derives-span-PartialEq-enum-struct-variant.rs stdout ----
2019-09-01T15:40:43.6606192Z diff of stderr:
2019-09-01T15:40:43.6606221Z 
2019-09-01T15:40:43.6606260Z 6    |
2019-09-01T15:40:43.6606309Z 7    = note: an implementation of `std::cmp::PartialEq` might be missing for `Error`
2019-09-01T15:40:43.6606374Z 8 
2019-09-01T15:40:43.6606664Z - error[E0369]: binary operation `!=` cannot be applied to type `Error`
2019-09-01T15:40:43.6607160Z -    |
2019-09-01T15:40:43.6607160Z -    |
2019-09-01T15:40:43.6607376Z - LL |      x: Error
2019-09-01T15:40:43.6607793Z -    |
2019-09-01T15:40:43.6607793Z -    |
2019-09-01T15:40:43.6608094Z -    = note: an implementation of `std::cmp::PartialEq` might be missing for `Error`
2019-09-01T15:40:43.6608532Z - error: aborting due to 2 previous errors
2019-09-01T15:40:43.6608599Z + error: aborting due to previous error
2019-09-01T15:40:43.6608763Z 18 
2019-09-01T15:40:43.6609066Z 19 For more information about this error, try `rustc --explain E0369`.
2019-09-01T15:40:43.6609066Z 19 For more information about this error, try `rustc --explain E0369`.
2019-09-01T15:40:43.6609133Z 20 
2019-09-01T15:40:43.6609160Z 
2019-09-01T15:40:43.6609355Z 
2019-09-01T15:40:43.6609392Z The actual stderr differed from the expected stderr.
2019-09-01T15:40:43.6609870Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/derives/derives-span-PartialEq-enum-struct-variant/derives-span-PartialEq-enum-struct-variant.stderr
2019-09-01T15:40:43.6610157Z To update references, rerun the tests and pass the `--bless` flag
2019-09-01T15:40:43.6610441Z To only update this specific test, also pass `--test-args derives/derives-span-PartialEq-enum-struct-variant.rs`
2019-09-01T15:40:43.6610524Z error: 1 errors occurred comparing output.
2019-09-01T15:40:43.6610558Z status: exit code: 1
2019-09-01T15:40:43.6610558Z status: exit code: 1
2019-09-01T15:40:43.6611203Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/derives/derives-span-PartialEq-enum-struct-variant.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/derives/derives-span-PartialEq-enum-struct-variant" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/derives/derives-span-PartialEq-enum-struct-variant/auxiliary" "-A" "unused"
2019-09-01T15:40:43.6611495Z ------------------------------------------
2019-09-01T15:40:43.6611523Z 
2019-09-01T15:40:43.6611704Z ------------------------------------------
2019-09-01T15:40:43.6611755Z stderr:
2019-09-01T15:40:43.6611755Z stderr:
2019-09-01T15:40:43.6611935Z ------------------------------------------
2019-09-01T15:40:43.6611978Z error[E0369]: binary operation `==` cannot be applied to type `Error`
2019-09-01T15:40:43.6612252Z    |
2019-09-01T15:40:43.6612252Z    |
2019-09-01T15:40:43.6612302Z LL |      x: Error //~ ERROR
2019-09-01T15:40:43.6612366Z    |
2019-09-01T15:40:43.6612366Z    |
2019-09-01T15:40:43.6612421Z    = note: an implementation of `std::cmp::PartialEq` might be missing for `Error`
2019-09-01T15:40:43.6612480Z error: aborting due to previous error
2019-09-01T15:40:43.6612502Z 
2019-09-01T15:40:43.6612736Z For more information about this error, try `rustc --explain E0369`.
2019-09-01T15:40:43.6612764Z 
2019-09-01T15:40:43.6612764Z 
2019-09-01T15:40:43.6612945Z ------------------------------------------
2019-09-01T15:40:43.6612970Z 
2019-09-01T15:40:43.6612990Z 
2019-09-01T15:40:43.6613202Z ---- [ui] ui/derives/derives-span-PartialEq-struct.rs stdout ----
2019-09-01T15:40:43.6613241Z diff of stderr:
2019-09-01T15:40:43.6613263Z 
2019-09-01T15:40:43.6613309Z 6    |
2019-09-01T15:40:43.6613526Z 7    = note: an implementation of `std::cmp::PartialEq` might be missing for `Error`
2019-09-01T15:40:43.6613569Z 8 
2019-09-01T15:40:43.6613779Z - error[E0369]: binary operation `!=` cannot be applied to type `Error`
2019-09-01T15:40:43.6614155Z -    |
2019-09-01T15:40:43.6614155Z -    |
2019-09-01T15:40:43.6614323Z - LL |     x: Error
2019-09-01T15:40:43.6614669Z -    |
2019-09-01T15:40:43.6614669Z -    |
2019-09-01T15:40:43.6614885Z -    = note: an implementation of `std::cmp::PartialEq` might be missing for `Error`
2019-09-01T15:40:43.6615260Z - error: aborting due to 2 previous errors
2019-09-01T15:40:43.6615300Z + error: aborting due to previous error
2019-09-01T15:40:43.6615333Z 18 
2019-09-01T15:40:43.6615560Z 19 For more information about this error, try `rustc --explain E0369`.
2019-09-01T15:40:43.6615560Z 19 For more information about this error, try `rustc --explain E0369`.
2019-09-01T15:40:43.6615936Z 20 
2019-09-01T15:40:43.6615967Z 
2019-09-01T15:40:43.6615992Z 
2019-09-01T15:40:43.6616057Z The actual stderr differed from the expected stderr.
2019-09-01T15:40:43.6616576Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/derives/derives-span-PartialEq-struct/derives-span-PartialEq-struct.stderr
2019-09-01T15:40:43.6616852Z To update references, rerun the tests and pass the `--bless` flag
2019-09-01T15:40:43.6617208Z To only update this specific test, also pass `--test-args derives/derives-span-PartialEq-struct.rs`
2019-09-01T15:40:43.6617297Z error: 1 errors occurred comparing output.
2019-09-01T15:40:43.6617363Z status: exit code: 1
2019-09-01T15:40:43.6617363Z status: exit code: 1
2019-09-01T15:40:43.6618263Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/derives/derives-span-PartialEq-struct.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/derives/derives-span-PartialEq-struct" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/derives/derives-span-PartialEq-struct/auxiliary" "-A" "unused"
2019-09-01T15:40:43.6618690Z ------------------------------------------
2019-09-01T15:40:43.6618728Z 
2019-09-01T15:40:43.6619003Z ------------------------------------------
2019-09-01T15:40:43.6619052Z stderr:
2019-09-01T15:40:43.6619052Z stderr:
2019-09-01T15:40:43.6619419Z ------------------------------------------
2019-09-01T15:40:43.6619487Z error[E0369]: binary operation `==` cannot be applied to type `Error`
2019-09-01T15:40:43.6619747Z    |
2019-09-01T15:40:43.6619747Z    |
2019-09-01T15:40:43.6619798Z LL |     x: Error //~ ERROR
2019-09-01T15:40:43.6619866Z    |
2019-09-01T15:40:43.6619866Z    |
2019-09-01T15:40:43.6619905Z    = note: an implementation of `std::cmp::PartialEq` might be missing for `Error`
2019-09-01T15:40:43.6619990Z error: aborting due to previous error
2019-09-01T15:40:43.6620013Z 
2019-09-01T15:40:43.6620227Z For more information about this error, try `rustc --explain E0369`.
2019-09-01T15:40:43.6620339Z 
2019-09-01T15:40:43.6620339Z 
2019-09-01T15:40:43.6621880Z ------------------------------------------
2019-09-01T15:40:43.6621938Z 
2019-09-01T15:40:43.6621959Z 
2019-09-01T15:40:43.6622226Z ---- [ui] ui/derives/derives-span-PartialEq-tuple-struct.rs stdout ----
2019-09-01T15:40:43.6622269Z diff of stderr:
2019-09-01T15:40:43.6622307Z 
2019-09-01T15:40:43.6622340Z 6    |
2019-09-01T15:40:43.6643628Z 7    = note: an implementation of `std::cmp::PartialEq` might be missing for `Error`
2019-09-01T15:40:43.6643683Z 8 
2019-09-01T15:40:43.6644288Z - error[E0369]: binary operation `!=` cannot be applied to type `Error`
2019-09-01T15:40:43.6644728Z -    |
2019-09-01T15:40:43.6644905Z - LL |     Error
2019-09-01T15:40:43.6645256Z -    |     ^^^^^
2019-09-01T15:40:43.6645434Z -    |
2019-09-01T15:40:43.6645434Z -    |
2019-09-01T15:40:43.6646168Z -    = note: an implementation of `std::cmp::PartialEq` might be missing for `Error`
2019-09-01T15:40:43.6646653Z - error: aborting due to 2 previous errors
2019-09-01T15:40:43.6646705Z + error: aborting due to previous error
2019-09-01T15:40:43.6646747Z 18 
2019-09-01T15:40:43.6647026Z 19 For more information about this error, try `rustc --explain E0369`.
2019-09-01T15:40:43.6647026Z 19 For more information about this error, try `rustc --explain E0369`.
2019-09-01T15:40:43.6647075Z 20 
2019-09-01T15:40:43.6647104Z 
2019-09-01T15:40:43.6647130Z 
2019-09-01T15:40:43.6647196Z The actual stderr differed from the expected stderr.
2019-09-01T15:40:43.6647556Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/derives/derives-span-PartialEq-tuple-struct/derives-span-PartialEq-tuple-struct.stderr
2019-09-01T15:40:43.6647832Z To update references, rerun the tests and pass the `--bless` flag
2019-09-01T15:40:43.6648159Z To only update this specific test, also pass `--test-args derives/derives-span-PartialEq-tuple-struct.rs`
2019-09-01T15:40:43.6648424Z error: 1 errors occurred comparing output.
2019-09-01T15:40:43.6648484Z status: exit code: 1
2019-09-01T15:40:43.6648484Z status: exit code: 1
2019-09-01T15:40:43.6649723Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/derives/derives-span-PartialEq-tuple-struct.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/derives/derives-span-PartialEq-tuple-struct" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/derives/derives-span-PartialEq-tuple-struct/auxiliary" "-A" "unused"
2019-09-01T15:40:43.6650060Z ------------------------------------------
2019-09-01T15:40:43.6650091Z 
2019-09-01T15:40:43.6650301Z ------------------------------------------
2019-09-01T15:40:43.6650349Z stderr:
2019-09-01T15:40:43.6650349Z stderr:
2019-09-01T15:40:43.6650547Z ------------------------------------------
2019-09-01T15:40:43.6650592Z error[E0369]: binary operation `==` cannot be applied to type `Error`
2019-09-01T15:40:43.6650880Z    |
2019-09-01T15:40:43.6650916Z LL |     Error //~ ERROR
2019-09-01T15:40:43.6651127Z    |     ^^^^^
2019-09-01T15:40:43.6651160Z    |
2019-09-01T15:40:43.6651160Z    |
2019-09-01T15:40:43.6651368Z    = note: an implementation of `std::cmp::PartialEq` might be missing for `Error`
2019-09-01T15:40:43.6651443Z error: aborting due to previous error
2019-09-01T15:40:43.6651466Z 
2019-09-01T15:40:43.6651676Z For more information about this error, try `rustc --explain E0369`.
2019-09-01T15:40:43.6651715Z 
2019-09-01T15:40:43.6651715Z 
2019-09-01T15:40:43.6651899Z ------------------------------------------
2019-09-01T15:40:43.6651925Z 
2019-09-01T15:40:43.6651945Z 
2019-09-01T15:40:43.6652165Z ---- [ui] ui/derives/deriving-no-inner-impl-error-message.rs stdout ----
2019-09-01T15:40:43.6652205Z diff of stderr:
2019-09-01T15:40:43.6652228Z 
2019-09-01T15:40:43.6652259Z 6    |
2019-09-01T15:40:43.6652305Z 7    = note: an implementation of `std::cmp::PartialEq` might be missing for `NoCloneOrEq`
2019-09-01T15:40:43.6652518Z 8 
2019-09-01T15:40:43.6652742Z - error[E0369]: binary operation `!=` cannot be applied to type `NoCloneOrEq`
2019-09-01T15:40:43.6653316Z -    |
2019-09-01T15:40:43.6653316Z -    |
2019-09-01T15:40:43.6653508Z - LL |     x: NoCloneOrEq
2019-09-01T15:40:43.6653873Z -    |
2019-09-01T15:40:43.6653873Z -    |
2019-09-01T15:40:43.6654108Z -    = note: an implementation of `std::cmp::PartialEq` might be missing for `NoCloneOrEq`
2019-09-01T15:40:43.6654276Z - 
2019-09-01T15:40:43.6654335Z 17 error[E0277]: the trait bound `NoCloneOrEq: std::clone::Clone` is not satisfied
2019-09-01T15:40:43.6654601Z 19    |
2019-09-01T15:40:43.6654639Z 
2019-09-01T15:40:43.6654671Z 22    |
2019-09-01T15:40:43.6654709Z 23    = note: required by `std::clone::Clone::clone`
---
2019-09-01T15:40:43.6655316Z 28 For more information about an error, try `rustc --explain E0277`.
2019-09-01T15:40:43.6655508Z 
2019-09-01T15:40:43.6655530Z 
2019-09-01T15:40:43.6655734Z The actual stderr differed from the expected stderr.
2019-09-01T15:40:43.6656320Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/derives/deriving-no-inner-impl-error-message/deriving-no-inner-impl-error-message.stderr
2019-09-01T15:40:43.6656592Z To update references, rerun the tests and pass the `--bless` flag
2019-09-01T15:40:43.6657071Z To only update this specific test, also pass `--test-args derives/deriving-no-inner-impl-error-message.rs`
2019-09-01T15:40:43.6657154Z error: 1 errors occurred comparing output.
2019-09-01T15:40:43.6657208Z status: exit code: 1
2019-09-01T15:40:43.6657208Z status: exit code: 1
2019-09-01T15:40:43.6658097Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/derives/deriving-no-inner-impl-error-message.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/derives/deriving-no-inner-impl-error-message" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/derives/deriving-no-inner-impl-error-message/auxiliary" "-A" "unused"
2019-09-01T15:40:43.6658487Z ------------------------------------------
2019-09-01T15:40:43.6658523Z 
2019-09-01T15:40:43.6658765Z ------------------------------------------
2019-09-01T15:40:43.6658812Z stderr:
2019-09-01T15:40:43.6658812Z stderr:
2019-09-01T15:40:43.6659043Z ------------------------------------------
2019-09-01T15:40:43.6659279Z error[E0369]: binary operation `==` cannot be applied to type `NoCloneOrEq`
2019-09-01T15:40:43.6659558Z    |
2019-09-01T15:40:43.6659558Z    |
2019-09-01T15:40:43.6659625Z LL |     x: NoCloneOrEq //~ ERROR binary operation `==` cannot be applied to type `NoCloneOrEq`
2019-09-01T15:40:43.6659702Z    |
2019-09-01T15:40:43.6659702Z    |
2019-09-01T15:40:43.6659742Z    = note: an implementation of `std::cmp::PartialEq` might be missing for `NoCloneOrEq`
2019-09-01T15:40:43.6659782Z 
2019-09-01T15:40:43.6659821Z error[E0277]: the trait bound `NoCloneOrEq: std::clone::Clone` is not satisfied
2019-09-01T15:40:43.6660122Z    |
2019-09-01T15:40:43.6660122Z    |
2019-09-01T15:40:43.6660157Z LL |     x: NoCloneOrEq
2019-09-01T15:40:43.6660231Z    |     ^^^^^^^^^^^^^^ the trait `std::clone::Clone` is not implemented for `NoCloneOrEq`
2019-09-01T15:40:43.6660316Z    = note: required by `std::clone::Clone::clone`
2019-09-01T15:40:43.6660342Z 
2019-09-01T15:40:43.6660377Z error: aborting due to 2 previous errors
2019-09-01T15:40:43.6660410Z 
---
2019-09-01T15:40:43.6694615Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:536:22
2019-09-01T15:40:43.6694713Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-09-01T15:40:43.6694745Z 
2019-09-01T15:40:43.6700190Z 
2019-09-01T15:40:43.6702605Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-09-01T15:40:43.6702883Z 
2019-09-01T15:40:43.6702907Z 
2019-09-01T15:40:43.6702958Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-09-01T15:40:43.6702997Z Build completed unsuccessfully in 1:04:56
2019-09-01T15:40:43.6702997Z Build completed unsuccessfully in 1:04:56
2019-09-01T15:40:43.6737772Z == clock drift check ==
2019-09-01T15:40:43.6753079Z   local time: Sun Sep  1 15:40:43 UTC 2019
2019-09-01T15:40:43.8252013Z   network time: Sun, 01 Sep 2019 15:40:43 GMT
2019-09-01T15:40:43.8253947Z == end clock drift check ==
2019-09-01T15:40:44.6425023Z ##[error]Bash exited with code '1'.
2019-09-01T15:40:44.6463697Z ##[section]Starting: Checkout
2019-09-01T15:40:44.6465154Z ==============================================================================
2019-09-01T15:40:44.6465197Z Task         : Get sources
2019-09-01T15:40:44.6465248Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Sep 1, 2019

☀️ Try build successful - checks-azure
Build commit: 44bcb9c

@Mark-Simulacrum
Copy link
Member Author

@rust-timer build 44bcb9c

@rust-timer
Copy link
Collaborator

Success: Queued 44bcb9c with parent d0677b9, comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit 44bcb9c, comparison URL.

@Mark-Simulacrum
Copy link
Member Author

This appears to be mostly a wash performance wise at least on the tests we have in-tree so I'm going to close this and the associated issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mark-Simulacrum @bors @rust-highfive @rust-timer