Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added warning around code with reference to uninit bytes #64123

Merged
merged 2 commits into from
Sep 5, 2019
Merged

Added warning around code with reference to uninit bytes #64123

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23c76ff
Added warning around code with reference to uninit bytes
Sep 3, 2019
b03d3dc
Changed comment to better reflect std's exceptional situation
Sep 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/libstd/io/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,14 @@ where
loop {
if g.len == g.buf.len() {
unsafe {
// FIXME(danielhenrymantilla): #42788
//
// - This creates a (mut) reference to a slice of
// _uninitialized integers_.
//
danielhenrymantilla marked this conversation as resolved.
Show resolved Hide resolved
// - This having defined behavior is **unstable**:
// it could become UB in the future,
// at which point it would have be changed.
g.buf.reserve(reservation_size(r));
let capacity = g.buf.capacity();
g.buf.set_len(capacity);
Expand Down