Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #64168

Closed
wants to merge 36 commits into from
Closed

Commits on Aug 21, 2019

  1. Configuration menu
    Copy the full SHA
    5a446c1 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2019

  1. Configuration menu
    Copy the full SHA
    b2b9b81 View commit details
    Browse the repository at this point in the history
  2. add regression test

    estebank committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    7ed542d View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2019

  1. Fix unlock ordering in SGX synchronization primitives

    Jethro Beekman committed Aug 31, 2019
    Configuration menu
    Copy the full SHA
    3c4d157 View commit details
    Browse the repository at this point in the history
  2. Add x86_64-linux-kernel target

    This adds a target specification for Linux kernel modules on x86_64, as well as base code that can be shared with other architectures.
    alex committed Aug 31, 2019
    7 Configuration menu
    Copy the full SHA
    5e933b4 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2019

  1. Fix const_err with -(-0.0)

    JohnTitor committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    35c9e5f View commit details
    Browse the repository at this point in the history
  2. Add opt-level check

    JohnTitor committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    3a6aada View commit details
    Browse the repository at this point in the history
  3. Add overflow_check check

    JohnTitor committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    4a0872b View commit details
    Browse the repository at this point in the history
  4. Fix overflow_check

    JohnTitor committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    8e9825a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0cd9c16 View commit details
    Browse the repository at this point in the history
  6. Fix tests again

    JohnTitor committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    a937d8c View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2019

  1. Configuration menu
    Copy the full SHA
    334d465 View commit details
    Browse the repository at this point in the history
  2. fix typo

    estebank committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    dd870d7 View commit details
    Browse the repository at this point in the history
  3. Fix const eval bug breaking run-pass tests in Miri

    PR rust-lang#63580 broke miri's ability to run the run-pass test suite with MIR
    optimizations enabled. The issue was that we weren't properly handling
    the substs and DefId associated with a Promoted value. This didn't break
    anything in rustc because in rustc this code runs before the Inliner
    pass which is where the DefId and substs can diverge from their initial
    values. It broke Miri though because it ran this code again after
    running the optimization pass.
    wesleywiser committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    46877e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2019

  1. Add match test cases

    estebank committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    c430d74 View commit details
    Browse the repository at this point in the history
  2. use TokenStream rather than &[TokenTree] for built-in macros

    That way, we don't loose the jointness info
    matklad committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    fa893a3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6136495 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2019

  1. Add compile flag

    JohnTitor committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    41deb83 View commit details
    Browse the repository at this point in the history
  2. remove XID and Pattern_White_Space unicode tables from libcore

    They are only used by rustc_lexer, and are not needed elsewhere.
    
    So we move the relevant definitions into rustc_lexer (while the actual
    unicode data comes from the unicode-xid crate) and make the rest of
    the compiler use it.
    matklad committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    a0c186c View commit details
    Browse the repository at this point in the history
  3. flatten rustc_lexer::character_properties module

    On the call site, `rustc_lexer::is_whitespace` reads much better than
    `character_properties::is_whitespace`.
    matklad committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    206fe8e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c86ea34 View commit details
    Browse the repository at this point in the history
  5. Rename --warnings=allow to --warnings=warn

    We never allowed the warnings, only made them not denied.
    Mark-Simulacrum committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    fda251b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    669c3e3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a2384cb View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2019

  1. Configuration menu
    Copy the full SHA
    9483db5 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#62848 - matklad:xid-unicode, r=petrochenkov

    Use unicode-xid crate instead of libcore
    
    This PR proposes to remove `char::is_xid_start` and `char::is_xid_continue` functions from `libcore` and use `unicode_xid` crate from crates.io (note that this crate is already present in rust-lang/rust's Cargo.lock).
    
    Reasons to do this:
    
    * removing rustc-binary-specific stuff from libcore
    * making sure that, across the ecosystem, there's a single definition of what rust identifier is (`unicode-xid` has almost 10 million downs, as a `proc_macro2` dependency)
    * making it easier to share `rustc_lexer` crate with rust-analyzer: no need to `#[cfg]` if we are building as a part of the compiler
    
    Reasons not to do this:
    
    * increased maintenance burden: we'll need to upgrade unicode version both in libcore and in unicode-xid. However, this shouldn't be a too heavy burden: just running `./unicode.py` after new unicode version. I (@matklad) am ready to be a t-compiler side maintainer of unicode-xid. Moreover, given that xid-unicode is an important dependency of syn, *someone* needs to maintain it anyway.
    * xid-unicode implementation is significantly slower. It uses a more compact table with binary search, instead of a trie. However, this shouldn't matter in practice, because we have fast-path for ascii anyway, and code size savings is a plus. Moreover, in rust-lang#59706 not using libcore turned out to be *faster*, presumably beacause checking for whitespace with match is even faster.
    
    <details>
    
    <summary>old description</summary>
    
    Followup to rust-lang#59706
    
    r? @eddyb
    
    Note that this doesn't actually remove tables from libcore, to avoid conflict with rust-lang#62641.
    
    cc unicode-rs/unicode-xid#11
    
    </details>
    Centril authored Sep 5, 2019
    Configuration menu
    Copy the full SHA
    4c268ca View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#63774 - chocol4te:fix_63707, r=GuillaumeGomez

    Fix `window.hashchange is not a function`
    
    Closes rust-lang#63707.
    Centril authored Sep 5, 2019
    Configuration menu
    Copy the full SHA
    e56fe69 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#63930 - estebank:rustdoc-ice, r=GuillaumeGomez

    Account for doc comments coming from proc macros without spans
    
    Fix rust-lang#63821.
    Centril authored Sep 5, 2019
    Configuration menu
    Copy the full SHA
    bdcc539 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#64030 - jethrogb:jb/sgx-sync-issues, r=alex…

    …crichton
    
    Fix unlock ordering in SGX synchronization primitives
    
    Avoid holding spinlocks during usercalls. This should avoid deadlocks in certain pathological scheduling cases.
    
    cc @mzohreva @parthsane
    
    r? @alexcrichton
    Centril authored Sep 5, 2019
    Configuration menu
    Copy the full SHA
    32cff1b View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#64041 - matklad:token-stream-tt, r=petroche…

    …nkov
    
    use TokenStream rather than &[TokenTree] for built-in macros
    
    That way, we don't loose the jointness info
    Centril authored Sep 5, 2019
    Configuration menu
    Copy the full SHA
    437e98f View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#64051 - alex:linux-kernel-module-target, r=…

    …joshtriplett
    
    Add x86_64-linux-kernel target
    
    This adds a target specification for Linux kernel modules on x86_64, as well as base code that can be shared with other architectures.
    
    I wasn't totally sure about what the best name for this was.
    
    There's one open question on whether we should use the LLVM generic x86_64-elf target, or the same one used for the Linux userspace.
    
    r? @joshtriplett
    Centril authored Sep 5, 2019
    Configuration menu
    Copy the full SHA
    05c6868 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#64063 - JohnTitor:fix-const-err, r=oli-obk

    Fix const_err with `-(-0.0)`
    
    Fixes rust-lang#64059
    
    r? @oli-obk
    Centril authored Sep 5, 2019
    Configuration menu
    Copy the full SHA
    49bc3f5 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#64083 - estebank:tweak-e0308, r=oli-obk

    Point at appropriate arm on type error on if/else/match with one non-! arm
    
    Fix rust-lang#61281.
    Centril authored Sep 5, 2019
    Configuration menu
    Copy the full SHA
    1893c61 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#64098 - Mark-Simulacrum:always-warn, r=alex…

    …crichton
    
    Ensure edition lints and internal lints are enabled with deny-warnings=false
    
    Previously we only passed the deny command line flags if deny-warnings was enabled, but now we either pass -W... or -D... for each of the flags as appropriate.
    
    This is also a breaking change to x.py as it changes `--warnings=allow` to `--warnings=warn` which is what that flag actually did; we don't have an allow warnings mode.
    Centril authored Sep 5, 2019
    Configuration menu
    Copy the full SHA
    4f27dd2 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#64100 - wesleywiser:fix_miri_const_eval, r=…

    …oli-obk
    
    Fix const eval bug breaking run-pass tests in Miri
    
    PR rust-lang#63580 broke miri's ability to run the run-pass test suite with MIR
    optimizations enabled. The issue was that we weren't properly handling
    the substs and DefId associated with a Promoted value. This didn't break
    anything in rustc because in rustc this code runs before the Inliner
    pass which is where the DefId and substs can diverge from their initial
    values. It broke Miri though because it ran this code again after
    running the optimization pass.
    
    r? @oli-obk
    cc @RalfJung
    Centril authored Sep 5, 2019
    Configuration menu
    Copy the full SHA
    15aeb27 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#64157 - gilescope:opaque-type-location, r=c…

    …ramertj,Centril
    
    Opaque type locations in error message for clarity.
    
    Attempts to fix rust-lang#63167
    Centril authored Sep 5, 2019
    Configuration menu
    Copy the full SHA
    44a6e39 View commit details
    Browse the repository at this point in the history