Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false "never constructed" warnings for Self:: variant paths #64424

Closed
wants to merge 1 commit into from
Closed

Fix false "never constructed" warnings for Self:: variant paths #64424

wants to merge 1 commit into from

Conversation

jakubadamw
Copy link
Contributor

Closes #64362.

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2019
@estebank
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 14, 2019

📌 Commit 10ed1f1 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 14, 2019
@Centril
Rollup merge of rust-lang#64424 - jakubadamw:issue-64362, r=estebank
4d32778 
Fix false "never constructed" warnings for `Self::` variant paths

Closes rust-lang#64362.
@Centril Centril mentioned this pull request Sep 14, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Sep 14, 2019

Assigning blame of failure in #64449 (comment) to this PR, @bors r-

(This is a guestimate)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 14, 2019
@jakubadamw
Copy link
Contributor Author

@Centril, no, the failure is unrelated.

@Centril
Copy link
Contributor

Centril commented Sep 14, 2019

@jakubadamw Any alternate theory? This PR seemed to be the only one related to TypeckTables somehow...

@jakubadamw
Copy link
Contributor Author

@Centril, sorry, you're absolutely right. Looking into this.

@JohnCSimon
Copy link
Member

Ping from triage.
@jakubadamw Hello! Can you please post your status regarding this PR?
Thank you.

@bors
Copy link
Contributor

bors commented Sep 27, 2019

☔ The latest upstream changes (presumably #64813) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnCSimon JohnCSimon added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Oct 5, 2019
@JohnCSimon
Copy link
Member

Ping from triage.
@jakubadamw This PR has sat idle for the last few weeks, I'm going to close this due to inactivity.
If you have time to move this forward please re-open this PR.
CC @estebank

Thank you!

@JohnCSimon JohnCSimon closed this Oct 5, 2019
@seiyab seiyab mentioned this pull request Feb 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"variant is never constructed" lint appears to be incorrect?
6 participants
@jakubadamw @rust-highfive @estebank @bors @Centril @JohnCSimon