Add long error explanation for E0550 #64838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in diagnostic error codes |
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
100 tasks
ghost
reviewed
Sep 27, 2019
src/libsyntax/error_codes.rs
Outdated
| The `deprecated` attribute can only be present **once** on an item. | ||
|
|
||
| ``` | ||
| #[deprecated(note = "because why not?")] |
There was a problem hiding this comment.
Suggested change
| #[deprecated(note = "because why not?")] | |
| #[deprecated(note = "because why not, right?")] |
maybe something like this would suggest merging the two attributes into one
oli-obk
reviewed
Sep 28, 2019
src/libsyntax/error_codes.rs
Outdated
| @@ -144,6 +144,25 @@ fn deprecated_function() {} | |||
| ``` | |||
| "##, | |||
|
|
|||
| E0550: r##" | |||
| More than one `deprecated` attribute have been put on an item. | |||
There was a problem hiding this comment.
Suggested change
| More than one `deprecated` attribute have been put on an item. | |
| More than one `deprecated` attribute has been put on an item. |
|
r? @oli-obk |
oli-obk
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
long-err-explanation-e0550
branch
from
4733f29
to
e67ae0e
Compare
|
Nits resolved, tests passed. @bors: r=oli-obk |
|
📌 Commit e67ae0e has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit e67ae0e with merge d78d6188048f40cd938e70990a85395777708698... |
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Sep 30, 2019
…-e0550, r=oli-obk Add long error explanation for E0550 Part of rust-lang#61137
|
@bors retry rolled up |
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Sep 30, 2019
…-e0550, r=oli-obk Add long error explanation for E0550 Part of rust-lang#61137
bors
added a commit
that referenced
this pull request
Oct 1, 2019
Rollup of 9 pull requests Successful merges: - #64377 (Add long error explanation for E0493) - #64786 (Use https for curl when building for linux) - #64828 (Graphviz debug output for generic dataflow analysis) - #64838 (Add long error explanation for E0550) - #64891 (Fix `vec![x; n]` with null raw fat pointer zeroing the pointer metadata) - #64893 (Zero-initialize `vec![None; n]` for `Option<&T>`, `Option<&mut T>` and `Option<Box<T>>`) - #64911 (Fixed a misleading documentation issue #64844) - #64921 (Add test for issue-64662) - #64923 (Add missing links for mem::needs_drop) Failed merges: - #64918 (Add long error explanation for E0551) r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #61137