Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow Self in type param defaults of ADTs #64842

Merged
merged 3 commits into from
Oct 4, 2019
Merged

Disallow Self in type param defaults of ADTs #64842

merged 3 commits into from
Oct 4, 2019

Commits on Oct 3, 2019

  1. The crux of the bug fix. 

    Update: review feedback
Update: placate tidy
    @pnkfelix
    pnkfelix committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    3a4921c View commit details
    Browse the repository at this point in the history

  2. Allocate a new diagnostic for defaulted type parameters cannot use `S… 

    …elf`

(Without this commit, you still get an error (a very similar one, at
that), but it complains about use of forward declaration, which is
confusing since people do not necessarily think of `Self` as being
declared at all.)

Update: incorporate review feedback.
    @pnkfelix
    pnkfelix committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    a18d424 View commit details
    Browse the repository at this point in the history

  3. Regression tests. 

    Update: incorporate review feedback.
    @pnkfelix
    pnkfelix committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    e443e1b View commit details
    Browse the repository at this point in the history