Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #65406

Closed
wants to merge 16 commits into from
Closed

Commits on Oct 2, 2019

  1. Configuration menu
    Copy the full SHA
    4eb5fcb View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2019

  1. Configuration menu
    Copy the full SHA
    76a7667 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    76fe6a4 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2019

  1. Tweak tcx usage in lub_concrete_regions().

    Some places use the local `tcx` variable, some use `self.tcx()`. This
    commit removes the local variable so that all places use `self.tcx()`,
    for consistency.
    nnethercote committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    53e7393 View commit details
    Browse the repository at this point in the history
  2. Special-case ReEmpty in expand_node().

    This wins 6% on `unicode_normalization`, by avoiding a call to
    `lub_concrete_regions()` and a `Region` equality test.
    nnethercote committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    59e41ed View commit details
    Browse the repository at this point in the history
  3. Remove tag from iterate_until_fixed_point().

    The function only has one call site, so we don't need a tag argument.
    nnethercote committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    8cd25e7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    373c362 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e8af4c1 View commit details
    Browse the repository at this point in the history
  6. expand: Simplify expansion of derives

    And make it more uniform with other macros.
    By merging placeholders for future derives' outputs into the derive container's output fragment early.
    petrochenkov committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    1270140 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2019

  1. Remove the Option in TokenStream.

    It means an allocation is required to create an empty `TokenStream`, but
    all other operations are simpler and marginally faster due to not having
    to check for `None`. Overall it simplifies the code for a negligible
    performance effect.
    
    The commit also removes `TokenStream::empty` by implementing `Default`,
    which is now possible.
    nnethercote committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    5c93492 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1ce0347 View commit details
    Browse the repository at this point in the history
  3. Lazify some mac_placeholder() calls.

    This avoids some unnecessary creation of empty token streams.
    nnethercote committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    18b48bf View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2019

  1. Rollup merge of rust-lang#64987 - oli-obk:code_reuse_prevents_bugs, r…

    …=eddyb
    
    Compute the layout of uninhabited structs
    
    fixes rust-lang#64506
    
    r? @eddyb
    Centril committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    9611993 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#65252 - petrochenkov:deriveholders2, r=matt…

    …hewjasper
    
    expand: Simplify expansion of derives
    
    And make it more uniform with other macros.
    This is done by merging placeholders for future derives' outputs into the derive container's output fragment early (addressing FIXMEs from rust-lang#63667).
    
    Also, macros with names starting with `_` are no longer reported as unused, in accordance with the usual behavior of `unused` lints.
    
    r? @matthewjasper or @mark-i-m
    Centril committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    9326cd4 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#65260 - nnethercote:optimize-LexicalResolve…

    …-expansion, r=nikomatsakis
    
    Optimize `LexicalResolve::expansion`.
    
    A win for `unicode_normalization`.
    
    r? @nikomatsakis
    Centril committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    d4b162a View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#65261 - nnethercote:rm-Option-from-TokenStr…

    …eam, r=petrochenkov
    
    Remove `Option` from `TokenStream`
    
    A code simplification.
    
    r? @petrochenkov
    Centril committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    ed9d45b View commit details
    Browse the repository at this point in the history