Suggest borrowing when it would satisfy an unmet trait bound #65456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
estebank
commented
Oct 16, 2019
| | ^^^^^^^ | ||
| | | | ||
| | expected an `FnMut<(char,)>` closure, found `std::string::String` | ||
| | help: consider borrowing here: `&pattern` |
There was a problem hiding this comment.
This is the particular common case (std::str::pattern::Pattern) that is encountered often by newcomers and this PR is meant to solve.
|
Stable: This PR: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
trait-bound-borrow
branch
from
99bf5dc
to
dc00b1a
Compare
This comment has been minimized.
This comment has been minimized.
bjorn3
reviewed
Oct 26, 2019
estebank
force-pushed
the
trait-bound-borrow
branch
from
dc00b1a
to
6f0731e
Compare
|
CC @Centril in case you're interested in this. |
|
.stderr diffs look good but the code is alien to me :) |
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
trait-bound-borrow
branch
from
6f0731e
to
001295b
Compare
|
ping @matthewjasper |
|
@bors r+ |
|
📌 Commit 001295beefad4b250b2d940fc1e023d1894bad18 has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-author
estebank
force-pushed
the
trait-bound-borrow
branch
2 times, most recently
from
8970e3a
to
85d7ff6
Compare
|
@bors r=matthewjasper |
|
📌 Commit 85d7ff6 has been approved by |
bors
removed
the
S-waiting-on-author
bors
added
the
S-waiting-on-review
estebank
force-pushed
the
trait-bound-borrow
branch
from
85d7ff6
to
e5e3c52
Compare
|
@bors r=matthewjasper |
|
📌 Commit e5e3c52e9e6561ff33184b4fe17adc2dbc071fe4 has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #66453) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
|
@bors r- |
When there are multiple implementors for the same trait that is present in an unmet binding, modify the E0277 error to refer to the parent obligation and verify whether borrowing the argument being passed in would satisfy the unmet bound. If it would, suggest it.
estebank
force-pushed
the
trait-bound-borrow
branch
from
e5e3c52
to
5c5cbc0
Compare
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
trait-bound-borrow
branch
from
5c5cbc0
to
2fe8371
Compare
|
@bors r=matthewjasper |
|
📌 Commit 2fe8371 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 18, 2019
Suggest borrowing when it would satisfy an unmet trait bound When there are multiple implementors for the same trait that is present in an unmet binding, modify the E0277 error to refer to the parent obligation and verify whether borrowing the argument being passed in would satisfy the unmet bound. If it would, suggest it. Fix #56368.
|
☀️ Test successful - checks-azure |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Nov 18, 2019
Tested on commit rust-lang/rust@361791b. Direct link to PR: <rust-lang/rust#65456> 🎉 rustc-guide on linux: test-fail → test-pass (cc @amanjeev @spastorino @mark-i-m, @rust-lang/infra).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are multiple implementors for the same trait that is present
in an unmet binding, modify the E0277 error to refer to the parent
obligation and verify whether borrowing the argument being passed in
would satisfy the unmet bound. If it would, suggest it.
Fix #56368.