Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename LocalInternedString and more #65776

Merged
merged 7 commits into from
Nov 6, 2019
Merged

Rename LocalInternedString and more #65776

merged 7 commits into from
Nov 6, 2019

Commits on Nov 1, 2019

  1. Rename LocalInternedString as SymbolStr. 

    It makes the relationship with `Symbol` clearer. The `Str` suffix
matches the existing `Symbol::as_str()` method nicely, and is also
consistent with it being a wrapper of `&str`.
    @nnethercote
    nnethercote committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    1b154a3 View commit details
    Browse the repository at this point in the history

  2. Remove an erroneous comment.

    @nnethercote
    nnethercote committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    2f7d7c2 View commit details
    Browse the repository at this point in the history

  3. Add some explanatory comments.

    @nnethercote
    nnethercote committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    e6d541a View commit details
    Browse the repository at this point in the history

  4. Remove some unnecessary renamings of constants.

    @nnethercote
    nnethercote committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    9cf59b5 View commit details
    Browse the repository at this point in the history

  5. Convert x.as_str().to_string() to x.to_string() where possible.

    @nnethercote
    nnethercote committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    5bc7084 View commit details
    Browse the repository at this point in the history

  6. Simplify various Symbol use points. 

    Including removing a bunch of unnecessary `.as_str()` calls, and a bunch
of unnecessary sigils.
    @nnethercote
    nnethercote committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    b9cef69 View commit details
    Browse the repository at this point in the history

  7. Remove the AsRef impl for SymbolStr. 

    Because it's highly magical, which goes against the goal of keeping
`SymbolStr` simple. Plus it's only used in a handful of places that
only require minor changes.
    @nnethercote
    nnethercote committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    d0db290 View commit details
    Browse the repository at this point in the history